Commit Graph

6983 Commits

Author SHA1 Message Date
Carsten Haitzler 9d5483963a e - tiling module - silence warning (real possibility of an issue)
grand_parent couldbe used in an uninitialized state - this is right.
it'd be garbage (not NULL). set to NULL always to be safe
2014-11-25 17:11:18 +09:00
Leif Middelschulte 6a92676cf8 Implement FreeDesktop .deskop Additional Actions menu
Summary:
This implements the additional actions as specified in
FreeDesktop.org's desktop entry specification 1.1.
This version is implemented by Efreet 1.12

The additional actions are presented as right-click
menu entries.

@feature

Reviewers: zmike

Subscribers: tasn, q66, cedric

Differential Revision: https://phab.enlightenment.org/D1657
2014-11-24 13:33:02 -05:00
Stefan Schmidt 38432f93d5 music-control: Update generated code after various eldbus-codegen fixes
This includes the fixes for working propset callback as well as memory
leak fixes.
2014-11-24 10:52:59 +01:00
Carsten Haitzler 87baecb098 Revert "windows - allow close button to work again in internal wins"
This reverts commit 285951c8cb.
2014-11-23 13:54:14 +09:00
Carsten Haitzler 285951c8cb windows - allow close button to work again in internal wins
since the move to elm_win ... windows don't close with close button in
the titlebar. this fixes that in the simplest way - enabling autodel
on the window.
2014-11-22 18:46:10 +09:00
q66 d12ef91687 rename WEIGHT/ALIGN/EXPAND/FILL to E_WEIGHT/E_ALIGN/E_EXPAND/E_FILL
Otherwise there were macro clashes with a systemwide include.
Also remove a leftover E_Hal.h include.
2014-11-21 20:10:46 +00:00
Marcel Hollerbach 3036de64bc wizard: use eina_list_free to free the list
eina_list_free is doing what I did the complex way with the macro.
2014-11-21 19:57:59 +01:00
Marcel Hollerbach 51fe04e6ed wizard: Fix the resolving of the FIXME comment
Summary:
Commit rE5b992bdc4a76 added the free for the list, the list is filed
with static pointers from the .c file, soo free will crash.

This pointer does not need to be freed, just freeing the list.

Test Plan: Just run the wizard

Reviewers: zmike

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1679
2014-11-21 10:27:27 -05:00
Mike Blumenkrantz 18c1e3620d fix fileman crash when restarting with window open 2014-11-20 15:26:22 -05:00
Mike Blumenkrantz 99589eb5af remove E_Win+e_canvas, convert all internal wins to use elm_win
known issues:

* keybindings for efm windows (eg. ctrl+w) are broken until the rest of the conversion is completed
2014-11-20 15:26:21 -05:00
Mike Blumenkrantz caf521875c remove dead conf_display file 2014-11-20 15:26:18 -05:00
kabeer khan 5b992bdc4a Wizard : Resolved FIXME added code to free blang_list in page_010
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: zmike, devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1570
2014-11-12 14:25:07 -05:00
Stefan Schmidt 40cbdbc674 modules/music-control: Add Tomahawk as compatible player.
This list is getting longer and longer. Maybe we should think about
autodetecting available players on the session bus?
2014-11-07 09:05:32 +01:00
Jake Jaeseok Yoon 273133ffea src/modules/clock/module.desktop.in korean add
Summary: 시계(Korean expression of clock) add src/modules/clock/module.desktop.in

Subscribers: cedric, JakeYoon

Differential Revision: https://phab.enlightenment.org/D1591
2014-11-05 17:08:49 +09:00
Chris Michael dd983b2e79 wl-desktop-shell: Always set netwm.ping on the client
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-11-03 12:27:13 -05:00
Tom Hacohen c702763df7 Tiling: Fix up previous tiling commit (make it safer).
This is the second time recently I forgot to merge commits. :(
2014-11-03 14:45:03 +00:00
Marcel Hollerbach ca1a531c78 tiling: Fix issue with window-moving and windows not breaking out.
Summary:
The module is now working like it is described in T1773.

What the patch really does:
If a join request can not be done cause there is no node in the
direction to join, the join will try to break out the node into the
grand-grand-parent, this means a node can break out of his parent
without walking done each parent.

Issue as described in the original ticket:
Each number represents a different window:

122
134
155

Focus on 3, press Win+Left

I'd expect it to become:
132
134
135

But instead, nothing happens.

Fixes T1773

Reviewers: tasn

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1632
2014-11-03 14:35:46 +00:00
Chris Michael 1fd35b0636 wl_desktop_shell: Remove silly debug message
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-30 10:39:08 -04:00
Chris Michael 1203b36635 wl_desktop_shell: Remove resize.width/height compositor data fields.
Add some debugging print outs.
Don't check client size compared to new size.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-30 10:39:08 -04:00
Chris Michael 7cb087238d wl-desktop-shell: Don't call e_client_ping here.
Summary: As pointed out by shiin, this causes an infinite loop due to
e_client_ping already been called in the pre_frame callback. Thanks
for spotting this !! :)

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-30 08:41:04 -04:00
vivek bcd3c6de49 wl_desktop_shell: Fixed the issue to check if wl surface is active or hung up
Summary:
The patch will setup e_client_cb_ping_poller and as long as wl_surface is
active it will unset hung

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1608
2014-10-29 10:38:06 -04:00
Chris Michael 9ad13e4fcc wl_desktop_shell: Fix formatting
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-29 10:35:24 -04:00
vivek 0a60b1c553 wl_desktop_shell: Fixed the issue to check if client is active or hung up
Summary:
The patch will setup e_client_cb_ping_poller and as long as surface is
active it will unset hung

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1607
2014-10-29 10:34:26 -04:00
vivek 5f57c472b2 wl_desktop_shell: Implemented function to show xdg shell surface menu
Summary:
Implemented _e_xdg_shell_surface_cb_window_menu_show internal function
to show window menu.

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1606
2014-10-29 09:51:28 -04:00
Tom Hacohen d8b473b5c3 tiling: fix coding conventions and style.
Should have been squashed into the previous commit. :(
Anyhow, this fixes conventions and some potentially
dangerous style choices.
2014-10-29 08:25:04 +00:00
Marcel Hollerbach 4c0f0c638f tiling: Implemented tiling window position manipulation
Summary:
This implements the possibility to "break out" a node in the tree which
means that the node will be appended or prependen to the parent in the
grandparent.

The other function "joins" the node to the node before or after.
Basically it will be added as a child, and if necessarry the client
of this node will be added in a new Window Tree and also added as a child.

With the new actions you can move the focused window right/left/up/down
with keybindings.

If the window will "break out" or "join" depends on the parent split type.

Sample:
1|4|6
2|4|6
3|5|6

(Same Number means same Window)

1 is focused.
Left Key is pressed.

1 is in a vertical split so the window will "break out".
Result:
2|1|4|6
2|1|5|6

Now another key:
Down Key is pressed.

1 is in a vertical split so the window will "join".
Result:
1|2|4|6
3 3|5|6

@feature

Fixes T1350

Reviewers: tasn

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1382
2014-10-29 08:15:19 +00:00
Jean-Philippe Andre 310c10bca8 Really fix the compilation with wayland
... I hope.
2014-10-24 19:26:55 +09:00
Tom Hacohen a8d8844d5c Fix tiling window properties restore issues with iconify.
Windows properties (like border) weren't being restored on iconify.
2014-10-23 13:37:59 +01:00
Brian 'morlenxus' Miculcy 503bd482bd enlightenment/conf: fix missing icons in settings panel
Shows the 'unknown' icon for settings panel items which have no icon defined.
@fix
2014-10-20 16:55:29 +02:00
Chris Michael 7498dbac99 don't crash when closing internal dialog boxes
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-12 10:08:05 -04:00
Mike Blumenkrantz 355152880d fix teamwork popup positioning for non-dbus popups 2014-10-12 04:49:21 -04:00
Boris Faure 11f8c10367 notification: don't segv if no zone found to place the popup
@fix
2014-10-12 10:23:31 +02:00
Chris Michael 40935c3c45 send xdg surface configure message when we maximize/unmaximize.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-06 15:57:36 -04:00
Chris Michael 6a07c9f99d wl-desktop-shell: Update module code for new xdg shell protocol
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-01 16:15:00 -04:00
Chris Michael 702e32ea2a wl-desktop-shell: Update desktop shell module for new xdg shell protocol
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-01 16:15:00 -04:00
Chris Michael 44168b4a36 wl-desktop-shell: Bump xdg protocol version
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-10-01 16:15:00 -04:00
Mike Blumenkrantz cbcb1130b6 thaw evas on winlist activation with no clients available
fix T1667
2014-09-23 13:17:45 -04:00
Wonguk Jeong 32efb7e5e4 conf_application: fix crash on setting Desktop Environment
use e_util_strcmp instead of strcmp. (previously, NULL check was omitted)

Fixes T1673
2014-09-22 12:04:11 +02:00
Cedric BAIL ed0efbe926 lokker: empty string should not be translated.
@fix
2014-09-22 09:07:00 +02:00
Stefan Schmidt 98457f7332 modules/mixer: Check fcntl setting CLOEXEC for success
We still keep going if this fails but print out an error.

CID: 1039960
2014-09-19 11:30:38 +02:00
Stefan Schmidt bbd35e82c3 modules/teamwork: Use eina_file_mkstemp() to avoid problems with umask
Keeping the snprintf to arrange for the tmp file name including the i->addr
in the filename.

CID: 1039805
2014-09-19 11:30:28 +02:00
Stefan Schmidt 4e98f7cb18 modules/pager: We already dereferenced pw->desk before, no need to check now
We already dereferenced it a few lines before thus we could never reach this
here when it would be NULL.

CID: 1039809
2014-09-19 11:30:04 +02:00
Stefan Schmidt 88f4b19f30 modules/teamwork: The ih value would never be < 1 as we checked it already.
ih did not check since the last time we checked it for < 1 a few lines before.

CID: 1232000
2014-09-19 11:29:47 +02:00
Stefan Schmidt 3a1cc22f83 modules/lokker: Array address is never NULL.
This would always be true. Comparing against the first array item is fine.

CID: 1155284
2014-09-19 11:29:27 +02:00
Stefan Schmidt 5e4cdb9064 modules/wl_drm: Remove trailing whitespaces 2014-09-19 09:52:58 +02:00
Chris Michael 25a8be59c5 Cleanup teamwork module from having missing initializerss for Eldbus
Messages & Signals

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-18 14:51:59 -04:00
Sebastian Dransfeld 8c46220dd6 e: Improve code 2014-09-18 20:32:27 +02:00
Chris Michael 7861f5e69c bugfix: Cleanup systray module having missing initializers for Eldbus
Message & Signals

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-18 14:17:50 -04:00
Chris Michael f168e42b45 bugfix: Cleanup msgbus module from having missing field initializers
for Eldbus Messages & Signals

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-18 14:07:36 -04:00
Chris Michael d207db2fdf bugfix: Cleanup fileman module from having missing initializers for
Eldbus Messages & Signals

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-18 14:07:36 -04:00
Chris Michael 23e430be25 bugfix: Cleanup bluex module having missing initializers for services
& icons

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-18 14:07:30 -04:00
Chris Michael 5813889aa2 bugfix: Cleanup appmenu module having missing field initializers for
Eldbus Messages & Signals

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-18 13:35:38 -04:00
Sebastian Dransfeld 764755eb9f e: Add preferred desktop environment for apps
In preferences we show which external applications can be used for
setting preferences. If several desktop environments are installed, this
list will have several duplicates, as there can be many different apps
for setting a preference.

With this setting we can filter out for one desktop_environment.

@feature
2014-09-18 10:51:42 +02:00
Carsten Haitzler 1412f28b51 mixer: Optionally select an external mixer application.
This feature allows to define an external mixer application, which replaces
the internal mixer.
Examples: 'terminology -e alsamixer', 'pavucontrol'
@feature

this re-commits this with tab fixes (no tabs)
2014-09-17 13:31:02 +09:00
bootleg 8341f10634 Adding support for Pithos (http://pithos.github.io/) in the music-control module. Play/pause, skip, and lock screen are confirmed to work correctly with the latest version. Additional functions (Ban, Tired, etc.) aren't working just yet and the...
Summary: ...image of the current track is also not passed just yet.

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1437
2014-09-16 11:48:43 +02:00
kabeer khan bd18e264f4 Added Caps Lock On/Off Hint in Lock Screen
Summary: Signed-off-by: kabeer khan <kabeer.khan@samsung.com>

Reviewers: devilhorns, zmike

Subscribers: cedric

Maniphest Tasks: T1570

Differential Revision: https://phab.enlightenment.org/D1397
2014-09-15 23:39:40 -04:00
Mike Blumenkrantz e7c0ae402f Revert "mixer: Optionally select an external mixer application."
This reverts commit 97b1caef37.

we don't use tabs, don't even start with this.
2014-09-15 19:28:08 -04:00
Brian 'morlenxus' Miculcy 97b1caef37 mixer: Optionally select an external mixer application.
This feature allows to define an external mixer application, which replaces the internal mixer.
Examples: 'terminology -e alsamixer', 'pavucontrol'
@feature
2014-09-15 19:27:17 +02:00
Igor Murzov db45e4067d Restore translated strings accidentally dropped in fac4e89 2014-09-12 14:03:26 +04:00
maxerba fac4e89dfa Updating desktop files, eo.po and fr.po 2014-09-11 21:14:58 +02:00
Carsten Haitzler c70c334792 Revert "redo pager modules to use more accurately named edje groups"
This reverts commit 9488fddc59.

no - this breaks theme api. AGAIN ... like e18. see email to e-devel.
2014-09-11 16:24:54 +09:00
Chris Michael 284e2641e6 conf_paths: Fix 'user directory' frame to resize better and adjust
size of Default & Paths lists.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-10 14:34:50 -04:00
Mike Blumenkrantz 9488fddc59 redo pager modules to use more accurately named edje groups 2014-09-10 09:02:03 -04:00
Mike Blumenkrantz ec1cd25cfe rename E19* defines/texts to just E so they don't need to keep being updated 2014-09-09 12:30:50 -04:00
vivek 3999e39962 wl_desktop_shell: Added shell_surface_destroy API for destroying all surfaces
Summary:
shell_surface_destroy function is a common destroy function to destroy all type of surfaces and to remove redundancy in code

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1421
2014-09-08 08:15:22 -04:00
Mike Blumenkrantz 0e19d32806 use e_auth hash function instead of eina hash for passwords
users should keep in mind that this is not the fort knox of password storage, and someone who copies your config file could rainbow table a short password stored with this hash very easily. at some point in the future, if someone has the interest and time, perhaps this can be improved

fix T1627
2014-09-05 15:05:58 -04:00
Chris Michael 095d34bc90 modules/notification: e_comp_object_util_zone_get Can return NULL so
we should check the return before trying to use it. Should fix Phab
T1618

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 12:20:54 -04:00
Chris Michael 7688549511 modules/conf_display: Fix CID1039753 Unused pointer value
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:16:55 -04:00
Chris Michael f43a315793 modules/conf_keybindings: Fix CID1039754 Unused pointer value
The "Don't know EINA_LIST_FOREACH macro" bandit strikes again !!

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:12:44 -04:00
Chris Michael c5023f1d4e modules/conf: Fix CID1039755 Unused pointer value
If the function returned a handle to an object, the handle may be lost.

In _e_configure_fill_cat_list: Pointer returned from a function was
never used (CWE-563)

NB: Someone should have read EINA_LIST_FOREACH on this one ;)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:10:54 -04:00
Chris Michael 36bcc26085 modules/pager_plain: Fix CID1039809 Dereference before null check
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:05:59 -04:00
Chris Michael 911bffd23e modules/ibar: Fix Dereference before null check. Also remove extra
call to ibar_resize_handle (is already called from ibar_fill).

Fixes CID1039813

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:02:16 -04:00
Chris Michael c8dd1d95d3 modules/fileman: Fix Dereference before null check
Fixes CID1039814

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:57:21 -04:00
Chris Michael 4b4b80bcb5 modules/everything: Fix dereference before null check
Fixes CID1039816

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:50:25 -04:00
Chris Michael e9599c2597 modules/everything: Fix dereference before null check
Fixes CID1039817

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:47:53 -04:00
Chris Michael ae1c3286ee modules/bluez4: Fix dereference before null check
Fixes CID1039818

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:44:07 -04:00
Stefan Schmidt 2e651c9ec1 modules/everything: Last orrurance of missing parentheses
Again, a logic problem as without the parentheses this would evauluate to
false in all cases.

CID 1212002
2014-09-05 14:40:49 +02:00
Stefan Schmidt 1180a5300b modules/everything: More parentheses fixes for correct logic
Without the correctparenthese this would always evaluate to false.

CID 1212000, CID 1212001
2014-09-05 14:38:36 +02:00
Stefan Schmidt 831a45a2cb modules/everything: Fix parentheses for CHECK_TYPE macro
Without these parentheses the logic would always be false.

CID 1211999, CID 1212003
2014-09-05 14:33:24 +02:00
Stefan Schmidt 5bfbe933fe module/connman: Remove dead code after return.
The if else above retruns in both cases. This code was never executed.

CID 1039761
2014-09-05 14:14:33 +02:00
Chris Michael 31045f715b bugfix: wl-drm: Fix hard-coded screen size of the ecore_evas
NB: This makes use of newly added ecore_evas_screen_geometry_get of
the ecore_evas_drm code in order to get the current screen size and
adjust the ecore_evas accordingly.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-04 10:05:59 -04:00
Igor Murzov 3136b5e29a Update russian translation 2014-09-03 19:04:41 +04:00
Igor Murzov aba7a8c9d5 Improve messages in bindings configuration dialogs 2014-09-03 18:04:19 +04:00
vivek 992f999301 bugfix: Check for parent surface before creating popup
xdg_shell requires a parent surface in order to create a popup, so we
should check the validity of the parent resource and error out
accordingly

Summary: Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1388
2014-09-02 08:35:50 -04:00
Mike Blumenkrantz f45b00834f Install everything.pc in $prefix/libdata/pkgconfig on FreeBSD
fix T1605
2014-09-01 12:33:31 -04:00
Mike Blumenkrantz b6dc08a3b3 fix tw warnings 2014-09-01 12:32:23 -04:00
Mike Blumenkrantz 8cff990c24 redo tw download handlers to use a valid object check
fix T1544
2014-09-01 10:30:53 -04:00
Mike Blumenkrantz d9b9497a00 systray should now update comp_x client pixmap size since it's handling window resizes 2014-09-01 10:30:53 -04:00
Mike Blumenkrantz 85bc707ab9 yet another systray overhaul to avoid destroying batter after nocomp ends
bottom line, this is a pile-of-shit protocol to work with if you're compositing. at present, any xembeds which were present before a nocomp event will be permanently destroyed, and they can't be recovered until the app re-creates them. afaik, no app does this unless you restart it.
2014-09-01 10:30:53 -04:00
Srivardhan Hebbar 0c91ba8505 teamwork: Fixed sliders issue.
Summary:
This is a fix for bug T1553: [Teamwork Settings] Sliders Should Be Disabled When Select "Disable remote media fetching"

Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>

Reviewers: zmike, devilhorns

Subscribers: cedric

Maniphest Tasks: T1553

Differential Revision: https://phab.enlightenment.org/D1375
2014-08-29 13:49:17 -04:00
Gwanglim Lee 00690dab17 added mobile policy module
Summary: mobile policy module provides user interface for small mobile devices like phones.

Test Plan: N/A

Reviewers: raster, devilhorns, zmike

Subscribers: seoz, zmike, cedric

Differential Revision: https://phab.enlightenment.org/D817
2014-08-29 13:48:01 -04:00
Mike Blumenkrantz ee5be41194 Revert "mixer: Optionally select an external mixer application."
This reverts commit e4e2550484.

apparently some people don't know what "feature freeze" means...
2014-08-29 10:38:51 -04:00
Brian 'morlenxus' Miculcy e4e2550484 mixer: Optionally select an external mixer application.
This feature allows to define an external mixer application, which replaces the internal mixer.
Examples: 'terminology -e alsamixer', 'pavucontrol'
@feature
2014-08-29 15:32:05 +02:00
Tom Hacohen 37462c7cb7 Tiling: Respect min size hints (set to floating if doesn't fit).
This fix floats all the windows that don't fit because of their min size
restrictions.
It can be made better, at the moment it is very simple. An example
broken case would be the following:
Assume we have 3 windows, A, B and C.
B and C both hand a min width of half the screen.

First we create A, then B. Everything works as they share the screen,
but when we add C, both B's and C's restrictions "fail" so they are both
set to float although in reality, floating C is enough. This can be
fixed by doing a live scan of the tree every time a window is floated,
though it's not essential at the moment.

Fixes T952.
2014-08-28 16:33:54 +01:00
Chris Michael 31e38208b4 wl-x11: Declare keyboard strings as NULL (initially) to avoid crash
when updating keymap

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:39 -04:00
Chris Michael d9cdcdbef4 Fix elm apps crashing from invalid e_remember
Don't set changes.icon during surface creation. There are functions
that get called when icccm.class changes and That is the place to set
changes.icon.

Signed-off-by: Chris Michael <cp.michael@samsung.com>

Additional authors: zmike
2014-08-26 10:10:38 -04:00
Chris Michael 8fa7e4f59d Fix inproper setting of window type during transient_set.
This fixes the issue of some wayland applications always showing up
with the e_border visible.

If we get a transient_set from wl_shell or xdg_shell, don't reset the
client's netwm.type. Some wayland applications are sending us
transient_set with parent to NULL....so don't explicitly set the
netwm.type to dialog.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Chris Michael c93ea90edf Simplify both transient_set functions (wl_shell and xdg_shell).
Remove debugging noise.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Seunghun Lee 89b2881476 clear parent's list of transients, when set parent to NULL.
Summary: we also need to clear parent's resource.

Test Plan: N/A

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1238
2014-08-26 10:10:38 -04:00
Chris Michael 814b50f7e6 wl-desktop-shell: Avoid runtime ERR noise for something that is not
really an error.

When we call shell_surface_parent_set with a NULL parent resource,
then there is No reason to try and find the pixmap window of a NULL
parent. Avoid that function call and just set the appropriate
properties and get out.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00