Commit Graph

6871 Commits

Author SHA1 Message Date
Mike Blumenkrantz 9488fddc59 redo pager modules to use more accurately named edje groups 2014-09-10 09:02:03 -04:00
Mike Blumenkrantz ec1cd25cfe rename E19* defines/texts to just E so they don't need to keep being updated 2014-09-09 12:30:50 -04:00
vivek 3999e39962 wl_desktop_shell: Added shell_surface_destroy API for destroying all surfaces
Summary:
shell_surface_destroy function is a common destroy function to destroy all type of surfaces and to remove redundancy in code

Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Reviewed By: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1421
2014-09-08 08:15:22 -04:00
Mike Blumenkrantz 0e19d32806 use e_auth hash function instead of eina hash for passwords
users should keep in mind that this is not the fort knox of password storage, and someone who copies your config file could rainbow table a short password stored with this hash very easily. at some point in the future, if someone has the interest and time, perhaps this can be improved

fix T1627
2014-09-05 15:05:58 -04:00
Chris Michael 095d34bc90 modules/notification: e_comp_object_util_zone_get Can return NULL so
we should check the return before trying to use it. Should fix Phab
T1618

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 12:20:54 -04:00
Chris Michael 7688549511 modules/conf_display: Fix CID1039753 Unused pointer value
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:16:55 -04:00
Chris Michael f43a315793 modules/conf_keybindings: Fix CID1039754 Unused pointer value
The "Don't know EINA_LIST_FOREACH macro" bandit strikes again !!

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:12:44 -04:00
Chris Michael c5023f1d4e modules/conf: Fix CID1039755 Unused pointer value
If the function returned a handle to an object, the handle may be lost.

In _e_configure_fill_cat_list: Pointer returned from a function was
never used (CWE-563)

NB: Someone should have read EINA_LIST_FOREACH on this one ;)

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:10:54 -04:00
Chris Michael 36bcc26085 modules/pager_plain: Fix CID1039809 Dereference before null check
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:05:59 -04:00
Chris Michael 911bffd23e modules/ibar: Fix Dereference before null check. Also remove extra
call to ibar_resize_handle (is already called from ibar_fill).

Fixes CID1039813

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 11:02:16 -04:00
Chris Michael c8dd1d95d3 modules/fileman: Fix Dereference before null check
Fixes CID1039814

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:57:21 -04:00
Chris Michael 4b4b80bcb5 modules/everything: Fix dereference before null check
Fixes CID1039816

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:50:25 -04:00
Chris Michael e9599c2597 modules/everything: Fix dereference before null check
Fixes CID1039817

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:47:53 -04:00
Chris Michael ae1c3286ee modules/bluez4: Fix dereference before null check
Fixes CID1039818

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-05 10:44:07 -04:00
Stefan Schmidt 2e651c9ec1 modules/everything: Last orrurance of missing parentheses
Again, a logic problem as without the parentheses this would evauluate to
false in all cases.

CID 1212002
2014-09-05 14:40:49 +02:00
Stefan Schmidt 1180a5300b modules/everything: More parentheses fixes for correct logic
Without the correctparenthese this would always evaluate to false.

CID 1212000, CID 1212001
2014-09-05 14:38:36 +02:00
Stefan Schmidt 831a45a2cb modules/everything: Fix parentheses for CHECK_TYPE macro
Without these parentheses the logic would always be false.

CID 1211999, CID 1212003
2014-09-05 14:33:24 +02:00
Stefan Schmidt 5bfbe933fe module/connman: Remove dead code after return.
The if else above retruns in both cases. This code was never executed.

CID 1039761
2014-09-05 14:14:33 +02:00
Chris Michael 31045f715b bugfix: wl-drm: Fix hard-coded screen size of the ecore_evas
NB: This makes use of newly added ecore_evas_screen_geometry_get of
the ecore_evas_drm code in order to get the current screen size and
adjust the ecore_evas accordingly.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-09-04 10:05:59 -04:00
Igor Murzov 3136b5e29a Update russian translation 2014-09-03 19:04:41 +04:00
Igor Murzov aba7a8c9d5 Improve messages in bindings configuration dialogs 2014-09-03 18:04:19 +04:00
vivek 992f999301 bugfix: Check for parent surface before creating popup
xdg_shell requires a parent surface in order to create a popup, so we
should check the validity of the parent resource and error out
accordingly

Summary: Signed-off-by: vivek <vivek.ellur@samsung.com>

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1388
2014-09-02 08:35:50 -04:00
Mike Blumenkrantz f45b00834f Install everything.pc in $prefix/libdata/pkgconfig on FreeBSD
fix T1605
2014-09-01 12:33:31 -04:00
Mike Blumenkrantz b6dc08a3b3 fix tw warnings 2014-09-01 12:32:23 -04:00
Mike Blumenkrantz 8cff990c24 redo tw download handlers to use a valid object check
fix T1544
2014-09-01 10:30:53 -04:00
Mike Blumenkrantz d9b9497a00 systray should now update comp_x client pixmap size since it's handling window resizes 2014-09-01 10:30:53 -04:00
Mike Blumenkrantz 85bc707ab9 yet another systray overhaul to avoid destroying batter after nocomp ends
bottom line, this is a pile-of-shit protocol to work with if you're compositing. at present, any xembeds which were present before a nocomp event will be permanently destroyed, and they can't be recovered until the app re-creates them. afaik, no app does this unless you restart it.
2014-09-01 10:30:53 -04:00
Srivardhan Hebbar 0c91ba8505 teamwork: Fixed sliders issue.
Summary:
This is a fix for bug T1553: [Teamwork Settings] Sliders Should Be Disabled When Select "Disable remote media fetching"

Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>

Reviewers: zmike, devilhorns

Subscribers: cedric

Maniphest Tasks: T1553

Differential Revision: https://phab.enlightenment.org/D1375
2014-08-29 13:49:17 -04:00
Gwanglim Lee 00690dab17 added mobile policy module
Summary: mobile policy module provides user interface for small mobile devices like phones.

Test Plan: N/A

Reviewers: raster, devilhorns, zmike

Subscribers: seoz, zmike, cedric

Differential Revision: https://phab.enlightenment.org/D817
2014-08-29 13:48:01 -04:00
Mike Blumenkrantz ee5be41194 Revert "mixer: Optionally select an external mixer application."
This reverts commit e4e2550484.

apparently some people don't know what "feature freeze" means...
2014-08-29 10:38:51 -04:00
Brian 'morlenxus' Miculcy e4e2550484 mixer: Optionally select an external mixer application.
This feature allows to define an external mixer application, which replaces the internal mixer.
Examples: 'terminology -e alsamixer', 'pavucontrol'
@feature
2014-08-29 15:32:05 +02:00
Tom Hacohen 37462c7cb7 Tiling: Respect min size hints (set to floating if doesn't fit).
This fix floats all the windows that don't fit because of their min size
restrictions.
It can be made better, at the moment it is very simple. An example
broken case would be the following:
Assume we have 3 windows, A, B and C.
B and C both hand a min width of half the screen.

First we create A, then B. Everything works as they share the screen,
but when we add C, both B's and C's restrictions "fail" so they are both
set to float although in reality, floating C is enough. This can be
fixed by doing a live scan of the tree every time a window is floated,
though it's not essential at the moment.

Fixes T952.
2014-08-28 16:33:54 +01:00
Chris Michael 31e38208b4 wl-x11: Declare keyboard strings as NULL (initially) to avoid crash
when updating keymap

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:39 -04:00
Chris Michael d9cdcdbef4 Fix elm apps crashing from invalid e_remember
Don't set changes.icon during surface creation. There are functions
that get called when icccm.class changes and That is the place to set
changes.icon.

Signed-off-by: Chris Michael <cp.michael@samsung.com>

Additional authors: zmike
2014-08-26 10:10:38 -04:00
Chris Michael 8fa7e4f59d Fix inproper setting of window type during transient_set.
This fixes the issue of some wayland applications always showing up
with the e_border visible.

If we get a transient_set from wl_shell or xdg_shell, don't reset the
client's netwm.type. Some wayland applications are sending us
transient_set with parent to NULL....so don't explicitly set the
netwm.type to dialog.

@fix

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Chris Michael c93ea90edf Simplify both transient_set functions (wl_shell and xdg_shell).
Remove debugging noise.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Seunghun Lee 89b2881476 clear parent's list of transients, when set parent to NULL.
Summary: we also need to clear parent's resource.

Test Plan: N/A

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1238
2014-08-26 10:10:38 -04:00
Chris Michael 814b50f7e6 wl-desktop-shell: Avoid runtime ERR noise for something that is not
really an error.

When we call shell_surface_parent_set with a NULL parent resource,
then there is No reason to try and find the pixmap window of a NULL
parent. Avoid that function call and just set the appropriate
properties and get out.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Mike Blumenkrantz 3b649534c9 Fix building Enlightenment for X11-only, Wayland-Only, and X11 with Wayland clients.
Signed-off-by: Chris Michael <cp.michael@samsung.com>

Additional authors: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Chris Michael bb64229ae9 fix return variable type from e_pixmap_window_get function
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Chris Michael 07b6052db1 wl_drm: Add short block to mark setup for drm egl rendering
When the new drm hw accel engine is ready, we can replace this little
bit of code and have hardware-accelerated drm.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:38 -04:00
Gwanglim Lee a96d7290f5 Add missing wl_resource_destroy
Summary:
There are no resource free codes in xdg shell destroy handler
and xdg popup destroy handler. e should delete wayland resource as
client requested.

Test Plan:
1. run e as wayland server
2. run weston-stacking in e
3. click with right mouse button to create xdg popup surface
4. click main surface area to delete xdg popup surface

Reviewers: devilhorns, zmike, raster

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1196
2014-08-26 10:10:38 -04:00
Seunghun Lee e5f293214d move the part of code for fetch transient_for in eval time to _e_shell_surface_parent_set().
Summary:
we need to set ec->parent before eval time.
that's because client can request to commit surface calling shell.configure() before eval time.
in this case, ec->parent isn't set yet, configure(move) will be failed.

in order to fix it, we have to set ec->parent in _e_shell_surface_parent_set() before eval time,
but we should check if ec already have parent, and if so, remove its parent's transients before change the value of ec->parent.

Test Plan: N/A

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1177
2014-08-26 10:10:38 -04:00
Gwanglim Lee 6248f11b80 remove EINA_UNUSED in move and resize callbacks
Summary: remove EINA_UNUSED from used function parameters

Test Plan: N/A

Reviewers: devilhorns

Subscribers: cedric

Differential Revision: https://phab.enlightenment.org/D1173
2014-08-26 10:10:38 -04:00
Seunghun Lee 4152e1e2dd remove setting ec->parent before evaluation.
Summary:
the value of "ec->parent" should be set in evaluation time,
therefore ec->parent->transients will be reset automatically.

Reviewers: devilhorns

CC: cedric

Differential Revision: https://phab.enlightenment.org/D1155
2014-08-26 10:10:37 -04:00
Seunghun Lee 97c39e74cc fix crash when client in wayland request to set parent to null.
Summary: Clear the E_Client's parent if client request to set parent to null.

Test Plan: run weston-stacking.

Reviewers: devilhorns

CC: cedric

Differential Revision: https://phab.enlightenment.org/D1154
2014-08-26 10:10:37 -04:00
Chris Michael 8bd30c9b98 pass the compositor ecore_evas to e_pointer_canvas_new
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:37 -04:00
Chris Michael 488ffacc39 pass the ecore_evas to e_pointer_canvas_new and use Eina_Bool for
true/false values

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:37 -04:00
Chris Michael eafb4ce000 use Eina_Bool for true/false values
Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:37 -04:00
Chris Michael 2ab2a9a36f re-enable checking of current client geometry when get a configure
message.

Signed-off-by: Chris Michael <cp.michael@samsung.com>
2014-08-26 10:10:37 -04:00