* remove BAD_CH_MAPPING nonsense (fixes volume setting bugs since whoever added it broke them in doing so)
* queue successive volume state changes to avoid overloading the server; apply queue periodically
* update mixer gadget on timer after update events so we don't get insane amounts of mixer slider updates
SVN revision: 80438
NOTE: I don't know why we do that here, look suspicious.
NOTE2: fcntl(timer_fd, F_SETFL, O_NONBLOCK | FD_CLOEXEC) will not
set the FD_CLOEXEC on linux, see the man page.
SVN revision: 80428
As I've said before, I'm attached a patch for minor bugs in the e17 again.
Please take a look at attached patch.
01. missing E_FREE(wev) if zone is null
File: src/bin/e_actions.c: 1467
Function: ACT_FN_GO_EDGE macro function
null check of zone and wev, it would be better to separate them.
02. dead code
File: src/bin/e_configure.c: 338
Function: _e_configure_efreet_desktop_update
03. array buf might be overwritten by "buf[i] = '\0'"
File: src/bin/e_eap_editor.c: 412
Function: _e_desktop_edit_user_local_desktop_filename_generate
04. missing null check
File: src/bin/e_fm.c
Function: e_fm2_icon_get: 2196
It would be better to check ic->info.file in e_fm2_icon_get
before passing to _e_fm2_file_is_edje because it doesn't check
null pointer.
05. array 'path' might be overwritten by "path[i + 1] = XXX"
File: src/bin/e_fm.c: 4299
Function: _e_fm2_uri_parse
06. missing null check
File: src/bin/e_fm_device.c: 468
Function: e_fm2_device_mount_find
If the null pointer is passed to e_fm2_device_mount_find,
then it attempt to compare string using strncmp without null
check.
e.g., e_fm2_path_set
-> real_path = _e_fm2_dev_path_map: this function could return null.
-> sd->realpath = real_path;
-> e_fm2_device_mount_find(sd->realpath)
07. missing free(fstrip)
File: src/bin/e_import_config_dialog.c: 34
Function: _import_edj_gen
08. missing _module_free(cfm)
File: src/bin/e_int_config_modules.c: 530
Function: _load_modules
09. missing free(class) in for loop
File: src/bin/e_int_menus.c: 1187
Function: _e_int_menus_clients_add_by_class
10. missing free(roots)
File: src/bin/e_main.c: 1646
Function: _e_main_screens_init
Actually only e_win_init function could return 0.
But I've added free to other codes for the consistency.
11. missing null check of 'es->cfg'
File: src/bin/e_shelf.c: 2583
Function: _e_shelf_bindings_add
'es->cfg' might be null. please look at e_shelf_position_calc.
12. no ect->category check before comparing string values
File: src/bin/e_theme.c: 387
Function: e_theme_config_remove
I'm not sure, but inner if block checks ect->category before
deleting a string.
13. missing E_FREE(wcb) in while loop
File: src/bin/e_widget_ilist.c: 146
Function: _queue_timer
14. dereferencing freed pointer 'entry'
File: src/modules/quickaccess/e_mod_quickaccess.c: 583
Function: _e_qa_event_border_remove_cb
15. missing E_FREE(trov)
File: src/modules/tiling/e_mod_tiling.c: 3106
Function: _do_transition_overlay
Thanks & Regards,
Gwanglim
SVN revision: 80231
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile
I've attached 4th patch. May the 4th be with you.
ecore patch has been merged with efl and all files are based on r80123.
Thanks & Regards,
Gwanglim
------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile
It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?
Daniel Juyung Seo (SeoZ)
On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:
Dear Raster and Daniel Juyung Seo,
I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.
[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done
7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
in available profiles. - newly added thing to the elm_win
8. merge with EO - done. :(
Any comments would be appreciated.
SVN revision: 80216
I'm attaching a patch for some minor bugs in the e17.
Please take a look at attached patch.
01. missing E_FREE(inst)
File: src/bin/e_exec.c: 347
Function: _e_exec_cb_exec
02. missing null check
File: src/bin/e_fm.c: 10173
Function: _e_fm_error_dialog
I'm not sure, but all other codes always check the return
value of e_fm2_op_registry_entry_get except here.
03. missing free(slave)
File: src/bin/e_fm_ipc.c: 804
Function: _e_fm_ipc_slave_run
04. eina_list_remove after free
File: src/bin/e_fm/e_fm_ipc.c :1325
Function: _e_fm_ipc_cb_fop_trash_idler
05. invalid check for _udisks_del, it might be _udisks_chg.
File: src/bin/e_fm/e_fm_main_udisks.c : 162
Function: _e_fm_main_udisks_test
06. uninitialized gx and gy values
File: src/bin/e_gadcon_popup.c: 172
Function: _e_gadcon_popup_position
These could be changed in e_gadcon_client_geometry_get
if gcc->o_base is null.
07. unnecessary code 'evas = e_win_evas_get(dia->win)'
File: src/bin/e_import_config_dialog.c: 456
Function: e_import_config_dialog_show
08. missing free(sizes)
src/bin/e_randr_11_serialization.c: 136
Function: _11_try_restore_configuration()
09. unnecessary variable output_info
File: src/bin/e_randr_12.c: 560
Function: _output_property_change_event_cb
10. eina_list_remove after free
File: src/bin/e_randr_12_serialization.c : 357
Function: _12_serialized_setup_update
11. no check of the return value of symlink.
File: src/bin/e_widget_fsel.c: 84
Function: _e_wid_fsel_favorites_add
12. no evr->var check before comparing string values
File: src/modules/conf_applications/e_int_config_defapps.c: 432
Function: _basic_apply
13. missing error message or check return value of edje_file_group_exists
File: src/modules/conf_theme/e_int_config_theme.c: 333
Function: _open_test_cb
Anyway, I've added e_util_dialog_show if failed. Is it okay?
14. missing index range check
File: src/modules/gadman/e_mod_config.c: 153
Function: _cb_config
It could read negative array index, because return value of
e_widget_ilist_selected_get might be negative.
BR,
Gwanglim
SVN revision: 80020
* disable all dummy wizard callbacks in pages
* shutdown callbacks in pages are now actually called
* pages are no longer shown repeatedly by xdg wait callback
* first page no longer accidentally the whole second page
* scaling initially set to 1.2 so the text is actually readable
* page states added so we have some idea where the hell the pages are at
ticket #1883
SVN revision: 79879
If time is not good enough, can be fine tunned
very easily (just change the define).
I couldn't test this commit, so if tasn
or other could, it would be great.
I believe it won't be a perfect solution
yet, since this way it will take some time
to confirm visually the network states
(association / configuration / connect)
in the popup. We need to handle this
case properly (if I'm correct).
SVN revision: 79842
when the led is shown the user can press the notification to jump to the relative window.
NOTE:Atm this is implemented only in the gadget, if no one object I will port also in the filman window.
raster: hope your eagle-eye will like ;)
SVN revision: 79792
by having a disabled button "next" doesn't tell much to the user except
a feeling of "the button not works", instead of that, when disabled the
text should be changed to something like "please wait"
Patch by Thanatermesis <thanatermesis.ecvs@gmail.com>.
SVN revision: 79662
1. use proper variable name longpressed instead of down.
2. add client message handler to construct, distruct the input window.
3. comment out 2 finger related lines.
4. send ACTION_READ message with x, y coordinate.
SVN revision: 79332
Subject: [E-devel] font, size list are not enabled even though custom
font is checked.
I'm a beginner of EFL. and this is my first bug reporting.
If I don't follow the rule of bug reporting, please correct me.
* Bug
In font settings, I checked "Enable Custom Font Classes" and set a
font and
size.
then, when I enter font settings again, font and size list are disabled.
* Cause
cfdata->cur_enabled is always 0 in _basic_create_widgets().
*Solution
set cfdata->cur_enabled as 1 in _basic_init_data_fill().
Please review attached before,after files.
If the changes are not perfect, please give me feedback.
SVN revision: 79308
autopoint/gettext stuff isn't happy at all with subdir-objects option in
configure.ac. We need this option to compile the modules or otherwise we
have a conflict in the generated objects.
big spankies to the gettext crowd.
"fix" it by only using subdir-objects in src/modules/Makefile.am, where
it's really needed.
SVN revision: 79208
Hi,
here is a patch for e/src/modules/cpufreq/e_mod_main.c
I. _cpufreq_status_check_available() always returns 1,
so moved to void.
II. Don't need to 'buf[sizeof(buf) - 1] = 0;', as it's
already done by snprintf.
III. Stuff for OpenBSD.
IV. Fixed files descriptors leaks, and removed useless
code.
thanks
SVN revision: 79203
NB: Builds again now, but does not Yet render wayland clients...soon ;)
Signed-off-by: Christopher Michael <cp.michael@samsung.com>
SVN revision: 79164
there was a callback set on the dpms timer slider which would, whenever the slider was moved and on creating the slider, set the backlight+screensaver timers to zero IN THE E CONFIG ITSELF. this means anyone who ever opened the dialog with dpms enabled had their backlight+screensaver config broken.
cannot emphasize how bad this is.
ticket #1765
SVN revision: 79163
Mike Blumenkrantz
Shinwoo Kim
Cedric BAIL
Carsten Haitzler
Boris Faure
Massimo Maiurana
Gwanglim Lee
Bruno Dilly
Vincent Torri
Sebastian Dransfeld
Davide Andreoli
Christopher Michael
Mike McCormack
Hyojin Kim
Thomas Gstädtner
Lucas De Marchi