Mike Blumenkrantz
8fd587ff92
fix navigation using symlinks in some cases
...
ticket #2032
SVN revision: 83522
2013-01-31 14:56:08 +00:00
Mike Blumenkrantz
c123546657
fix link drop into sidebar when dragging between items
...
ticket #2232
SVN revision: 83414
2013-01-29 07:44:57 +00:00
Mike Blumenkrantz
543b85aa2a
fix small leaks in efm and e_import_config_dialog
...
SVN revision: 83137
2013-01-23 09:59:14 +00:00
Mike Blumenkrantz
9e8e755cdf
formatting: all at once
...
SVN revision: 82625
2013-01-11 10:34:29 +00:00
José Roberto de Souza
5e4352e9b3
e: e_fm udisk ported to edbus
...
Patch by: José Roberto de Souza <zehortigoza@profusion.mobi>
SVN revision: 81985
2013-01-02 13:16:19 +00:00
Christopher Michael
e69f1ae991
Fix uninitialized variable warning(s).
...
Fix formatting for 80 columns.
Signed-off-by: Christopher Michael <cpmichael1@comcast.net>
SVN revision: 81743
2012-12-27 13:18:59 +00:00
Mike Blumenkrantz
99a5b074dd
show icons again when activating DND drop menu
...
ticket #2061
SVN revision: 81514
2012-12-21 08:08:56 +00:00
Carsten Haitzler
1f745881d9
series of dialogs that were not resizable but should be, are now.
...
SVN revision: 81434
2012-12-20 10:07:30 +00:00
Mike Blumenkrantz
271f92f912
ahh never too late for an API/ABI break. e_icon_file_get now returns edje group, which fixes fileman border icons
...
ticket #rasternaggedme
SVN revision: 81387
2012-12-19 17:00:10 +00:00
Mike Blumenkrantz
ae7ca9105f
Hi,
...
here is a patch.
1. free() already null-checks the passed argument, so it is not
necessary to do 'if(x) free(x)'.
2. Moved some '{free(x); x = NULL}' to E_FREE.
3. In e_start_main.c, 'buf' is allocated with the size of the
two arguments + '=', so we don't need to check for lenght;
we should use sprintf().
thanks
Maxime Villard
SVN revision: 81364
2012-12-19 14:20:34 +00:00
Mike Blumenkrantz
24ce5a79a3
initialize var for static analyzer
...
SVN revision: 81333
2012-12-19 09:27:51 +00:00
Mike Blumenkrantz
cfd42b1c6b
efm no longer allows renaming files over other files or into directories
...
ticket #2024
SVN revision: 81253
2012-12-18 14:08:39 +00:00
Mike Blumenkrantz
45a263b793
trivial formatting
...
SVN revision: 81249
2012-12-18 13:40:10 +00:00
Mike Blumenkrantz
9bfd23edab
whoops forgot to set r
...
SVN revision: 81244
2012-12-18 13:07:57 +00:00
Mike Blumenkrantz
ab1455310a
fix opening a .desktop file which is a link to a file
...
SVN revision: 81243
2012-12-18 12:28:37 +00:00
Mike Blumenkrantz
1199fc9807
okay, exposing icon object not such a great idea considering it gets deleted and recreated constantly
...
SVN revision: 81230
2012-12-18 10:12:47 +00:00
Mike Blumenkrantz
d54e0dd00b
add efm icon object to icon info so people can hook callbacks to it
...
SVN revision: 81228
2012-12-18 09:39:10 +00:00
Mike Blumenkrantz
46f630f103
efm finally does something other than flail around helplessly when you drag stuff onto the icon of another device
...
ticket #2000 , fuck DND
SVN revision: 81162
2012-12-17 15:59:43 +00:00
Mike Blumenkrantz
b22ac9e803
also automatically show files again if an op fails entirely
...
SVN revision: 81120
2012-12-17 10:59:10 +00:00
Mike Blumenkrantz
e41c2b9343
fix weird efm crash
...
SVN revision: 81070
2012-12-17 08:30:46 +00:00
Mike Blumenkrantz
8b698680df
reorder efm dnd finished cb to prevent crash when accessing possibly deleted icon
...
SVN revision: 80933
2012-12-14 11:29:50 +00:00
Mike Blumenkrantz
67b24415d6
fix efm leak when symlinking out of an ASK DND action
...
SVN revision: 80818
2012-12-13 11:07:06 +00:00
Mike Blumenkrantz
dbce2eaed3
show files again when an overwrite dialog pops up
...
ticket #1974
SVN revision: 80762
2012-12-12 13:50:43 +00:00
Mike Blumenkrantz
d0eff6a730
fix initial name string for New Directory action
...
SVN revision: 80748
2012-12-12 10:12:29 +00:00
Mike Blumenkrantz
a93a4d56f0
New Directory action in efm now renames inline like New File action
...
SVN revision: 80747
2012-12-12 10:08:04 +00:00
Carsten Haitzler
353b588347
10k files.... ok! :)
...
oh and fix a segv people will get when queue process timeout is hit...
and reduce timeout to 0.01 sec :)
SVN revision: 80746
2012-12-12 09:59:53 +00:00
Mike Blumenkrantz
ab1a9e5e80
efm no longer eats pager dnd events
...
SVN revision: 80646
2012-12-11 11:14:25 +00:00
Mike Blumenkrantz
c4115615f0
s/creat/open/
...
SVN revision: 80630
2012-12-11 08:44:05 +00:00
Mike Blumenkrantz
370ba1b3fe
okay, after considering the words of a certain frenchman we no longer write anything to new files
...
SVN revision: 80629
2012-12-11 07:50:06 +00:00
Mike Blumenkrantz
e61159e49e
write \n to new files instead of ""
...
ticket #1947
SVN revision: 80608
2012-12-10 14:16:16 +00:00
Mike Blumenkrantz
f9c87ab214
fix efm crash when using XDS drags, also fix XDS drags to work again
...
SVN revision: 80599
2012-12-10 11:41:40 +00:00
Mike Blumenkrantz
06897e960b
fix dnd source visibility when dragging into a link drop target
...
ticket #1953
SVN revision: 80586
2012-12-10 08:59:36 +00:00
Mike Blumenkrantz
2b64147c16
double clicking efm icons with single click activation enabled no longer opens directories twice
...
ticket #1933
SVN revision: 80331
2012-12-06 09:52:06 +00:00
Mike Blumenkrantz
7972371393
efm menu replace/start functions now properly pass icon info
...
SVN revision: 80327
2012-12-06 09:36:35 +00:00
Mike Blumenkrantz
4aa85b3c2c
add timer to show icons after a drag to fix XDirectSave dnd
...
ticket #1917
SVN revision: 80324
2012-12-06 09:16:15 +00:00
Mike Blumenkrantz
503d7305db
Dear all,
...
As I've said before, I'm attached a patch for minor bugs in the e17 again.
Please take a look at attached patch.
01. missing E_FREE(wev) if zone is null
File: src/bin/e_actions.c: 1467
Function: ACT_FN_GO_EDGE macro function
null check of zone and wev, it would be better to separate them.
02. dead code
File: src/bin/e_configure.c: 338
Function: _e_configure_efreet_desktop_update
03. array buf might be overwritten by "buf[i] = '\0'"
File: src/bin/e_eap_editor.c: 412
Function: _e_desktop_edit_user_local_desktop_filename_generate
04. missing null check
File: src/bin/e_fm.c
Function: e_fm2_icon_get: 2196
It would be better to check ic->info.file in e_fm2_icon_get
before passing to _e_fm2_file_is_edje because it doesn't check
null pointer.
05. array 'path' might be overwritten by "path[i + 1] = XXX"
File: src/bin/e_fm.c: 4299
Function: _e_fm2_uri_parse
06. missing null check
File: src/bin/e_fm_device.c: 468
Function: e_fm2_device_mount_find
If the null pointer is passed to e_fm2_device_mount_find,
then it attempt to compare string using strncmp without null
check.
e.g., e_fm2_path_set
-> real_path = _e_fm2_dev_path_map: this function could return null.
-> sd->realpath = real_path;
-> e_fm2_device_mount_find(sd->realpath)
07. missing free(fstrip)
File: src/bin/e_import_config_dialog.c: 34
Function: _import_edj_gen
08. missing _module_free(cfm)
File: src/bin/e_int_config_modules.c: 530
Function: _load_modules
09. missing free(class) in for loop
File: src/bin/e_int_menus.c: 1187
Function: _e_int_menus_clients_add_by_class
10. missing free(roots)
File: src/bin/e_main.c: 1646
Function: _e_main_screens_init
Actually only e_win_init function could return 0.
But I've added free to other codes for the consistency.
11. missing null check of 'es->cfg'
File: src/bin/e_shelf.c: 2583
Function: _e_shelf_bindings_add
'es->cfg' might be null. please look at e_shelf_position_calc.
12. no ect->category check before comparing string values
File: src/bin/e_theme.c: 387
Function: e_theme_config_remove
I'm not sure, but inner if block checks ect->category before
deleting a string.
13. missing E_FREE(wcb) in while loop
File: src/bin/e_widget_ilist.c: 146
Function: _queue_timer
14. dereferencing freed pointer 'entry'
File: src/modules/quickaccess/e_mod_quickaccess.c: 583
Function: _e_qa_event_border_remove_cb
15. missing E_FREE(trov)
File: src/modules/tiling/e_mod_tiling.c: 3106
Function: _do_transition_overlay
Thanks & Regards,
Gwanglim
SVN revision: 80231
2012-12-05 11:13:09 +00:00
Mike Blumenkrantz
68e6b07cd7
all dialogs are no longer resizable
...
SVN revision: 80032
2012-12-03 09:24:12 +00:00
Mike Blumenkrantz
f8efeed3e8
fix in-place directory opening in efm: statinfo resolves link targets now, so only call "selected" if link target is not a directory
...
ticket #1863
SVN revision: 80026
2012-12-03 08:57:15 +00:00
Mike Blumenkrantz
362531b082
Dear all,
...
I'm attaching a patch for some minor bugs in the e17.
Please take a look at attached patch.
01. missing E_FREE(inst)
File: src/bin/e_exec.c: 347
Function: _e_exec_cb_exec
02. missing null check
File: src/bin/e_fm.c: 10173
Function: _e_fm_error_dialog
I'm not sure, but all other codes always check the return
value of e_fm2_op_registry_entry_get except here.
03. missing free(slave)
File: src/bin/e_fm_ipc.c: 804
Function: _e_fm_ipc_slave_run
04. eina_list_remove after free
File: src/bin/e_fm/e_fm_ipc.c :1325
Function: _e_fm_ipc_cb_fop_trash_idler
05. invalid check for _udisks_del, it might be _udisks_chg.
File: src/bin/e_fm/e_fm_main_udisks.c : 162
Function: _e_fm_main_udisks_test
06. uninitialized gx and gy values
File: src/bin/e_gadcon_popup.c: 172
Function: _e_gadcon_popup_position
These could be changed in e_gadcon_client_geometry_get
if gcc->o_base is null.
07. unnecessary code 'evas = e_win_evas_get(dia->win)'
File: src/bin/e_import_config_dialog.c: 456
Function: e_import_config_dialog_show
08. missing free(sizes)
src/bin/e_randr_11_serialization.c: 136
Function: _11_try_restore_configuration()
09. unnecessary variable output_info
File: src/bin/e_randr_12.c: 560
Function: _output_property_change_event_cb
10. eina_list_remove after free
File: src/bin/e_randr_12_serialization.c : 357
Function: _12_serialized_setup_update
11. no check of the return value of symlink.
File: src/bin/e_widget_fsel.c: 84
Function: _e_wid_fsel_favorites_add
12. no evr->var check before comparing string values
File: src/modules/conf_applications/e_int_config_defapps.c: 432
Function: _basic_apply
13. missing error message or check return value of edje_file_group_exists
File: src/modules/conf_theme/e_int_config_theme.c: 333
Function: _open_test_cb
Anyway, I've added e_util_dialog_show if failed. Is it okay?
14. missing index range check
File: src/modules/gadman/e_mod_config.c: 153
Function: _cb_config
It could read negative array index, because return value of
e_widget_ilist_selected_get might be negative.
BR,
Gwanglim
SVN revision: 80020
2012-12-03 07:54:07 +00:00
Mike Blumenkrantz
1eda0a3417
some text fixes from thomasg
...
SVN revision: 79910
2012-11-30 15:39:17 +00:00
Mike Blumenkrantz
3f8c09d6a0
fix continual leak in efm file names
...
SVN revision: 79834
2012-11-29 15:02:00 +00:00
Carsten Haitzler
ef76974ffc
lets not break dnd onto dirs.. within the same efm view.
...
SVN revision: 79763
2012-11-28 04:11:33 +00:00
Carsten Haitzler
022e768010
fix segv in efm! dnd 2 files into another dir - yay!
...
SVN revision: 79762
2012-11-28 03:51:24 +00:00
Carsten Haitzler
e9a383f40c
printf--
...
SVN revision: 79489
2012-11-21 04:08:58 +00:00
Carsten Haitzler
2efe87a0e9
fix up single click and click to rename + event sticking with mouse
...
events.
SVN revision: 79488
2012-11-21 04:06:23 +00:00
Mike Blumenkrantz
3b8856aa3c
unbreak tab completion in efm typebufs
...
SVN revision: 79331
2012-11-15 09:59:51 +00:00
Mike Blumenkrantz
714185fd1a
fix possible, but confusing, dnd crash in efm
...
SVN revision: 79275
2012-11-14 09:50:00 +00:00
Mike Blumenkrantz
e5903f4740
add support for and use eina_list_last_data_get
...
SVN revision: 79144
2012-11-12 10:05:09 +00:00
Mike Blumenkrantz
2bd9c7f72c
efm now remembers sort mode per-directory
...
ticket #1696
SVN revision: 78861
2012-11-02 12:36:35 +00:00
Mike Blumenkrantz
6f24439dc4
efm Sorting menu is now a first-level submenu
...
SVN revision: 78855
2012-11-02 12:12:28 +00:00
Mike Blumenkrantz
01b47aed5f
overhaul and fix custom bg+overlay setting/unsetting in efm
...
SVN revision: 78844
2012-11-02 09:04:26 +00:00
Mike Blumenkrantz
efd116d655
dnd in efm will no longer cause icons to flicker rapidly when dropping a file
...
also added some docs about icon drag struct members
SVN revision: 78712
2012-10-31 15:56:23 +00:00
Tom Hacohen
a9bdc983b4
E entry: Move to edje_entry and remove e_editable.
...
This should reduce the number of issues in the long run and reduced the
amount of code we have to maintain."
SVN revision: 78663
2012-10-30 14:06:13 +00:00
Mike Blumenkrantz
676c71a2a1
efm now checks (on startup) for stale device links on desktop and tries to remove them
...
ticket #1689
SVN revision: 78608
2012-10-29 09:52:23 +00:00
Mike Blumenkrantz
70ed9168e2
and F2 for rename
...
SVN revision: 78536
2012-10-26 13:37:55 +00:00
Mike Blumenkrantz
eeb071c819
efm now supports F5 for refresh
...
SVN revision: 78535
2012-10-26 13:35:30 +00:00
Mike Blumenkrantz
80ff1bdcb6
efm also listens to efreet cache build events just in case
...
SVN revision: 78516
2012-10-26 10:05:17 +00:00
Mike Blumenkrantz
cbcc5eb129
efm now listens to efreet cache update events
...
ticket #1580
SVN revision: 78515
2012-10-26 10:00:44 +00:00
Mike Blumenkrantz
dffa617793
ctrl+shift drag in efm now also invokes ASK state
...
SVN revision: 78429
2012-10-25 09:19:17 +00:00
Mike Blumenkrantz
bf11ffc2e7
fix efm file position moving in same directory
...
SVN revision: 78427
2012-10-25 08:54:50 +00:00
Mike Blumenkrantz
fb4d32599d
fix dnd into favorites views
...
ticket #1638
SVN revision: 78158
2012-10-18 08:07:17 +00:00
Mike Blumenkrantz
46d2653dbc
e dnd xds handler now passes type string param as well as data
...
SVN revision: 78157
2012-10-18 08:04:03 +00:00
Mike Blumenkrantz
bc52fd4269
remove unnecessary variable, fix file pasting with blank clipboard to not hammer the efm daemon
...
SVN revision: 78153
2012-10-18 07:51:18 +00:00
Mike Blumenkrantz
a978a17ddd
efm string functions are now EAPI util functions
...
SVN revision: 77860
2012-10-11 10:19:03 +00:00
Mike Blumenkrantz
ac722b9145
expose efm move/copy/link functions
...
SVN revision: 77859
2012-10-11 10:12:16 +00:00
Mike Blumenkrantz
d4aabc7dbf
make e_fm2_drop_menu an EAPI and further clean up drop menu code
...
SVN revision: 77858
2012-10-11 09:57:55 +00:00
Mike Blumenkrantz
eaac4857d5
improve some extremely crufty efm dnd menu code
...
SVN revision: 77857
2012-10-11 09:43:54 +00:00
Mike Blumenkrantz
1e94e79e2c
remove some efm symlink cruft
...
SVN revision: 77856
2012-10-11 09:34:53 +00:00
Mike Blumenkrantz
dcc5be6e3e
_e_fm2_uri_path_list_get is now e_fm2_uri_path_list_get with EAPI
...
SVN revision: 77855
2012-10-11 08:42:19 +00:00
Mike Blumenkrantz
4e3677932a
add getter for efm drop object
...
SVN revision: 77758
2012-10-10 12:47:04 +00:00
Mike Blumenkrantz
0ec2181291
also set icon for single click menu item
...
SVN revision: 77437
2012-10-04 13:09:14 +00:00
Mike Blumenkrantz
6abb7dee36
set icon for secure delete menu item
...
SVN revision: 77436
2012-10-04 13:07:14 +00:00
Mike Blumenkrantz
62ac047ebe
add menu option to enable/disable secure deletion in efm when global setting is not enabled
...
SVN revision: 77435
2012-10-04 13:04:50 +00:00
Mike Blumenkrantz
c310836bb3
add gui option for secure deletion in efm
...
SVN revision: 77434
2012-10-04 12:58:18 +00:00
Mike Blumenkrantz
3bf711b529
block going to parent directory on desktop using backspace key when desktop navigation is not enabled
...
SVN revision: 77359
2012-10-03 09:41:10 +00:00
Mike Blumenkrantz
acdf03fecd
this fixme isn't going to happen and our typebufs don't work like this
...
SVN revision: 77358
2012-10-03 09:23:12 +00:00
Mike Blumenkrantz
4f93b748ac
add max thumbnail size setting back, improve fileman config slider unit display
...
SVN revision: 77343
2012-10-03 06:41:32 +00:00
Mike Blumenkrantz
2c950e2441
fix efm even/odd theming in directories with lots of files
...
ticket #1579
SVN revision: 77286
2012-10-02 08:31:09 +00:00
Mike Blumenkrantz
93d3c5f598
use correct format string here too
...
SVN revision: 77285
2012-10-02 08:05:47 +00:00
Mike Blumenkrantz
ec28b54c4d
greatly improve efm performance when loading large directories by reducing offscreen icon scan rate
...
SVN revision: 77284
2012-10-02 08:00:19 +00:00
Gustavo Sverzut Barbieri
0698d74a6a
efm: have a sane click-to-rename behavior.
...
Delaying rename entry by 0.75s makes absolutely no sense. As well
there is no sense in always rename if you click the label and the icon
was unselected (quite common in list views).
The proper behavior is to just rename the icon if it was selected, but
ignore the initial click used to select the icon, even if on
label. This is done by remembering the time it was selected, no need
for timer.
SVN revision: 77002
2012-09-21 21:35:17 +00:00
Vincent Torri
4a9dce6477
E17: gettext translation ++
...
patch by Maxime Villard
SVN revision: 76994
2012-09-21 19:00:28 +00:00
Carsten Haitzler
5349fd4bbb
don't know about you.. but video thumbnails do work - i'm staring at
...
them right here. a whole window full of them. they take longer to gen
than images - but they work. evas_generic_loaders load them and gen
them if u have gstreamer support etc. sure - they are slower, but they
work. only thing we don't have is a timeout for a slow generic loader.
should add that to evas.
SVN revision: 76963
2012-09-21 12:40:36 +00:00
Mike Blumenkrantz
ac3aadc71a
check mime type for disabling file thumbnails too
...
SVN revision: 76958
2012-09-21 10:40:04 +00:00
Mike Blumenkrantz
d436b086c9
refresh device links when new device is added
...
SVN revision: 76954
2012-09-21 09:55:11 +00:00
Mike Blumenkrantz
5e9c699e97
efm now attempts to unmount mounted volumes on suspend
...
SVN revision: 76952
2012-09-21 09:33:22 +00:00
Mike Blumenkrantz
016445a0ab
simplify EFM_SMART_CHECK
...
SVN revision: 76950
2012-09-21 09:20:36 +00:00
Mike Blumenkrantz
210fbb147e
update FIXME at top of efm
...
SVN revision: 76949
2012-09-21 09:19:36 +00:00
Mike Blumenkrantz
709c740a27
add configurable max file size to generate thumbnails for, also block thumbnail generation for movie files entirely since this isn't even possible
...
ticket #1545
SVN revision: 76931
2012-09-21 07:08:21 +00:00
Mike Blumenkrantz
9e9745812b
with the joint debugging efforts of devilhorns, efm tooltips now receive proper hiding events and don't hang around when switching desktops
...
SVN revision: 76853
2012-09-19 12:16:33 +00:00
Mike Blumenkrantz
bd8545dafd
test for path length accurately here
...
SVN revision: 76810
2012-09-18 11:51:27 +00:00
Mike Blumenkrantz
34c247ee40
escape textblock styles for file labels if label is a textblock
...
ticket #1527
SVN revision: 76792
2012-09-18 09:28:26 +00:00
Mike Blumenkrantz
9093ac38ab
work around stupid evas mouse event bug
...
ticket #1324
SVN revision: 76742
2012-09-17 08:45:13 +00:00
Mike Blumenkrantz
134bed522c
only generate submenu for file properties if both file and application properties are available, otherwise just show file properties
...
SVN revision: 76725
2012-09-17 04:17:35 +00:00
Mike Blumenkrantz
0f35a6bf3c
block xds drops completely when they should be blocked, also reorder drop tests to avoid unnecessary ecore_file call
...
SVN revision: 76723
2012-09-17 04:03:18 +00:00
Carsten Haitzler
45ded3832b
THIS was the dnd bug i saw! that i couldnt reproduce easily... THIS...
...
heisenbug... ptr stuff wrong. :)
SVN revision: 76708
2012-09-16 03:27:34 +00:00
Mike Blumenkrantz
29b23540ee
delete thread data after creating new file to prevent messing up the path when creating subsequent new files in other directories
...
SVN revision: 76678
2012-09-14 15:30:25 +00:00
Mike Blumenkrantz
066fbdcc0e
actually use new config and operation to perform mv operations, fix another case where dnd would trigger file rename, dragging a file around in its own directory is now a no-op as far as the daemons are concerned
...
SVN revision: 76677
2012-09-14 15:17:14 +00:00
Mike Blumenkrantz
751ef7b127
call directory mime handlers when bringing up ctx menu not on icons
...
SVN revision: 76665
2012-09-14 12:45:15 +00:00
Mike Blumenkrantz
0eafd902f7
mime handlers now properly handle icons where the full path is given
...
SVN revision: 76664
2012-09-14 11:03:26 +00:00
Mike Blumenkrantz
fbd5297cc9
okay, call icon menu extend callbacks for non-icon menus
...
SVN revision: 76660
2012-09-14 10:35:56 +00:00
Mike Blumenkrantz
0bf1e15adb
don't call icon menu end extensions in non-icon menus
...
SVN revision: 76659
2012-09-14 10:31:39 +00:00
Mike Blumenkrantz
5070b96b9e
efm options menu now contains efm config panel menu items if fileman module is loaded
...
SVN revision: 76642
2012-09-14 07:17:17 +00:00
Mike Blumenkrantz
f7e3736068
only disallow drop on link_drop targets when there's no icon selected
...
SVN revision: 76624
2012-09-13 17:01:55 +00:00
Mike Blumenkrantz
6c04fe6fea
fix link_drop targets to allow dropping into subdirs
...
this exposes a very strange and rare bug where things seem to get recursively symlinked instead of just symlinking the dragged icon
SVN revision: 76622
2012-09-13 16:34:19 +00:00
Mike Blumenkrantz
d86de48c74
always return true for dnd events
...
SVN revision: 76621
2012-09-13 16:15:18 +00:00
Mike Blumenkrantz
1726d79fa3
fix autoscrolling bug where it would scroll randomly or inconsistently
...
SVN revision: 76620
2012-09-13 16:04:28 +00:00
Mike Blumenkrantz
14157cd05b
even more not-asked-for features: dnd scrolling for efm
...
SVN revision: 76617
2012-09-13 15:21:41 +00:00
Mike Blumenkrantz
67d7e09a32
dnd of files with efm, when initiated by clicking the file's label, will no longer trigger a rename after the drag
...
SVN revision: 76613
2012-09-13 14:05:35 +00:00
Mike Blumenkrantz
cf539e40fd
efm no longer shows the drop target animation for targets that are not valid for dropping onto
...
SVN revision: 76612
2012-09-13 14:02:28 +00:00
Mike Blumenkrantz
153079e8bd
rename icon mouse in/out smart callbacks to use underscores instead of commas
...
SVN revision: 76603
2012-09-13 10:51:50 +00:00
Mike Blumenkrantz
9323db03ff
add dnd begin smart callback for efm
...
SVN revision: 76601
2012-09-13 10:40:46 +00:00
Mike Blumenkrantz
e1d3294c00
whoops, need to put the drop smart cb after teh drop
...
SVN revision: 76599
2012-09-13 10:26:45 +00:00
Mike Blumenkrantz
1cdea8bab9
block XDS drops in link_drop targets
...
SVN revision: 76593
2012-09-13 08:53:18 +00:00
Mike Blumenkrantz
1f2762db90
add efm smart callbacks for dnd events, function for getting current dnd target
...
SVN revision: 76587
2012-09-13 08:10:00 +00:00
Mike Blumenkrantz
4337d5cea5
improve efm's xds support to allow dragging onto directories to drop within, also rename the "drop" handler to selection_notify since this is actually what it's called from
...
SVN revision: 76495
2012-09-12 07:10:43 +00:00
Mike Blumenkrantz
20f84d3cee
this took waaaaayyyyyyyyyyyyyy longer than I expected, but we now have support for XDS in efm, which will allow you to drag things from many other applications TO efm windows (eg. dragging a file from an archive in file-roller to an efm window will now extract the dragged file to the location of the window)
...
SVN revision: 76465
2012-09-11 16:17:24 +00:00
Mike Blumenkrantz
6588ae2d08
fix super old, but mostly harmless bug where already-mounted volumes would not be correctly detected and set up during e startup; fixes move source option from previous commit
...
SVN revision: 76418
2012-09-10 16:28:55 +00:00
Mike Blumenkrantz
7c16c33ed5
add option to error dialog that occurs when trying to move/make a symlink onto a device: move source - moves the source of the link instead of the link
...
ticket #93
SVN revision: 76417
2012-09-10 16:28:07 +00:00
Mike Blumenkrantz
ca107c609c
ensure that efm widget does set path in the case of removable devices, fixes random crash when opening removable media
...
SVN revision: 76414
2012-09-10 15:04:31 +00:00
Mike Blumenkrantz
7335a904ce
finally implement file renaming when an overwrite is detected
...
ticket #1269
SVN revision: 76413
2012-09-10 14:40:29 +00:00
Mike Blumenkrantz
c11dd0704b
don't need to get the current container all the time, e_dialog does this for us
...
SVN revision: 76405
2012-09-10 13:22:51 +00:00
Mike Blumenkrantz
55b1cd1e09
don't need to be allocating ints here, we can just use the correct cast and things will be a-okay
...
SVN revision: 76404
2012-09-10 13:13:04 +00:00
Mike Blumenkrantz
def3fec3b3
reset efm new file marker+thread on path change
...
SVN revision: 76403
2012-09-10 12:52:41 +00:00
Mike Blumenkrantz
f260b18c27
changing efm path to its current path is now correctly handled
...
SVN revision: 76402
2012-09-10 12:51:05 +00:00
Mike Blumenkrantz
90b9efbf77
another not-awaited efm feature: creating new files from the menu
...
SVN revision: 76401
2012-09-10 12:46:02 +00:00
Mike Blumenkrantz
3243b919d4
group application and file properties in a submenu, clicking submenu item brings up file properties
...
SVN revision: 76393
2012-09-10 10:58:49 +00:00
Mike Blumenkrantz
2c44aabd4d
pasting files into directories now properly obeys link_drop
...
SVN revision: 76391
2012-09-10 10:41:25 +00:00
Mike Blumenkrantz
2d0fc4a90b
add method for disabling efm view mode items in efm widgets
...
SVN revision: 76389
2012-09-10 10:31:56 +00:00
Mike Blumenkrantz
723ad72963
prevent link drop targets (sidebar and favorites) from accidentally replacing a file within the target with a link to the same file
...
SVN revision: 76388
2012-09-10 10:23:58 +00:00
Mike Blumenkrantz
c15989c37f
rename E_FM2_MENU_NO_NEW_DIRECTORY -> E_FM2_MENU_NO_NEW, disable New menu in sidebar
...
ticket #1472
SVN revision: 76382
2012-09-10 09:03:21 +00:00
Mike Blumenkrantz
4c46169e0c
allow efm directory first/last sorting to be disabled entirely, fix refresh when setting directory sorting
...
SVN revision: 76180
2012-09-05 08:51:11 +00:00
Mike Blumenkrantz
75e8629ebf
another user suggestion: efm sorting by mtime
...
SVN revision: 76164
2012-09-05 06:41:42 +00:00
Mike Blumenkrantz
1fca248c55
another user request: sorting by size in efm
...
SVN revision: 76124
2012-09-04 10:47:39 +00:00
Mike Blumenkrantz
22de6ede9b
efm extension sorting now obeys directories first/last
...
SVN revision: 76122
2012-09-04 10:37:42 +00:00
Mike Blumenkrantz
93cc88b8b1
add efm option to sort files by extension
...
ticket #1436
SVN revision: 76014
2012-09-03 14:21:10 +00:00
Mike Blumenkrantz
c67b4ffad8
add sorting submenu to efm view menu to allow sorting to be changed on the fly
...
SVN revision: 76002
2012-09-03 12:02:00 +00:00
Mike Blumenkrantz
cdf5da175d
group default view mode with other view mode menu items
...
SVN revision: 75999
2012-09-03 10:59:48 +00:00
Mike Blumenkrantz
5625117baa
clarify "Use default" view mode menu item
...
SVN revision: 75998
2012-09-03 10:48:49 +00:00
Mike Blumenkrantz
1cabcb39f9
finally fix menu item alignment for efm ctxmenu items
...
this is a really stupid bug, but apparently using submenu callbacks in some situations (not all the time, that would be too easy) cause items to be misaligned
SVN revision: 75996
2012-09-03 10:36:22 +00:00
Mike Blumenkrantz
68ecf550e3
annotate unused variables properly
...
SVN revision: 75985
2012-09-03 09:17:31 +00:00
Mike Blumenkrantz
2d0c34fc28
another change I've been wanting to make for a long time: e_entry_dialog now has the data param first
...
SVN revision: 75983
2012-09-03 09:06:10 +00:00
Mike Blumenkrantz
1798ace14d
break out file ctx actions into new submenu so the file menu doesn't get huge if there are multiple handlers for a mime/glob type
...
SVN revision: 75773
2012-08-28 10:17:00 +00:00
Mike Blumenkrantz
ccad002a7b
put this back so the list doesn't leak
...
SVN revision: 75768
2012-08-28 09:04:29 +00:00
Mike Blumenkrantz
916fd8e183
fix e_fm2_mime_handler_mime_handlers_get() to return const like it should and fix usages to prevent freeing handlers. whoever wrote this initially should come over here so I can deliver spankies.
...
SVN revision: 75767
2012-08-28 08:54:54 +00:00
Mike Blumenkrantz
45803968c5
free ctx action list as we add so we don't have to loop twice
...
SVN revision: 75766
2012-08-28 08:36:50 +00:00
Mike Blumenkrantz
adc7b0bd98
not sure why this was inline
...
SVN revision: 75765
2012-08-28 08:33:58 +00:00
Mike Blumenkrantz
098e8723e0
fix efm mime actions to properly add a separator if there is an action which fails a test before an action that does not fail a test
...
SVN revision: 75764
2012-08-28 08:30:16 +00:00
Mike Blumenkrantz
c94ce38fa4
fix leak when adding ctx menu items to efm
...
SVN revision: 75763
2012-08-28 08:23:11 +00:00
Mike Blumenkrantz
540e94652e
more dialog delete cleanups
...
SVN revision: 75755
2012-08-28 06:49:14 +00:00
Carsten Haitzler
cf863adc59
fix sorting to sort symlinks to dirs as if they are dirs...
...
SVN revision: 75695
2012-08-25 09:12:31 +00:00
Mike Blumenkrantz
98dca3d7b8
never activate clicked item if doing range/multi select
...
ticket #1365
SVN revision: 75486
2012-08-21 06:40:25 +00:00
Carsten Haitzler
9cc281f002
make filepreview for links and removable devices and mountpoints give
...
fs type, filesystem usage, size etc. etc. much more useful.
SVN revision: 75429
2012-08-19 13:28:51 +00:00
Mike Blumenkrantz
ac28718562
add function for counting number of selected files
...
SVN revision: 75016
2012-08-08 12:29:16 +00:00
Mike Blumenkrantz
d2b8ccd61a
add efm option to disable click renaming
...
SVN revision: 75012
2012-08-08 11:55:10 +00:00
Mike Blumenkrantz
cd9c7ee8dc
ensure that title clicking an icon to rename only causes the rename if no other icons are clicked/selected
...
SVN revision: 74995
2012-08-08 06:59:06 +00:00
Mike Blumenkrantz
3b748e94c5
prevent all renaming when the icon menu flag is set to disable it
...
SVN revision: 74967
2012-08-07 08:56:03 +00:00
Mike Blumenkrantz
ce76c249b8
efm now allows renaming by clicking an icon's label
...
SVN revision: 74963
2012-08-07 08:18:59 +00:00
Mike Blumenkrantz
6790e78bb7
fix possible crashes when going to parent directory, also fix case where attempting to go to parent directory from root would throw an error dialog
...
SVN revision: 74961
2012-08-07 06:59:37 +00:00
Mike Blumenkrantz
c2b7cdb16c
ensure that application properties is not shown for any file beginning with |
...
SVN revision: 74944
2012-08-06 14:11:39 +00:00
Mike Blumenkrantz
f8430f2af9
don't show Application Properties menu item for removable media links
...
SVN revision: 74943
2012-08-06 14:09:53 +00:00
Mike Blumenkrantz
05b70797b9
rearrange separators in icon right click menu
...
SVN revision: 74942
2012-08-06 14:05:31 +00:00
Mike Blumenkrantz
388e9e2786
move 'new directory' to a submenu which will eventually be populated by related items
...
SVN revision: 74940
2012-08-06 13:58:20 +00:00
Mike Blumenkrantz
4af7a2e439
inherit parent settings -> submenu
...
SVN revision: 74939
2012-08-06 13:50:07 +00:00
Mike Blumenkrantz
7af4aee424
efm menus are gettin a little big, time to start condensing.
...
menu toggles -> Options submenu
SVN revision: 74937
2012-08-06 13:38:15 +00:00
Mike Blumenkrantz
b54be9093a
another efm crash--
...
SVN revision: 74917
2012-08-06 09:34:27 +00:00
Mike Blumenkrantz
160c91873b
ensure directory still exists when setting parent on unmount
...
SVN revision: 74915
2012-08-06 09:12:45 +00:00
Mike Blumenkrantz
0b1cb03a25
prevent crash when realpath is null from setting a mount
...
SVN revision: 74912
2012-08-06 08:55:28 +00:00
Mike Blumenkrantz
e878d1840f
revert temp efm path resolution fix from the weekend, also fix mounting in a number of cases
...
SVN revision: 74905
2012-08-06 07:45:51 +00:00
Mike Blumenkrantz
ab46fd58c1
also print out dev/path for debugging in previous commit
...
SVN revision: 74876
2012-08-04 08:47:52 +00:00
Mike Blumenkrantz
735b02c419
pop error dialog when efm fails to resolve a path instead of crashing
...
SVN revision: 74875
2012-08-04 08:46:57 +00:00
Mike Blumenkrantz
a2a0c31062
prefer actual image previews over mime icons
...
SVN revision: 74862
2012-08-03 18:10:23 +00:00
Mike Blumenkrantz
5c7662a0ed
fix efm icon loading for cases where the theme does not define mime icons
...
SVN revision: 74861
2012-08-03 18:05:25 +00:00
Mike Blumenkrantz
4767c70921
ensure typebuf timer gets deleted to prevent crashes
...
SVN revision: 74843
2012-08-03 11:12:23 +00:00
Mike Blumenkrantz
dcc999599e
efm config now has the no_typebuf_set option to disable typebuf directory changing
...
SVN revision: 74842
2012-08-03 11:00:58 +00:00
Mike Blumenkrantz
418ff1255b
clear efm typebuf when something gets clicked, add external function for manually clearing typebuf
...
SVN revision: 74837
2012-08-03 10:32:12 +00:00
Mike Blumenkrantz
ade7d802eb
only change efm selection when using typebuf if the selection actually needs to be changed; fixes flickering and constant selection callbacks
...
SVN revision: 74836
2012-08-03 10:14:37 +00:00
Mike Blumenkrantz
1044ea8316
warn--
...
SVN revision: 74810
2012-08-02 16:25:53 +00:00
Mike Blumenkrantz
542d302108
e_fm2_parent_go() and e_fm2_has_parent_get() now behave as expected
...
ticket #1243
SVN revision: 74805
2012-08-02 12:25:58 +00:00
Mike Blumenkrantz
a162da52bb
fix efm list scrolling
...
ticket #1120
SVN revision: 74802
2012-08-02 11:58:33 +00:00
Mike Blumenkrantz
5c8525d1c9
efm now properly obeys link_drop in all cases, not just list view
...
SVN revision: 74799
2012-08-02 10:27:36 +00:00
Mike Blumenkrantz
fe1033edb4
not sure what I was thinking here, too early in the morning I guess. redundancy--
...
SVN revision: 74797
2012-08-02 10:20:30 +00:00
Mike Blumenkrantz
c47ea3ce2c
autocreate favorites in thread on startup and any time they're deleted
...
SVN revision: 74794
2012-08-02 08:18:33 +00:00
Mike Blumenkrantz
2593a1c020
ensure favorites directory is always created
...
SVN revision: 74791
2012-08-02 08:03:13 +00:00
Mike Blumenkrantz
90e15a8678
move favorites setup code to efm
...
SVN revision: 74788
2012-08-02 07:55:41 +00:00
Mike Blumenkrantz
b8cdf23f62
only create desktop paths when actually desktop directories
...
SVN revision: 74735
2012-08-01 12:29:18 +00:00
Mike Blumenkrantz
06b18f44c8
fix path resolution for desktop device which was broken while fixing path resolution for desktop device which was broken while fixing path resolution for desktop device
...
SVN revision: 74734
2012-08-01 12:28:14 +00:00
Mike Blumenkrantz
05fd34c8bd
fix efm dnd when filemanager widget is not positioned at 0,0, an icon's statinfo is now based on its source in case of link and desktop files, allow dnd onto link/desktop files as though they were the actual directory
...
SVN revision: 74729
2012-08-01 11:51:49 +00:00
Mike Blumenkrantz
2dd460106c
remove old/deprecated non-async file listing
...
SVN revision: 74724
2012-08-01 09:05:35 +00:00
Carsten Haitzler
12d1de00e1
clean up whole bunch of potential memory errors in e_fm.c
...
SVN revision: 74723
2012-08-01 09:00:22 +00:00
Mike Blumenkrantz
1280fd2364
fix efm dnd with list view
...
SVN revision: 74720
2012-08-01 08:49:04 +00:00
Mike Blumenkrantz
837e220d75
also optimize _e_fm2_icon_first_selected_find
...
SVN revision: 74718
2012-08-01 08:03:37 +00:00
Mike Blumenkrantz
10580953e4
optimize _e_fm2_icon_desel_any()
...
SVN revision: 74717
2012-08-01 08:01:38 +00:00
Mike Blumenkrantz
810b9282f5
add function for deselecting all selected icons in fm object
...
SVN revision: 74716
2012-08-01 08:00:21 +00:00
Mike Blumenkrantz
506b9ad8e6
whoops forgot this was a list of icons, not icon infos. unbreak!
...
SVN revision: 74654
2012-07-31 13:18:24 +00:00
Mike Blumenkrantz
89cdac7771
simplify e_fm2_selected_list_get
...
SVN revision: 74653
2012-07-31 13:09:05 +00:00
Mike Blumenkrantz
5488f9f047
when deleting an icon, we want to remove it from the selected list -- not add it
...
SVN revision: 74652
2012-07-31 13:07:54 +00:00
Carsten Haitzler
bc3741963e
and fix my desktop folder fix.. to not make Desktop- :)
...
SVN revision: 74645
2012-07-31 11:07:33 +00:00
Carsten Haitzler
c98fe5be14
please don't break Desktop-1/2 ec. for multi-screen. thanks. :)
...
SVN revision: 74634
2012-07-31 09:50:27 +00:00
Mike Blumenkrantz
52a5c2c729
passing a path along with "desktop" device to efm should allow you to navigate relative to your desktop directory. now it does
...
SVN revision: 74591
2012-07-30 14:25:36 +00:00