Commit Graph

21131 Commits

Author SHA1 Message Date
Shuhrat Dehkanov be742c4adc xkbswitch: establish parent/child relationship
Summary:
There is an edge case that results in SIGFAULT in Enlightenment when
"Keyboard Settings" dialog is closed prior to "Add New Configuration"
dialog and "OK" button is pressed in the latter one.
This makes sure that closing the dialogs follows the parent/child logic.

@fix

Test Plan:
1. Go to Settings -> All -> Input -> Keyboard and press "Add"
2. Observe that "Add New Configuration" dialog is opened
3. Select/highlight any new layout
4. Go back to "Keyboard Settings" dialog and close it
5. Press "OK" in "Keyboard Settings" dialog
6. Observe that Enlightenment sigfaults

Reviewers: zmike, raster

Subscribers: cedric, seoz

Differential Revision: https://phab.enlightenment.org/D3901
2016-04-26 10:56:58 -04:00
Mike Blumenkrantz 0c0377c686 allow mixer volume increase actions to exceed 100%
ref 0bbb20a3be

cc @raster probably should have some kind of theme indicator in the theme
for "high" volumes > 100%
2016-04-26 10:56:58 -04:00
Mike Blumenkrantz 6c6ba942da redo e_place_desk_region_smart() to handle multiple screens
this code is unbelievably bad.

fix T3404
2016-04-26 10:56:58 -04:00
Mike Blumenkrantz 8c8432598c unify a large portion of repeated code in e_place
this is still a nonsensical nightmare, but at least now it's all in
one place
2016-04-26 10:56:58 -04:00
Carsten Haitzler 2dfc64e220 e intel - fix number 2
so the crazieness in e+intl was because of eina_str_tolower()
silliness... so work with it and another patch to follow on from
01e53356f8 ...

@fix
2016-04-26 10:56:58 -04:00
Carsten Haitzler d70a1b71ba e intl - fix string buffer length size
this intl code was broken using sizeof a pointer (sizef char *) vs
size of the actual buffer used.

@fix
2016-04-26 10:56:58 -04:00
Mike Blumenkrantz 334cf0062f ignore maximized+fullscreen windows when placing new clients
this should improve perf and placement

ref T3404
2016-04-26 10:56:58 -04:00
Mike Blumenkrantz 203a118eb4 change client un/maximize_pre callback location to occur after safety checks 2016-04-26 09:59:17 -04:00
Mike Blumenkrantz b4f664b7bc make e_client_has_xwindow() more wayland-only friendly 2016-04-26 09:59:17 -04:00
Mike Blumenkrantz f2486ed7fc directly include e.h in efm device backends
fixes some compile errors related to include ordering

ref 68587276cf
2016-04-26 09:59:17 -04:00
Mike Blumenkrantz 6f1c09689d don't send duplicate configure to wayland clients during unfullscreen
this causes unnecessary client-side resizing
2016-04-26 09:59:16 -04:00
Derek Foreman adaea026a8 Remove unwanted debug detritus from last commit
#Oops

Reviewed-by: Mike Blumenkrantz <zmike@osg.samsung.com>
2016-04-26 09:59:16 -04:00
Derek Foreman 7060ce6567 Clean up some header inclusion
Including certain headers in the wrong order can cause problems if
we're configured to use beta api (right now wayland forces this).

In most cases we should just be including e.h and not the individual
EFL headers anyway.  This fixes some of that.

fix T3426, T3428
2016-04-26 09:59:16 -04:00
Mike Blumenkrantz 8f1dfe0d79 do not unconditionally update position+size when changing wl client csd geometry
this breaks...everything
2016-04-26 09:59:16 -04:00
Mike Blumenkrantz eef14b3619 do not send shell configures for deleted wl clients 2016-04-26 09:56:39 -04:00
Mike Blumenkrantz 5ed82b8e38 set WAYLAND_DEBUG=0 during wl compositor init
ensures that debug logs won't get both compositor and client output,
making the log impossible to read
2016-04-26 09:56:35 -04:00
Mike Blumenkrantz 12d1d70ca4 reject client maximize attempts using identical maximize params 2016-04-26 09:56:31 -04:00
Mike Blumenkrantz 3ad934b7c2 disable xwayland module if exe cannot be found during configure
should probably make this a --flag at some point

fix T3415
2016-04-26 09:56:22 -04:00
Mike Blumenkrantz a2d6a3e0ed don't print xwayland path twice... 2016-04-26 09:56:05 -04:00
Mike Blumenkrantz da2f778897 print xwayland exe path in debug logs
ref T3415
2016-04-26 09:56:02 -04:00
Mike Blumenkrantz f65a5bb3bb wl popup surfaces should not receive focus on show if parent is not focused
fix T3339 harder
2016-04-26 09:55:37 -04:00
Mike Blumenkrantz 350dcf13f0 remove video child references from wl compositor
this is an x11-only thing
2016-04-26 09:55:25 -04:00
Mike Blumenkrantz 4471c63aa4 add back CTRL to keybindings editor display
ref fcac68958e

fix T3412
2016-04-26 09:55:20 -04:00
maxerba dcab7b5a28 Updating italian translation 2016-04-26 09:55:11 -04:00
Mike Blumenkrantz add8af06a9 delete internal wayland elm windows in wl client delete request callback
fix T2874
2016-04-26 09:55:06 -04:00
Mike Blumenkrantz 025c130a45 restrict shelf border_fix to only affect clients affected by the shelf
fixes random other clients changing sizes based on irrelevant shelf hiding
2016-04-26 09:55:02 -04:00
Mike Blumenkrantz 635e056e08 do not incrementally remaximize clients during shelf hide animation
this looks really bad and forces unnecessary spinning
2016-04-26 09:52:16 -04:00
Derek Foreman 8a40d9c6ef wayland: Fix xdg-popup crash
We need to remove the destroy listener when we delete a pixmap or it
leaves an invalid node on the signal list.
2016-04-26 09:51:33 -04:00
Mike Blumenkrantz 9f9dbb3b5e reapply client focus after input grab, only handle focus for wayland compositors
this was looking too weird

ref 4a73e9f29a
2016-04-26 09:51:23 -04:00
Derek Foreman 4b643d8c96 xwayland: Don't leak memory on dnd read failure 2016-04-26 09:51:13 -04:00
Mike Blumenkrantz 0bc84ac6b0 remove clamping for wl xdg popup configures
I don't remember why I added it but it's wrong and so was I
2016-04-26 09:51:07 -04:00
Derek Foreman b2715d2586 wayland: Stop E from consuming all CPU as soon as a selection is made
Clipboard fds from clients are regular files, which shouldn't be passed
to fd_handler_add.  Using the wrong add function causes epoll to return
immediately and we end up running idle handlers and burning cpu.

Reviewed-by: Mike Blumenkrantz <zmike@osg.samsung.com>
2016-04-26 09:51:03 -04:00
Derek Foreman 3eecf5904c wayland: Don't leak a clipboard source if adding fd handler fails
Reviewed-by: Mike Blumenkrantz <zmike@osg.samsung.com>
2016-04-26 09:50:59 -04:00
Mike Blumenkrantz 15806cbbf9 don't set wl xdg popups to POPUP layer, set popups as placed on creation
resolves random popup placements
2016-04-26 09:50:53 -04:00
Mike Blumenkrantz bf6ba1b003 enforce wl xdg popup stacking relative to parent stacking 2016-04-26 09:50:46 -04:00
Mike Blumenkrantz 0656da9d2f set destructor for xdg popups when setting implementation
popups never get deleted without this
2016-04-26 09:50:42 -04:00
Mike Blumenkrantz 656a1982bd do not reset previously-set ec->placed state when attempting early client moves 2016-04-26 09:50:38 -04:00
Mike Blumenkrantz 17e32f5786 apply compositor keybinds if an action client that is not focus exists 2016-04-26 09:50:32 -04:00
Mike Blumenkrantz 783c35622d only attempt to rescue offscreen clients if they are completely offscreen 2016-04-26 09:50:26 -04:00
Mike Blumenkrantz 7a2d7cacb6 allow some client zone/desk move actions to occur on action client 2016-04-26 09:50:12 -04:00
Mike Blumenkrantz aa686641b1 remove wl xdg popup new_client stuff from get_popup method
ref d7f7eb9448
2016-04-26 09:50:08 -04:00
Mike Blumenkrantz ae6d22ac40 optimize case where an x11 client is focused/unfocused in same loop iteration 2016-04-26 09:49:51 -04:00
Mike Blumenkrantz 76b76af8ea explicitly manage client focus when setting/unsetting input grabs
clients cannot retain focus during a compositor grab, so ensure that
they do not think they have focus in such cases

fix T3338
2016-04-26 09:49:46 -04:00
Mike Blumenkrantz 7b201be6b3 block wl keyboard modifier updating during input grabs 2016-04-26 09:49:41 -04:00
Mike Blumenkrantz 165f470d7c force keyboard modifier update on wl client focus-in
ensure that clients always receive up-to-date modifiers when they get focus
2016-04-26 09:49:38 -04:00
Mike Blumenkrantz 83faf58fdb don't show some x11-specific compositor settings under wayland 2016-04-26 09:49:33 -04:00
Mike Blumenkrantz 2fdc1096c5 remove old compositor reset code 2016-04-26 09:49:28 -04:00
Mike Blumenkrantz fbb24d9e13 reshuffle notifications on replace 2016-04-26 09:49:24 -04:00
Mike Blumenkrantz 32839ee8f2 track offline/presentation mode notification ids and replace on toggle 2016-04-26 09:49:19 -04:00
Mike Blumenkrantz 3980f4bac3 move notification text escaping into dbus notify method callback
this ensures that notification text reaching the module can be considered
"usable" without forcing multiple escape passes onto the same notification

fix T2757
2016-04-26 09:49:15 -04:00