learning how meson works. may not be the cleanest or nicest... but
it's not too bad. it does work. ninja dist works.
build times improved. for a full autogen.sh, make etc. -> 5.205s to 0.759s
so resize rage up and down and well... kind of undesireable things
happen to browser items in windowed mode. you want more of a swatch of
things to select from that don't get sily big (or way to horizontally
or vertically squashed) - similarly for fullscreen mode but be a
little different and don't enforce a max size then... it just works
better now... resizing around... try and enjoy. now back to work...
Summary:
Generally these images are better quality than those
from the Interwebz and local so let's use em!
For now using emotion_object_meta_preview_get()
as Apple stores them in this tag.
emotion_object_meta_image_get() is also available
and I've heard also it is used similarly, but
am yet to find a file that does that.
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D4555
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
so if you slide up and down the seek bar without an existing thumb
file (al my videos had thumb fils because i've been using the browser
which generates the thumb files for me mostly), then rage may spawn
several thumbnailersfor the same file. this is not a good thing. so
avoid it and only have 1 thumbnailer per file
so if someone is sily and sets their videos dir to be $HOME ... don't
use it as frankly that makes the video browser useless. it is not
meant for such a mess of dirs. it's meant for a special subdirectory
system which is primarly just media files and nothing else ... not $HOME
so now sizing and count and spacing of items change, header
sizes/style change and more when switching to/from fullscreen mode.
fullscreen == "i want to be a media cener now on a big screen tv" vs
"i'm a video collection browser in a window on your desktop". far
nicer now. i think this is getting close to another release. maybe
after 1.18
it seems either the ecore timer changes or eodel/unref changes have
caused something bad. timers even tho deleted by ecore_timer_del still
go ticking. this seems to happen in range with the thumb objects. the
smart del deletes the timer - explicitly then LATER the callback is
called still. bad bad bad. for now - don't segv... but eo complaints
about invalid obj id's are due to eo/efl changes.
-> cedric
-> tasn
:S
This reverts commit 25ffdc470c.
go back to good 'old subdir build. it's just too much of a pain having
to always build from a toplevel dir. see all the issues with efl doing
this.
if you have
file.mp4
then this will use
file.mp4.png
file.mp4.jpg
file.mp3.jpeg
in that order (first found wins) in the same dir instead of googling
for an image. it will also try after the abover, in order:
file.png
file.jpg
file.jpeg
.file.mp4.png
.file.mp4.jpg
.file.mp4.jpeg
.file.png
.file.jpg
.file.jpeg
.thumb/file.mp4.png
.thumb/file.mp4.jpg
.thumb/file.mp3.jpeg
.thumb/file.png
.thumb/file.jpg
.thumb/file.jpeg
first one found wins. if none of these exist, then google shall be
consulted. :)
make video hide on stop so when browser i sback there isnt a dead
video in the background
make poster mode explicit so timeline thumbs work again
add spacing between browser item and make label multi-line
...
1. guess if it's a move by aspectr ratio and lenght.
2. if it meets this - search for a file poster online instead of
generating thumbnails.
3. make thumbs now taller than wide to accomodate poster sizes
looks nicer now.
Summary: Dropping a directory into Rage added everything before this patch, complaining about some files and definitely not playing them. This adds `emotion_object_extension_may_play_get()` checks.
Test Plan:
Drop a non-playable file and a directory containing non-playable files.
The file(s) get(s) added (but cannot be played, obviously) before this patch and after this they're ignored.
Reviewers: raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D3162
this adds a video browser that indexes everything in ~/Videos
flattening subdirs into categories. It also will handle music and
fetch album art. browser can be mouse or key controlled. makes rage
almost media-centerey. not intended as a replacement tho, but just
that it's handy to throw in.
Summary:
Emotion lib ref count is incremented by video_add and by emotion_object_add.
This ref count should be also decremented when the object returned by video_add is
destroyed.
An other way to fix this leak is to remove emotion_init from video_add since
it's already initialised by emotion_object_add.
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D3060
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
A crash happens when a movie finishes and the program terminates.
An access to the "inf" data is done, although this data has been freed
during the win deletion.
It crashes only if the mouse is not over the progress bar.
@fix
rage was trying to fetch albumart for videos mistakenly. i thought
this may have been an emotion mess-up. no. rage mess-up. fix by
delaying until emotion back-end has figured out the new stream. this
does point out that curl is managing to block the mainloop and perhaps
we should stuff it off into a slave thread in ecore_con. :(
If the file is a real url (with urlencoded chars) then use
efreet_uri_decode to decode the uri and use the decoded
string in place of the raw file in window title and playlist items
Summary:
It's somewhat annoying to keep restarting rage in order to manipulate the playlist. Having a keybind for clearing it
goes a long way for usability.
Test Plan: Add files. Hit c. Add more files. Skip around in the playlist. Clear. Add.
Reviewers: etrunko, raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D1484
* fix mem leak of vid content
Summary:
So you have unorganized files, or pseudo-organized files, and you dump them into rage. A song or video comes up that you don't want to bother with, so you want to hit delete to not play it.
This will be more useful later with a "loop all" feature, but I implemented it now because I often bump into this situation.
Reviewers: etrunko, raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D1486
* also fix mem leak in not freeing vid struct content
Summary:
When doing other patches, I was constantly distracted by this printf and I couldn't see a purpose for having it in there.
You may reject this patch if you want, but I think it warrants some thought :)
Reviewers: etrunko, raster
Projects: #rage
Differential Revision: https://phab.enlightenment.org/D1483
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
They were being called on the wrong object (the video smart instead of the emotion object),
now all the functions get called on the emotion object as they should.