Commit Graph

1030 Commits

Author SHA1 Message Date
godfath3r ca8f4ce2d3 Add splits as startup arguments
Summary:
You can have use one of the following options:

______
|  |  |   -s or --split v
|__|__|

______
|_____|   -s or --split h
|_____|

______
|  |__|   -s or --split v-h
|__|__|

______
|__|  |   -s or --split vh
|__|__|

______
|__ __|   -s or --split h-v
|__|__|

______
|__|__|   -s or --split hv
|_____|

______
|__|__|   -s or --split vh--h
|__|__|

Reviewers: billiob

Differential Revision: https://phab.enlightenment.org/D1244
2014-08-09 12:22:19 +02:00
Boris Faure 4f3ee44e6b fix compatibility with efl 1.7 2014-08-09 11:33:22 +02:00
Boris Faure 8be1c44d61 fix focus issue with multiple tabs 2014-08-06 23:09:23 +02:00
Boris Faure 43fc3eff04 blend in app_server_eet.{c,h} 2014-08-06 22:22:03 +02:00
Boris Faure 9e685ffbd2 cleanup timers in termio.c 2014-08-04 21:43:45 +02:00
Boris Faure 7de97c0007 don't waste cpu mouseover when the mouse is not moving. Closes T1457
_termio_link_find() is the real culprit here but it's not yet its time to
get rewritten.
2014-08-03 21:05:03 +02:00
Boris Faure 2f58445033 fix focus issue due to "mouse_over_focus" conflict. Closes T1380 2014-08-03 17:26:04 +02:00
Wonguk Jeong 9a4b244c64 options: stringshare, list clear bug fix
1. _backgroundlist was not clear after free
2. _system_path was not clear after stringshare_del
3. various style prob.

@fix
2014-07-31 20:52:56 +02:00
Wonguk Jeong 15260bcddf options: do not update wallpaper if selected one is same to current one
in case of video wallpaper
if we just get into setting -> wallpaper, video was restarted.

@fix
2014-07-31 20:16:29 +02:00
Iván Briano 0a8e42276c Don't undef gettext, it breaks the build when it's disabled
Somewhere along the line, libintl.h is included whether or not
--disable-nls was passed to configure, and undefining gettext makes the
macros in that header make no sense.
2014-07-30 11:00:35 -03:00
Wonguk Jeong 14a7fb779f mute audio to all terms
Audio mute is currently global setting (it will be synced, if user changed option).
Therfore, apply mute to all terms not only to focused term.
2014-07-29 05:30:03 +02:00
Wonguk Jeong 7efef95b14 termio: audio mute for activate media block support
activate media block was not affected by audio muted setting.

testplan:
1. tycat media file
2. option->video->Audio muted
3. check whether the media block is muted/unmuted properly
2014-07-29 04:00:51 +02:00
Wonguk Jeong ace0b53a34 termio: remove duplicated function prototype 2014-07-29 03:50:09 +02:00
Boris Faure 42acb4b5d1 fix segfault
due to invalid eina_stringshare_del() after pool is freed by
elm_shutdown()
2014-07-27 20:00:52 +02:00
Boris Faure ca9b866f4a improve option names 2014-07-27 15:24:54 +02:00
Boris Faure 651364b191 don't translate VLC and fix Gstreamer 1.X option's name 2014-07-26 20:12:52 +02:00
Jean Guyomarc'h 353f3e27ba Fix autotools+ignores (auto-generated files). Fix linking error with --disable-nls.
Reviewers: billiob

Differential Revision: https://phab.enlightenment.org/D1239
2014-07-26 19:55:24 +02:00
Boris Faure 9a66d33438 should have removed that comment 2014-07-26 17:09:20 +02:00
Boris Faure 38c5f1d4ec clip media controls. Cf T1369 2014-07-26 16:51:14 +02:00
Boris Faure 601450db01 review translation strings. Closes T1433 2014-07-26 11:37:27 +02:00
Boris Faure 8a3c15e08e gettextify termcmd.c,termio.c,termpty.c,termptyesc.c 2014-07-26 11:37:26 +02:00
Boris Faure 793f42daa5 gettextify options 2014-07-26 11:37:26 +02:00
Boris Faure 06bdb882db gettextify m*.c 2014-07-26 11:37:26 +02:00
Boris Faure b98f6107c3 gettextify in about.c,app_server.c,controls.c 2014-07-26 11:37:26 +02:00
Boris Faure 0ebe84383b Add (early) gettext support 2014-07-26 11:37:26 +02:00
Wonguk Jeong b14042aa49 media: improve media control pos/vol slider
Summary:
currently, pos/vol could be changed by using only knob not slider area.
use slider area as event source, and control knob internally.

Fixes T1440

Test Plan: terminology -> tycat video file -> try to control pos/vol by clicking slider area

Reviewers: billiob

Subscribers: seoz

Maniphest Tasks: T1440

Differential Revision: https://phab.enlightenment.org/D1219
2014-07-23 07:07:01 +09:00
Iván Briano f08f457697 Don't show the miniview by default
This object will be swallowed into the theme and that's how its
visibility should be controlled. But in the case that the user's theme
doesn't have the right part, we are left with a dangling object floating
in a corner and visible when it shouldn't be.
2014-07-22 11:18:05 -03:00
godfath3r 620802fb69 Remove some unnesecarry from _smart_show
Reviewers: billiob

Differential Revision: https://phab.enlightenment.org/D1212
2014-07-21 22:18:59 +02:00
godfath3r 54280b97f6 cleanup. Remove lines with values stored to variables never used
Summary:
  as found with clang static analysis tool.

Reviewers: billiob, raster

Differential Revision: https://phab.enlightenment.org/D1207
2014-07-21 20:42:57 +02:00
godfath3r c029c9fe9b Miniview: Fix indicators initial position
Summary:
  When you scrollback to history and miniview is disable,
  when you enable it, it doesn't really know the correct
  position to show. Now it does!

Reviewers: billiob

Reviewed By: billiob

Differential Revision: https://phab.enlightenment.org/D1206
2014-07-20 21:33:38 +02:00
wonguk.jeong a83bd06905 tyalpha: support opacity level option
Summary:
support opacity level option for tyalpha.

usage: tyalpha [-p] on|off|<opacity level>

Test Plan: terminology -> tyalpha 60

Reviewers: billiob, raster

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1197
2014-07-17 12:50:04 +02:00
Boris Faure 2833ad913c fix compiler warnings 2014-07-15 12:37:51 +02:00
wonguk.jeong 0f463fc4bf tycat: show a media properly in precise area
Summary:
Precise multimedia size/type/aspect ratio could be acquired after first frame has been decoded.

Therefore,

Fixes T1376

1. put every file in the queue, and handle them one by one
2. in case of video, block queue handling until "frame_decode" callback is invoked.
3. to avoid infinite blocking, put timer for timeout check

Test Plan:
1.terminology -> tycat "video file" -> check whether the video size is fit to real video size
2.            -> tycat "audio file" -> check whether black area is shown or not

Reviewers: billiob, raster

Subscribers: seoz

Maniphest Tasks: T1376

Differential Revision: https://phab.enlightenment.org/D1192
2014-07-15 12:34:00 +02:00
Boris Faure 3afe93fd71 lz4: fix shadow variables, again… 2014-07-15 12:32:58 +02:00
Godfath3r 5db4ef8519 Terminology: Miniview: add position indicator
Summary: Merge branch 'miniview_indicator'

Reviewers: raster, billiob

Maniphest Tasks: T1417

Differential Revision: https://phab.enlightenment.org/D1150
2014-07-15 12:27:27 +02:00
Cedric BAIL e3fbd7f030 lz4: fix another security issue on ARM 32. 2014-07-14 16:00:09 +02:00
Boris Faure 585345f836 add % to opacity level 2014-07-13 15:23:24 +02:00
wonguk.jeong 5bcf35d642 options: opacity level configuration support
Summary:
In translucency mode, opacity level could be changed with this patch.

@fixes T1066

Test Plan: option -> video -> turn on translucency -> change opacity level

Reviewers: billiob, raster

Subscribers: seoz

Maniphest Tasks: T1066

Differential Revision: https://phab.enlightenment.org/D1180
2014-07-13 15:11:46 +02:00
Boris Faure 1891ce2ef1 remove useless code 2014-07-13 00:27:43 +02:00
wonguk.jeong f982ee8fb9 options: translucency during theme changing bug fix
Summary:
when theme has been changed, translucency was ignored

@fix

Test Plan: set translucency -> change theme

Reviewers: billiob, raster

Subscribers: seoz

Differential Revision: https://phab.enlightenment.org/D1179
2014-07-11 20:45:22 +02:00
Sebastian Dransfeld cd63abe7e0 free forked config on error
If an error happens during main, the forked config isn't free'd. So if
the config exists at end, free it.

CID 1100644
2014-07-10 11:42:59 +02:00
Boris Faure 651cbfa08c fix possible segfault detected as CID1224396. 2014-07-03 20:56:36 +02:00
Mike Blumenkrantz 3f53f0aa5e disallow tw popups while terminology popup is present
fix T1290
2014-07-03 11:14:24 -04:00
Mike Blumenkrantz 4f945bcdd7 hide tw popup on terminal popup show
fix T1290
2014-07-03 11:14:19 -04:00
Jean-Philippe Andre 4fa040fccb Miniview: Fix crash due to miniview render after deletion
_deferred_renderer() could be called after object del because the
timer was renewed even though it was invalid (marked as NULL).
2014-07-03 12:10:46 +09:00
Jean-Philippe Andre 4012be784c extns: Add .tga to the recognized image files
Add it to tyls as well
2014-07-03 10:17:12 +09:00
Carsten Haitzler 40b7eaf09f fix continual wakeups with miniview every 0.1 sec
as pointed out by GKH:

https://plus.google.com/u/0/111049168280159033135/posts
2014-07-03 08:54:10 +09:00
Boris Faure feca95c493 don't try to display pdf while don't have page controls 2014-07-01 20:25:02 +02:00
Boris Faure 572c4cfce4 fix uninitialized scalar variable (CID1224271) 2014-07-01 08:10:36 +02:00
Boris Faure cd82ef6b57 handle elm_theme_overlay correctly. Closes T1370 2014-06-30 22:38:13 +02:00
Boris Faure 371b402947 fix link detection on end of lines 2014-06-30 21:48:55 +02:00
wonguk.jeong b053c96eec media: add missing extension for media
Summary:
add flac, m4a, opus

fixes T546

Test Plan: tycat flac or m4a or opus in terminology

Reviewers: raster, billiob

CC: seoz

Maniphest Tasks: T546

Differential Revision: https://phab.enlightenment.org/D1087
2014-06-30 20:49:12 +02:00
Iván Briano fd065b81f7 Don't add unnecessary newlines on selections.
We were adding newlines on wrapped lines that ended with a ' '. I don't
see anything breaking by removing this check, but if something does,
please be clear about it.
2014-06-30 00:29:38 -03:00
Boris Faure 4134aa27be lz4: fix shadow issue 2014-06-29 23:07:40 +02:00
Boris Faure 46a3342f9a update contributors 2014-06-29 19:02:12 +02:00
Boris Faure 669a107be7 fix missing newlines on selections. Closes T1387 2014-06-29 17:19:11 +02:00
Boris Faure 223ed1651c update lz4 to r118
it sucks to embed it
2014-06-29 17:19:11 +02:00
Cedric BAIL f39f25598d evas: enable support for exif on all image type. 2014-06-29 13:43:01 +02:00
wonguk.jeong 9307b77b96 media: support rotation by metadata
Summary:
if we drag & drop jpeg image with orientation information in exif metadata, the image was not properly rotated.

with D1082, D1084, you could see properly rotated image

fixes T1357

Test Plan: terminology -> drag and drop jpeg image with orientation metadata in exif -> check whether the image is rotated properly or not

Reviewers: billiob, raster

Reviewed By: billiob

CC: seoz

Maniphest Tasks: T1357

Differential Revision: https://phab.enlightenment.org/D1085
2014-06-24 21:41:47 +02:00
wonguk.jeong 69c8824caf option_font: selected standard font bug fix
Summary:
Fallback of selected font finding logic is wrong.
As Is: set selcted font if full name is exactly same or just font name without style is same
To Be: find font which is exactly same full name. If failed to find, use find font with same font name

Fixes T1368

Test Plan: terminology -> set font in setting (as Dejavu Mono) -> open setting -> check whether font is Dejavu Mono or not

Reviewers: billiob, raster

Reviewed By: billiob

CC: seoz

Maniphest Tasks: T1368

Differential Revision: https://phab.enlightenment.org/D1076
2014-06-24 21:39:19 +02:00
Boris Faure cf7ea0ea50 do the fix correctly! 2014-06-22 19:44:32 +02:00
Boris Faure eabdca9861 fix size hints. Closes T662 2014-06-22 19:21:21 +02:00
Boris Faure 573e621145 cleanup config_fork use
Let's hope it works perfectly everywhere this time
2014-06-22 17:38:26 +02:00
Boris Faure 9cccb0de1a update copyright info 2014-06-22 17:13:47 +02:00
Carsten Haitzler 57a052bec7 Revert "cleanup config use"
This causes major segvs ith single instance multiple windows mode -
every close of a window causes terminology to crash!

This reverts commit 6cd6c87210.
2014-06-22 20:42:48 +09:00
Boris Faure 6cd6c87210 cleanup config use 2014-06-21 18:53:25 +02:00
Boris Faure 7dba8182cf fix resource leak reported as CID1100644 2014-06-21 17:12:05 +02:00
Boris Faure a3492b980f add ISO_Level3_Left to _is_modifier() 2014-06-21 14:56:11 +02:00
Boris Faure 9f5d1ad674 fix selection when in scrollback when underneath scrolling occur 2014-06-15 22:50:26 +02:00
Boris Faure 92555866ee adjust scroll with direction
never noticed the bug but might occur
2014-06-15 22:49:13 +02:00
Boris Faure 7191991aec remove debug 2014-06-15 22:29:56 +02:00
Boris Faure 68b73b1302 remove dead code spotted by CID1222466 2014-06-12 21:18:14 +02:00
Boris Faure 1af822bcef fix tab counter glitch. Closes T477 2014-06-10 23:45:07 +02:00
Boris Faure 97232ba337 Fix focus issue when closing splits. Ref T477 2014-06-10 23:17:11 +02:00
Boris Faure 9aa5efae1f remove correct term 2014-06-09 19:40:25 +02:00
Boris Faure 896c6500ee Fix case where the wrong term object is deleted. Steps on T477. 2014-06-09 18:59:17 +02:00
Boris Faure 514f630cf3 fix text scrolling 2014-06-09 14:03:25 +02:00
Boris Faure cb6423fd73 tab selector: don't overzoom. Closes T875. 2014-06-09 12:53:00 +02:00
Carsten Haitzler fd53d48735 whitespace cleanup 2014-06-09 08:14:00 +09:00
Carsten Haitzler f7cd970c19 fix sel to not respond to mouse events when exit_on_sel is set
this should actually fix T618 without animation breakages
2014-06-09 08:12:41 +09:00
Carsten Haitzler be8c20ab26 Revert "Tab-switching from keyboard should exit asap. Closes T618"
This reverts commit ab3759b67b.

Now the animation ends suddenly with no transition in some cases, but
smoothly in others. exit_on_sel is set when sel_exit() is called to
set it. it is ONLY called if the term to sel != current term (thus a
new term is selected immediately when the sel appears), so it can know
to begin an exit anim when the initial animation has finished. how
about instead of breaking the animatkon, just disable mouse event
handling (move, click) if exit_on_sel is set? :)
2014-06-09 08:05:36 +09:00
Boris Faure ab3759b67b Tab-switching from keyboard should exit asap. Closes T618 2014-06-08 19:09:43 +02:00
Boris Faure e51c2168e9 fix segfault. Closes T1286 2014-06-08 15:52:34 +02:00
Boris Faure 503dd08105 handle fonts with multiple names 2014-05-25 22:38:23 +02:00
Boris Faure a3e7a770bc improve font listing: be able to select style 2014-05-25 22:02:24 +02:00
Boris Faure d194d406a3 add guard header 2014-05-24 16:14:20 +02:00
Boris Faure 4362049175 config: correctly display "bell_rings" 2014-05-17 21:03:42 +02:00
Boris Faure b4321a896c fix segfault when saving configuration 2014-05-17 21:01:30 +02:00
Carsten Haitzler 153956bfd5 fix segv in isspace() if value not in unicode range 2014-05-16 17:57:12 +09:00
Carsten Haitzler 2aeeaa4589 major color correctness and sizing correctness fixes to miniview
and that's only a start. they whole smart object is wrong.
2014-05-16 17:44:11 +09:00
Carsten Haitzler 4df9246db0 fix indenting 2014-05-16 16:52:31 +09:00
Carsten Haitzler 9ca44463f6 miniview - improve formatting 2014-05-16 16:36:23 +09:00
Flavio Ceolin bc4d1bbbf9 Fixing alt-backspace behaviour 2014-05-15 22:51:39 -03:00
Boris Faure 4c7ffd2292 oops, there's no config for miniview 2014-05-15 23:34:59 +02:00
Boris Faure 2f851eb9a0 miniview: (shift/ctrl/alt)PgUp/Down to scroll 2014-05-14 23:17:24 +02:00
Boris Faure 46a85b4962 miniview: increase scrolling step 2014-05-13 23:10:10 +02:00
Boris Faure 3fb2c08e6d miniview: add doc 2014-05-13 23:10:10 +02:00
Boris Faure d72a0cbec3 miniview: close from edj 2014-05-13 23:09:59 +02:00
Boris Faure 8d04ae955e miniview: use edje 2014-05-13 22:23:34 +02:00
Boris Faure b38defd518 miniview: display correct colors 2014-05-13 22:23:34 +02:00
Boris Faure 42cbf2f0ed miniview: fix with splits 2014-05-13 22:23:34 +02:00
Boris Faure 2e2862dd22 miniview: click on it to scroll to that position 2014-05-13 22:23:34 +02:00
Boris Faure ec8d5ac98e miniview: deferred rendering 2014-05-13 22:23:34 +02:00
Boris Faure 73930a6712 miniview: have only one buffer 2014-05-13 22:23:34 +02:00
Boris Faure 7fbc02b7c6 miniview: toggle miniview from miniview 2014-05-13 22:23:34 +02:00
Boris Faure e5c8da2cbd miniview: correctly handle resizing 2014-05-13 22:23:34 +02:00
Boris Faure c311cbf8da miniview: handle redrawing when scrolling 2014-05-13 22:23:34 +02:00
Boris Faure f96ef2f240 miniview: scroll with mouse wheel 2014-05-13 22:23:34 +02:00
Boris Faure 37f4ac15bb miniview: also draw current screen 2014-05-13 22:23:33 +02:00
Boris Faure eddec5e387 miniview: have ctrl-shift-h toggle the miniview 2014-05-13 22:23:33 +02:00
Boris Faure cc23a7e896 miniview: fill the image from backlog 2014-05-13 22:23:33 +02:00
Boris Faure d4ce1166c6 miniview: use an image ftm 2014-05-13 22:23:33 +02:00
Boris Faure b8cd00dadd add termio_pty_get() 2014-05-13 22:23:33 +02:00
Boris Faure e06f4ee3a3 add miniview_init/shutdown 2014-05-13 22:23:33 +02:00
Boris Faure 23d3944b76 miniview: cleanup 2014-05-13 22:23:33 +02:00
Godfath3r a5bb346937 add miniview feature to terminology.
Pressing ctrl+shift+f toggles miniview on the side of each terminal/split/tab
2014-05-13 22:23:33 +02:00
Boris Faure b504db6cba play a bit with pahole 2014-05-08 14:07:37 +02:00
Boris Faure 2b9c9a8351 add some padding fields to be sure holes are initialized (hi valgrind!) 2014-05-08 13:55:01 +02:00
Boris Faure c3c8310218 Fix bracketed paste mode. Closes T1233. Patch by Egmont 2014-05-07 20:41:14 +02:00
Gustavo Lima Chaves 5680e5a827 Revert "fix alt-backspace"
This reverts commit 2d495f0b59.

With this, the combination won't work even for bash.
2014-04-24 23:44:43 -03:00
wonguk.jeong f6496d90c2 terminology: remove unncessary code
Summary: @fix

Reviewers: raster, billiob

CC: seoz

Differential Revision: https://phab.enlightenment.org/D789
2014-04-24 22:25:32 +09:00
Wonguk Jeong e717b71589 terminology: restore movie play state when the media block is reactivated.
Summary:
first phase to resolve T1075
With D786, the paused video would be in paused state even if the media block is reactivated.

But the problem is....
every backend except "gstreamer1" doesn't show any image on screen when the video is loaded in paused state. (it's working perfectly with gstreamer1)
maybe the root cause is that frame decoding is never happened yet.
This need to be investigated, in the next phase (maybe in emotion or emotion modules?)

@fix

Test Plan: terminology -> tycat -> pause video -> page down enought until the video block is deactivated -> page up -> check whether the video is in paused state or not

Reviewers: raster, billiob

CC: seoz

Maniphest Tasks: T1075

Differential Revision: https://phab.enlightenment.org/D787
2014-04-24 18:10:29 +09:00
Carsten Haitzler 3e9edfb58e remove some useless code - like cache flushing 2014-04-24 12:17:00 +09:00
Boris Faure 2d495f0b59 fix alt-backspace 2014-04-23 20:56:16 +02:00
Boris Faure 6fd4e8c57a add an option to decide whether the bell rings 2014-04-22 23:38:03 +02:00
Boris Faure fd518e1a80 fix typo 2014-04-22 21:21:22 +02:00
Wonguk Jeong e2c687cf99 terminology: recalculate textgrid size when config is updated
Summary:
When configuration (font size, face..) was changed, textgird size was not recalulated properly.

Fixes T945

Test Plan: terminology -> maximize window -> font change (size) -> check whether max col/row are fit on window size

Reviewers: raster, cedric, billiob

Reviewed By: billiob

CC: seoz

Maniphest Tasks: T945

Differential Revision: https://phab.enlightenment.org/D772
2014-04-22 20:31:59 +02:00
Boris Faure 5bf2692eff should fix F1-4 2014-04-20 13:55:41 +02:00
Iván Briano 2b1521888f Fix wrong copy/paste/replace
Long ago, a very wise wizard said that it's a good idea to match
delimiters to their corresponding endings, so let's do that, mmmkay.
2014-04-17 16:58:43 -03:00
Boris Faure 12f4dcfaf6 make app_server only with efl ≥ 1.10
I'm tired of trying to make that code compatible accross efl versions
2014-04-15 22:21:41 +02:00
Boris Faure df59f16486 fix Ctrl/Shift/CtrlShift + Fn
Thanks to Kagetsuki for reporting about it
2014-04-12 17:44:35 +02:00
Boris Faure 86cc375322 fix possible NULL dereference 2014-04-12 14:59:31 +02:00
Boris Faure 3bc68b99bb fix CID1201428 Explicit null dereferenced 2014-04-12 14:59:12 +02:00
Boris Faure 42599a47b9 fix CID1201427 Explicit null dereferenced 2014-04-12 14:58:55 +02:00
Boris Faure d5a97a1e13 fix CID1201426 Explicit null dereferenced 2014-04-12 14:53:28 +02:00
Boris Faure dafb51f66e fix CID1100650: possible NULL dereference 2014-04-12 14:33:31 +02:00
Boris Faure 5cd68f3beb finish active-links checkbox 2014-04-11 21:30:52 +02:00
Jason L. Cook 5e70628dae Added config directive for Active Links, defaulting to true
Summary:
Added element ot config struct to support toggling of Active Links

Added boolean to support Active Links config directive

Added configuration directive for Active Links

Return from appropriate functions if Active Links is disabled

Test Plan: Reviewers

Reviewers: billiob, raster

CC: billiob, raster

Differential Revision: https://phab.enlightenment.org/D689
2014-04-11 21:30:52 +02:00
Tom Hacohen 9f723c2335 Adjust code to use the slightly different Eo2 API.
With Eo2 you can return values directly without the need to use
a pointer
(use the C return).

For example:
eo_do(obj, elm_object_text_get(&text));
becomes:
eo_do(obj, text = elm_object_text_get());

@feature
2014-04-10 09:50:50 +01:00
Boris Faure 02856cbdec terminology supports fraktur!! 2014-04-06 14:42:38 +02:00
Tom Hacohen 6c7f608eff Adjust to Eo2. 2014-04-03 17:35:07 +01:00
Boris Faure 3d137aa3e9 fix wrong assignement 2014-03-25 21:58:15 +01:00
Boris Faure 9346db3ba7 initialize some variables 2014-03-25 21:57:34 +01:00
Boris Faure 00fbb359ee fix possible NULL issues 2014-03-25 21:49:46 +01:00
Boris Faure 0313446e79 let's try to recover from malloc failure: ahah 2014-03-25 21:43:49 +01:00
Boris Faure ebfce9e480 please clang-analyzer with false unintialized arguments 2014-03-25 21:43:11 +01:00
Boris Faure 8d18d16b40 we can't be sure of the signedness of Eina_Unicode 2014-03-25 21:35:57 +01:00
Boris Faure 8f3258f1b3 use a bit more Eina_Unicode 2014-03-25 21:35:31 +01:00
Sebastian Dransfeld 12617004ee fix overflow issue
(1 << (1 + 6 + 6 + 6 + 6 + 6)) is signed -2147483648 and unsigned
2147483648. We want to check against the unsigned value, and since g is
signed we need to cast.

CID 1100656, 1100660
2014-03-24 13:47:42 +01:00
Sebastian Dransfeld cd189663bd remove dead code
We make sure that arg >= 0 before this line, so check is redundant.

CID 1100658
2014-03-24 13:40:05 +01:00