There is no need to recalc row and col position of the item, they are already stored in the item struct.
The old implementation was calculating wrong values and also was storing this wrong values in it->x and it->y, resulting in wrong results for the elm_gengrid_item_pos_get() function.
so, at the end, this is a @fix for the pos_get() function.
Also changed a bit the test to let the gengrid fill the window and thus testing behaviour on col/row changes.
I didn't find any regression in all the gengrid tests after this, let me know if it broke something for you.
Issue:
1. elementary_test -> slider
2. move mousewheel on slider and popup gets shown.
3. close the slider window very fast or increase the wheel_timeout to 4 seconds
4. observe crash
deleting subobjects here was occurring and triggering sizing eval
prior to removing the objects from the evas box, resulting in a failure
to accurately calculate and set size hints
also set delete_me to block sizing evals during subobj deletion loop
in order to avoid object thrashing during the time when nothing is happening
@fix
Summary:
When continous mouse clicks happen hover emits the hide signals continously
to edje. As the embryo program for hiding requires some time to finish the
animation, if within that time another mouse click comes the program gets
invoked again and thus the hiding will get delayed till the mouse clicks ends.
This patch fix that issue by adding a flag for emitting signals.
@fix T3006
Signed-off-by: godly.talias <godly.talias@samsung.com>
Test Plan: elementary_test
Reviewers: cedric, conr2d, prince.dubey, shilpasingh, Princekrdubey
Reviewed By: shilpasingh, Princekrdubey
Subscribers: Princekrdubey, divyesh, govi, rajeshps
Maniphest Tasks: T3006
Differential Revision: https://phab.enlightenment.org/D3526
Summary:
1) Recalc error occurs if combobox_hover_begin() was called by the app, it can be reproduced by keeping elm_combobox_hover_begin() in the test_combobox.c
2) Content_set in hover always considered "bottom" as it's best_location as it done during the constructor.
@fix
Signed-off-by: divyesh purohit <div.purohit@samsung.com>
Test Plan:
It can be reproduced by keeping elm_combobox_hover_begin() in the test_combobox.c.
Also the changing the position of combobox in the window would give top/bottom as it's best location.
Reviewers: cedric, shilpasingh
Reviewed By: shilpasingh
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D3544
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
it's wierd to expand hoversel without items.
the behavior made me suprised before i analyzed it.
it looked almost a bug.
if you have any other objections, please ping me.
conceptually, ctxpopup won't give any geometry information of the container.
this event is a way for returning the information of the container for user scenarios.
@feature.
fix @T2042
Coverity CID1347398 reports that this could potentially be a
non-portable assumption resulting in a sizeof mismatch. Fix this by
using the actual structure type in the call to calloc.
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
This patch just fixes a compiler warning about using fw/fh
uninitialized if the conditional is false
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
previously-applied max size hints should not be unset; these are only
able to be set externally from a parent object, so don't overwrite them
internally
@fix
Summary:
If argument variable is not used in function, then only
that variable should be declared as EINA_UNUSED.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: Hermet, singh.amitesh
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D3525
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
It was changed for testing shrink mode signals.
But, it was unnecessary change for default theme.
Test Plan: N/A
Reviewers: zmike, jaehwan
Differential Revision: https://phab.enlightenment.org/D3536
Summary:
When elm_sys_notify was not needed, its singleton instance
is NULL. Eo complained about passing a NULL pointer.
Thanks to bu5hm4n (Marcel Hollerbach) for the report.
@fix
Reviewers: stefan_schmidt, cedric
Subscribers: bu5hm4n
Differential Revision: https://phab.enlightenment.org/D3535
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
With the push of 1056b6ed01475817da2439012057d11865d2c5d8, elementary
compile broke due to undeclared variables. This patch fixes elm to
compile again by declaring the missing vars.
@fix
@raster, Please double check this change as I am unsure if it is what
you Really intended here.
Signed-off-by: Chris Michael <cpmichael@osg.samsung.com>
this fixes the config monitoring to not use flush.cfg but to use the
correct profie.cfg or base.cfg in the profile we are using. this is
necessary to do "special" profiles per screen so apps that switched to
another profile because asked by e, monitor THAT profile for changes
specifically and dont also switch profiles since they have been told
what to use now.
@fix
this adds the ability to have one profile automatically be derived
from another with modifications applied. right now it only can do a
very limited modification - multiple scale. over time this will
expand. this is only inteded otbe sued by a DE like enlightenment, so
it's not going to be documented fully at this point.
@feature
tis would also make behavior more consistent with the tool as before
sometimes it flushed + saved, sometimes just flushed which would lose
settings. now since this works right in elm config in the lib, we dont
need to save if we flush as flush saves too.
Davide Andreoli
Andy Williams
Amitesh Singh
Jean-Philippe Andre
Cedric BAIL
Stefan Schmidt
Mike Blumenkrantz
godly.talias
Tom Hacohen
Minwoo, Lee
Carsten Haitzler
Larry
divyesh purohit
Hermet Park
Chris Michael
Umesh Tanwar
Subodh Kumar
Youngbok Shin
Stephen okra Houston
Jean Guyomarc'h