Summary:
evas_object_clip_unset was broken for group object in several month or year..
basically,
evas_object_clip_unset(obj)
efl_canvas_object_clipper_set(obj, NULL)
is equal on efl_clip implements,
but on the group object, we need to unclip the whole group children in
efl_canvas_group_efl_canvas_object_clipper_set
which was not performed by legacy clip_usnet API.
Test Plan:
try clip_unset(obj) and clipper_set(obj, NULL) in any group clipped case
(i.e. scroller content) and see clip_unset is broken and fixed by patch.
Reviewers: cedric, bu5hm4n, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10984
With this commit you can move the focus from the textbox widget to the surrounding widgets, (as it is done in legacy).
ref T8538
ref T8522
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10987
Entry was added to the same box. This commit fixes this.
You could observe this problem when starting the "Textbox Input Field" demo in elm_test
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10986
out of the documentation of struct tm:
int tm_mday; /* Day. [1-31] */
shifting this range one up results in day 32 beeing selectable, but 1
not beeing selectable.
With this commit we could have again working CI.
Differential Revision: https://phab.enlightenment.org/D10992
Summary: We need an efficient method to navigate children faster.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10989
This patch adds support to run the StyleCop rules. To enable, -Ddotnet=true
is needed, You can pass -Ddotnet-stylecop=CAXXXX,CAXXYY where X and Y are digits for CAs
or SAs. You can also ask that the CAs and SAs cause errors instead of warnings.
Differential Revision: https://phab.enlightenment.org/D10969
Summary:
The issue with `text_class` in Edc styles has to be within a string containing `font` & `font_size` properties to effect style, if font or font_size not presented in the same string text_class will be ignored.
So in the following Edc example, `text_class` will be ignored:
```
collections {
text_classes {
text_class {
name: "tc1";
font: "Sans";
size: 20;
}
}
styles {
style {
name: "style1";
base: "color=#00FF00 text_class=tc1";
tag: "br" "\n";
}
}
}
```
To apply text_class `tc1`, font and font_size has to be added to `styles.style.base` value, to be as follows:
```
...
base: "font=Serif font_size=15 color=#00FF00 text_class=tc1";
...
```
NOTE: The produced font will be `Sans` and font_size equal to `20`
Test Plan:
`layout.edc`
```
// compile: edje_cc layout.edc
// play: edje_player layout.edj
collections {
text_classes {
text_class {
name: "tc1";
font: "Sans";
size: 20;
}
}
styles {
style {
name: "style1";
base: "color=#FFFFFF text_class=tc1";
}
}
group {
name : "group1";
parts {
part {
name : "tb1";
type: TEXTBLOCK;
scale: 1;
entry_mode: NONE;
description {
state: "default" 0.0;
rel1.relative: 0.0 0.0;
rel2.relative: 0.5 0.5;
text {
style: "style1";
align: 0.0 0.0;
text: "Hello EFL";
}
}
}
}
}
}
Reviewers: segfaultxavi, smohanty, ali.alzyod, cedric, zmike
Reviewed By: zmike
Subscribers: zmike, segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8477, T8478
Differential Revision: https://phab.enlightenment.org/D10692
Summary: this was a int ... cutting of the floating point digits. Now it works.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10977
Summary:
pulse_mode is now implicit with pulse, if you set the progressbar to
pulse, the state is internally adjusted in a way that the theme is put
into the correct state. Legacy is not impacted by this because of the
previous commit.
ref T8501
Depends on D10941
Reviewers: cedric, woohyun, zmike, segfaultxavi
Reviewed By: zmike, segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8501
Differential Revision: https://phab.enlightenment.org/D10942
Summary: This patch only changes some of legacy calls, with new ones
Reviewers: woohyun, zmike, bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8522
Differential Revision: https://phab.enlightenment.org/D10982
this will be common enough to put into elm - there is no way to do a
gimp style "tool palette" where you select one of them (like one from
a set of radio buttons) at all times... but you don't want the "round
circle" but instead want it to look more like a button to fit in with
a palette style look. this calls for styles... so here they are.
@feat
Currently, edje.pc gets its lua Requires from the -Dlua-interpreter argument.
If -Dlua-interpreter=lua, an unversioned lua entry ends up in Requires, which
cannot always be satisifed. The evas filters meson.build handles this case by
generating a version-specific entry. This patch copies that logic into the top
level meson.build, and passes the result to the edje subproject.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10965
This patch will make the CollectionView remember at all time the last
focus object and the last item in the list.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10677
Checking for non-generated code.
ref T8399
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10959
Summary:
This patch will make **efl_text_cursor_move** method, when it is working with **WORD_START** or **WORD_END** If no actual movement happened then return false, and do not fire CHANGE event
for example if cursor at word start, and we call efl_text_cursor_move(cursor, word_start);
1- this call should return false because no actual movement happened. If no actual movement happened then return false
2- this call should not fire CHANGE event for cursor.and do not fire CHANGE event
Reviewers: woohyun, segfaultxavi, cedric, zmike
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10949
Summary:
When the cursor is at line beginning of line, and user click "Up" then "Down" on keyboard cursor will position at second character.
If text is: **occaecat \n mollit**
Reviewers: woohyun, zmike, cedric, segfaultxavi
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10947
Summary:
This will fix the task:
T8542
Remove variation sequences as part of glyph when deleting clusters, variation sequence is meaningless alone, so they should be removed when deleting
Reviewers: woohyun, bowonryu
Reviewed By: bowonryu
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10956
Summary:
screen_name was used to for both displays, user name and screen name.
Fix this typo and make sure the user_name variable is actually used.
Depends on D10886
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, ProhtMeyhet, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10934
Summary:
JS interpreters seems to be forgiving for these but the majority of the
js code examples already use semicolons. Make it consistent and fix up
the missing places.
Reported-By: https://lgtm.com/projects/g/Enlightenment/efl
Reviewers: felipealmeida, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10882
Summary:
From documentation `line_jump_by` should return `EINA_TRUE` if cursor moved, and `EINA_FALSE` if not moved.
But the current behaviour is reversed, so this should fix it.
Reviewers: ali.alzyod, segfaultxavi, woohyun
Subscribers: AbdullehGhujeh, #committers, cedric, #reviewers
Tags: #efl
Maniphest Tasks: T8454
Differential Revision: https://phab.enlightenment.org/D10946
Summary:
This less-than-zero comparison of an unsigned value is never true..
this condition can not be true.
Test Plan: N/A
Reviewers: ali.alzyod, woohyun, jsuya
Reviewed By: jsuya
Subscribers: jsuya, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10961
Summary:
If a struct or enum field doesn't explicitly sets since information, then since
is inherited from struct documentation if it is available.
Reviewers: jptiz, Jaehyun_Cho, woohyun, q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8359
Differential Revision: https://phab.enlightenment.org/D10948
This hide internal classes..
Reviewed-by: Felipe Magno de Almeida <felipe@expertisesolutions.com.br>
Differential Revision: https://phab.enlightenment.org/D10912
junsu choi
SangHyeon Jade Lee
Ali Alzyod
Marcel Hollerbach
Hermet Park
Lauro Moura
Hosang Kim
a.srour
rafspiny
Carsten Haitzler
Ross Vandegrift
Xavi Artigas
Cedric BAIL
Bruno da Silva Belo
Myoungwoon Roy, Kim
Stefan Schmidt
Bowon Ryu
Felipe Magno de Almeida
Yeongjong Lee