Commit Graph

23668 Commits

Author SHA1 Message Date
Carsten Haitzler 2ba8179ac2 todo - add some tiling notes 2019-08-10 12:39:16 +01:00
Carsten Haitzler a172d930da tiling - ignore min size for layout of tree to avoid insta-floats
so some clients just cant tile due to min size and this leads to
really bad results so pass the problem back to the user to go resize
them up to fit. this probably needs far more extensive layout logic.
the data struct is a tree but perhaps it needs to flatten out into a
table to make layouting more sane. but that's the future. for now be
less bad today.
2019-08-10 10:57:09 +01:00
Carsten Haitzler e11eb90231 tiling - on not fit error use name get util and translated strings
if we use the util func we do get a title... and als use translation
too for this notification. Also increase timeout so people can read it
and notice it.
2019-08-10 08:38:27 +01:00
Carsten Haitzler 265c306874 tiling - avoid infinite loop of not fit - toggle float, not fit, toggle
this actually just blows the stack soon enough... so short circuit it.
2019-08-10 08:32:11 +01:00
Carsten Haitzler 2aae421d7a any dialog - nicety - emot focusd/unfocused sigs to base
makes for nicer themes... simple.
2019-08-10 00:48:39 +01:00
Carsten Haitzler 6134ac44cf tiling - disable last frame adj - this blocks resizing entirely...
for me this seems to improve things... drastically... fixes resizing
int iling whne no borders selected.
2019-08-09 22:18:14 +01:00
Carsten Haitzler 758894bc9c tiling config -fix use after free crash on change of config 2019-08-09 14:13:17 +01:00
Carsten Haitzler 2158d46dba e comp obj - edje messages - also send on size change
so sned only if bx/y/xx/yy or size changed
2019-08-09 10:01:21 +01:00
Carsten Haitzler 714c03fa65 todo - add note about the dirty and native surface thing 2019-08-09 09:54:43 +01:00
Carsten Haitzler fdd472879b xkb - make basic variant null now and handle in wl too the same as x
now russian works for me. :)

fixes T7979

2019-08-09 09:50:33 +01:00
Carsten Haitzler 855c7028c4 xkb core - make layotu set safer by udp before we free
this should fix another possible crash vector.

2019-08-09 00:40:18 +01:00
Carsten Haitzler 7c4e58a2fc xkb - module - fix use after free - duplicate layout info instead
instead of referring to what migh tbe deleted under us - make a dup of
it to tsatore locally. fixes segv on kbd layout change

2019-08-09 00:39:19 +01:00
Carsten Haitzler ac6ceb0b99 reduce getenv calls by only getting once
we do egetvn's quite frequently and this is more costly than
remembering once and getting it once... fix that in some cases.
2019-08-08 23:54:09 +01:00
Carsten Haitzler 78c26e5f8d e comp - dont send messages uselessly with same values to theme
when border changes send then but not all the time. this drops some
mebryo overhead i was seening.
2019-08-08 23:53:18 +01:00
Carsten Haitzler f76627a6be e comp - reorder alpha native etc. surface sets to avoid crashes
this also avoids spurious texture uploads so it should be an
optimization too, but more importantly... thisis a fix. it fixes T8021


yay yay yay
2019-08-08 20:44:14 +01:00
Carsten Haitzler 2e4c638367 todo- add notes on screen handling 2019-08-08 10:33:50 +01:00
Carsten Haitzler 64ffda59ec e sys - if decklock on suspend is set and systemd says we suspend, lock
if systemd suspended and we hand't triggered it, and desklock on
suspend is enabled, then lock there and then because we need to. of
course you need systemd/logind... but hey... i guess without you live
with less... :) fixes logic hole

2019-08-08 09:56:04 +01:00
Carsten Haitzler 7ab9466f77 everything - fix string index mishandle that causes segv's
also ensure we nuke time rhandles too - spotted that. this is a real
issue asan found and yomi first pointed at. reproduced, found, fixed.

2019-08-08 09:24:10 +01:00
Carsten Haitzler fd26c7b224 evry - handle invalid chars in filters nicely and stop string walking
possible issue lurking if a utf8 char sequence has invalid content ...
avoid it.
2019-08-07 21:16:12 +01:00
Carsten Haitzler 8884f27975 e wl - fix borders to keep cutouts working
in soem cases a client has no csd and then border l/r/t/b/ are all 0
so artifically keep 1 at 1... to keep cutouts working.

still need to solve blending still being on though.
2019-08-07 21:15:00 +01:00
Carsten Haitzler d4340cb168 e wl pixmap - use id not xwin
copy & paste failure here. fix. found by asan.
2019-08-07 16:51:41 +01:00
Carsten Haitzler cbd507fb13 appmenu gadget - size items properly so they can be seen 2019-08-07 00:49:26 +01:00
Carsten Haitzler df0a64dc7a e dbusmenu - fix cross referencing from e menus created from debus menu
this stops crashes when e menu si still up when the dbus menu backing
it has changed/gone away... by referencing the dbusmenu to hang about
like a bad smell while the e gui menu is up until it's dismissed. this
fixes a real segv i saw with steam.

2019-08-07 00:43:47 +01:00
Carsten Haitzler 2b0735da58 connman - set var to defined value - less warnings 2019-08-06 21:01:26 +01:00
Carsten Haitzler f1b0e638f1 systray - dont prunt null name which is usless
fixes warning and removes always null string.
2019-08-06 20:58:57 +01:00
Carsten Haitzler 3c3e5f3b88 randr - use ints for mode info w/h as we want signed ints for a diff
fixes warning too.
2019-08-06 20:55:54 +01:00
Carsten Haitzler d0dc774673 efm - fix missing format strings in error reporting
fix CID 1403934
fix CID 1403923
2019-08-06 20:03:06 +01:00
Carsten Haitzler c1f73110ac wl input - use eina mkstemp to handle umask right
fix CID 1403927
2019-08-06 19:58:26 +01:00
Carsten Haitzler 78102717ae connman agent - handle theoretical missing requirement and name strings
fix CID 1076319
2019-08-06 19:29:46 +01:00
Carsten Haitzler 52dde8d541 wl - handle null parent safely for subsurfs
fix CID 1403920
2019-08-06 19:23:25 +01:00
Carsten Haitzler e96cff8503 xwayland dnd - handle names not being allocated
fix CID 1403921
2019-08-06 19:20:03 +01:00
Carsten Haitzler 8c76ff3e32 gadget runner - check ptr return before deref
fix CID 1403925
2019-08-06 19:13:50 +01:00
Carsten Haitzler c9356a3f8c wl drag start - check source ptr consistently
fix CID 1403926
2019-08-06 19:11:24 +01:00
Carsten Haitzler 3a581f888d xwayland - handle negative return failure for abs socket create
fix CID 1403929
2019-08-06 19:05:36 +01:00
Carsten Haitzler 96ae312d6e mixer pulse - handle alloc failure better and dont access null
fix CID 1403930
2019-08-06 19:00:46 +01:00
Carsten Haitzler e41d5e11bb e sys l2ping - report errors on fcntl failure
fix CID 1403933
2019-08-06 18:55:28 +01:00
Carsten Haitzler dccf124ff3 mixer backend - fix null checks to cover all uses
fix CID 1403937
2019-08-06 18:53:30 +01:00
Carsten Haitzler b30daea12c e client - check picmap type to be one of the only 2 valid ones
fix CID 1403938
2019-08-06 18:51:08 +01:00
Carsten Haitzler 490e532aa3 comp wl - fix check of source mime types
we dont always assume it's there.

fix CID 1403939
2019-08-06 18:45:58 +01:00
Carsten Haitzler 33ef4bc881 e comp wl - remove dead code
listener might maybe be null, but offer - never.

fix CID 1403945
2019-08-06 18:39:48 +01:00
Carsten Haitzler 1c893b064f wl dnd - check socketpair and fcntl return values
fix CID 1403951
2019-08-06 18:30:30 +01:00
Carsten Haitzler a536c8a6a2 e sys l2ping - check connect return for failures
fix CID 1403952
2019-08-06 18:21:29 +01:00
Carsten Haitzler 0a4f035fb6 wl dnd - fix more use after free
restructure code a bit to not fall into this trap as easily and remove
the falling into the trap where we use buf after freeing it.

fixes CID 1403924
2019-08-06 17:54:40 +01:00
Carsten Haitzler 3c7d93059b wl text input - handle out of mem and free half done struct
stgruct we alloced is not freed if a child element setup fails...
fixes a technical leak. coverity found it.

fix CID 1403931
2019-08-06 17:42:42 +01:00
Carsten Haitzler b03c0739db wireless mod - fix out of bound type array accesses
coverity pointed this out. certainly 1403948 is definitely possible if
no geometry matches succeed.

fix CID 1403948
fix CID 1403944
fix CID 1403928
2019-08-06 17:00:38 +01:00
Carsten Haitzler 031e868b65 efm min - copy in nul byte terminator so be sure
coverity was not happy with this but it's harmless to copy that extra
nul byte... so do it

fix CID 1403950
2019-08-06 14:53:59 +01:00
Carsten Haitzler ccd0da5f02 e sys l2ping - close socket fd on error to be clean
fix CID 1403954
2019-08-06 12:54:28 +01:00
Carsten Haitzler bb390716f5 ibox - make coverity happy by reordering free then list remove
fix CID 1403955
2019-08-06 12:40:08 +01:00
Carsten Haitzler 554026cfe6 ibox - make coverity happy by reordering free then list remove
fix CID 1403956
2019-08-06 12:36:22 +01:00
Carsten Haitzler 1fa7d4a07b wl dnd - fix theoretical buf leak coverity found
fix CID 1403957
2019-08-06 12:35:11 +01:00