this fixes a longstanding race condition where tooltip windowss could exist with a shape rectangle due to race conditions between applying window properties (eg. alpha) and reapplying the input rect
Datetime edc is wrongly designed. Setting heuristic min value for the part is bad :(
This is a hotfix for the following error message when there is a button
for AMPM.
group elm/datetime/base/default has a non-fixed part 'field3'. Adding
'fixed: 1 1;' to source EDC may help. Continuing discarding faulty part.
@fix
- This is a first clean up of 65240b5327e5ab1eb8f77835b4729444fe1f02df
- Fix wrong version for since tag.
- Fix indentation and remove trailing whitespaces.
- Make the code more readable.
- Remove a unused variable.
Summary:
encoded URI is pasted in terminology on dnd with file which has blank in name
ex. Test Blank.avi -> Test%20Blank.avi
Therefore, decode it when we extract file uris from uri list by using efreet.
by the way, copy and paste code likely needs refactoring..
Reviewers: raster, cedric
Subscribers: billiob, seoz
Differential Revision: https://phab.enlightenment.org/D1384
Summary:
elm_config_slider_indicator_visible_mode_set
elm_config_slider_indicator_visible_mode_get
The patch will enable the slider's indicator to get
visible always
visible on focus
visible never
visible on slider value change
Reviewers: raster, seoz
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D1558
Allow changing value of actionslider with keyboard. Make actionslider
focusable widget.
@feature
Conflicts:
config/default/base.src.in
config/mobile/base.src.in
config/standard/base.src.in
Summary: after popup layout refactoring, the popup object cant get evas event.
Test Plan:
1. added popup object.
2. key down event callback add for popup object.
3. run the elementary_test.
4. input some key on popup and check whether the registered function is executed or not.
Reviewers: seoz, eunue, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1688
The items of an item is a list of Elm_Object_Item and not of Elm_Gen_Item.
Sorry @zmike ;-)
Fixes T1859
Another fix has been added in this commit, related to relative items.
elm_genlist_item_subitems_get has to return a list of Elm_Object_Item.
Because of the porting of the genlist item to Eo, this function returns
a list of Elm_Gen_Item.
Thanks to zmike and seoz for catching this.
Fixes T1859
Summary:
Using of dbus menu causes a weird exception that looks
like this (for example in function elm_win_main_menu_get(Evas_Object *win)):
> EINA: Data at address 0x0 is invalid. Replacing with zero page.
> mmap: Operation not permitted
> ERR<22270>:eina_mmap lib/eina/eina_mmap.c:110 _eina_mmap_safe_sigbus()
> Failed to mmap() /dev/zero in place of page. SIGBUS!!!
> Aborted (core dumped)
This issue appears because there is a lot of places where Elm_Object_Item is
used, but it should be Elm_Menu_Item_Data.
This issue could be reproduced with elementary_test:
1. run elementary test with dbus enabled.
2. find "Systray Item" button and click on it.
3. get SIGSEV in your console.
@fix
Reviewers: cedric, raster, seoz, Hermet
Reviewed By: Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1681
Summary:
Application do not change step size because only interface API is existed.
@feature
Test Plan: elementary_test -> scroller -> change step size
Reviewers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1677
Summary:
size_hint_align was used instead of evas_box's internal value for aligning
of internal items. Because of that layout functions of elm_box and evas_box
were incompatable
Fixed elm_box, els_box layout and widgets that used this behaviour.
@fix
Test Plan:
Run "elementary_test". All buttons should be left-aligned
"elm_box_align_set(tbx2, 0.0, 0.5);" (test.c:332)
Reviewers: cedric, Hermet, stefan_schmidt, seoz
Reviewed By: seoz
Subscribers: shilpasingh, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1512
This change is not simple because Elementary has not been built from the
first day to work with Eo. Code had to be adapted to fit the new design.
The del_pre that have not been replaced yet can return FALSE and
prevent deletion. For these classes, code modification has to be deeper
and will be done later.
Because of widget item design, it is hard to make it fit to Eo as it
should be:
- _eo_del_cb should have the callback pointer as data but pre_notify
function forces its storage into the item data because we need to be
able to call the cb before del is really triggered.
- only one cb is supported for an item, meaning replacing it would mean
we have to save the function pointer inside the item, delete the
callback with the previous function as data and then add the new
callback. Instead of it, we just add our own wrapper as Eo callback that
will invoke the function pointer stored in the item data.
When adding xz as third compression format in May 2014 I mentioned that I'm
going to remove bzip2 in favor of xz in 1.12.
I heard no complains but I left it in for 1.12. With 1.13 starting its time
to remove it. From now on it will be only gz and xz compressed tarballs.
Summary:
In some cases, elm_label doesn't calculate its min size if it is not resized from outside.
It is happened when only elm_label used with elm_label_line_wrap_set API.
The following APIs can change min size of the widget, so we can't skip the sizing_eval func.
elm_label_line_wrap_set
elm_label_line_width_set
elm_object_text_set -> _elm_label_elm_layout_text_set will be called.
@fix
Test Plan:
I put a change to test_notify.c for test.
elementary_test notify
-> click "top" button. -> You can't see elm_label without the patch.
Reviewers: woohyun, tasn, seoz
Reviewed By: seoz
Subscribers: herdsman
Differential Revision: https://phab.enlightenment.org/D1652
Summary:
Issue: elm_box_align_set APIs not working well
Solution: hint_set should not be called instead evas box align APIs
have to be used
@fix
Test Plan:
elementary test demo first page, though align is set as 0.0
0.5 it always shows as 0.5
Reviewers: Hermet, raster, seoz
Subscribers: rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D1622
Summary:
Changing of styles for widget items isn't realized yet. This fix should
be presented to avoid segfaults when elm_object_item_style_set/get is calling
@fix
Reviewers: seoz, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: bluezery
Differential Revision: https://phab.enlightenment.org/D1595
Summary:
Because the "elm.swallow.event" part is used for internal needs of Panel widget
setting up or unsetting content of this part can break the behavior of this widget.
Due to the fact that this part is invisible and does not have any use cases for user
it seems acceptable to forbid changing of its content.
@fix
Reviewers: cedric, seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1587
We do trigger an edje theme open during the first stage of quicklaunch as part of
config init apparently. So we better init or we will endup with some really bad
memory corruption.
Summary:
Two scrollable entries' size is too small to view.
This patch expands window size to have suitable size for entries.
@fix
Reviewers: Hermet, seoz, woohyun, tasn
Reviewed By: tasn
Differential Revision: https://phab.enlightenment.org/D1597
Summary:
User application may call some fileselector APIs to configure fileselector instance.
And some of them may call _populate but only last request is needed.
However, T1663 raises that last request might be rejected with expansion option and
multiple requests of _populate.
It's because expansion mode do not allow next _populate until previous one is finished.
So, this patch fixes it via scheduling _populate instead of calling _populate() directly in APIs.
@fix
Maniphest Tasks: T1663
Several APIs are marked as not documented simply because the doxygen
documentation mentions a parameter named "foo" while the spelling in the
prototype is something like "fooh". An example correction is
- * @param fsize Finger size
+ * @param sz Finger size
Nothing very complicated and there are also a couple typo fixes I noticed
while going over the files.
In some cases, like having a drop target inside an inwin (looks like it
can be other containers too) can cause an infinite loop (as described in
the report). The reason for that is that while the drop target was added
when there was an X window available, the X window ws now gone, so the
non X path was being called which didn't have the code to remove the
item from the list being iterated. Yes, definition of spaghetti and
false assumptions.
Elm dnd/cnp need a massive overhaul, they are disgusting.
See the ticket for more information on the issue.
Fixes T1702
Before screaming "don't expose this", here's the reasoning:
There will be a few new APIs in evas-gl (support pbuffer, ...)
that require a pointer to the Evas_GL to be called. So, instead
of exposing each and every one of these evas gl functions in
a dummy wrapper in elm_glview, we just give access to the real
pointer.
GLView will always be a wrapper around evas_gl, because that's
what it is by definition.
Summary:
if translatable is FALSE and _translate_string_data_get returns NULL, ts
would be NULL which results into crash.
@fix
Reviewers: seoz, raster, Hermet
Reviewed By: Hermet
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1543
Summary:
Change requested by TAsn. Previuosly AT-SPI headers were kept private
and included directly into elementary source code. From now on,
AT-SPI headers can be included from Elementary.h public header, however
will be marked as beta APIs.
Commit includes following changes:
* include all atspi headers into new elm_interfaces.h header.
* marking all at-spi interfaces methods/properties as @protected.
* wrap all common headers with EFL_BETA_API_SUPPORT.
* make some common APIs visible in lib, by adding EAPI attribute
(if someone decides to use beta APIs).
Test Plan: out-off tree build with gcc, g++
Reviewers: tasn
Reviewed By: tasn
Subscribers: seoz, q66, kuuko
Maniphest Tasks: T1721
Differential Revision: https://phab.enlightenment.org/D1528
Summary:
There were wrong checkings in elm_win_size_base_get and
elm_win_size_step_get
@fix
Reviewers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1533
Summary:
Since the sd->image is swallowed to the edje object, it's position and size will be managed by edje smart object.
in the bg side, it doesn't need to care the position and size of the image.
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1525
Summary: First page's number is 0. So I changed '+' to '-'.
Reviewers: seoz, jaehwan, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1530
Summary:
When fileselector is opened, it would be nice to be able to provide initial filename.
Like "Untitled Document" in Gedit, when save for the first time.
More details in Gedit,
Gedit provies default name, "Untitled Document" and does not change default name
while navigating directories.
Once we selected any file, Gedit changes value of name entry to selected filename and
it is not also changed while navigating directories.
@feature
Reviewers: seoz, yakov-g
Reviewed By: yakov-g
Subscribers: seoz
Maniphest Tasks: T1664
Differential Revision: https://phab.enlightenment.org/D1504
eo_add()'s counterpart is eo_del, not eo_unref. Regardless of that, some
objects were being double-deleted which spew out some eo errors. These
things should now be fixed.
bc6b6aa457 is the relevant EFL commit.
Summary:
Added this example which demonstrate the exact behavior or "changed" in radio button.
After changing the documentation of "changed" as in https://phab.enlightenment.org/D1445, thought the example might be useful, so added this.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: devilhorns, stefan_schmidt, seoz
Differential Revision: https://phab.enlightenment.org/D1490
This is a fix upon 6e7686c030fab162edb3128de005ec00ea8c0ffc.
This correctly deletes the list even if the windows are still referenced
and even if they are deleted from under out feets.
Summary:
Setting layer of a smart member is not required as it would remain
on same layer of slider.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1447
This reverts commits 123ca6a8744729525889bbc09ee1aff4b2b97b75, 0d527b03f4f630e81ab4480d7160bbf6352b0bac
this is still unusable even after being fixed so the fix was unnecessary to begin with
Summary:
Right now we cannot have a designated build directory and we should build in the source directory. So the proposed solution lets you to build from any directory.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: raster, cedric
Differential Revision: https://phab.enlightenment.org/D1395
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
ecore_x, ecore_wl, ecore_drm etc. were being linked to clients as they
were added to the pc file - they should not have been. elm hides
these. it's meant to hide them. remove them from the pc file.
Summary:
Changed the text for Radio "changed" event to:
This is called when the radio object is selected.
Signed-off-by: Srivardhan Hebbar <sri.hebbar@samsung.com>
Reviewers: stefan_schmidt, seoz
Reviewed By: stefan_schmidt, seoz
Subscribers: stefan_schmidt
Maniphest Tasks: T1657
Differential Revision: https://phab.enlightenment.org/D1445
The scale is used for the application to be scaled.
If the application isn't made on the basis of scale 1.0,
the application layout will be scaled inappositely. So if the
application set the base scale, it is applied when the application is scaled.
this should have been done with the module rename, and this release is the last chance to get it fixed before it has to be permanently maintained with wrong names
This was leading to never enter the cnp functions dedicated to Wayland,
as the given object was not a window. The Copy And Paste test was not
working for this reason.
Summary:
If item select callback is elm_genlist_clear and genlist object have many item, elm_genlist_clear was broken.
This reason is due to incorrect code. In Old code, check the item focus after an item was deleted. So, I changed the order of the code.
Before item was deleted, Check the item focus.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, SanghyeonLee, seoz
Reviewed By: seoz
Subscribers: bluezery, SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D1418
I'll reintroduce this in a moment, was just easier this way in order to
merge Vincent's changes.
This reverts commit d46fa601ef45d579d1448b19887d02ff2dfbb576.
Summary:
Label size is incorrectly calculated (text does not wrap) if
elm_label_line_wrap_set() is called before elm_label_wrap_width_set().
@fix
Test Plan:
The label3 test case is added to show the bug case.
In label3 test case, if we switch the calling sequence of
elm_label_line_wrap_set() and elm_label_wrap_width_set(),
the result is different.
Reviewers: raster, seoz, woohyun, Hermet
Differential Revision: https://phab.enlightenment.org/D1369
Summary: Removed all global variables for item class
Reviewers: zmike, raster, seoz
Maniphest Tasks: T1482
Differential Revision: https://phab.enlightenment.org/D1318
Summary:
If gengrid select mode is not ELM_OBJECT_SELECT_MODE_ALWAYS, ELM_OBJECT_SELECT_MODE_ALWAYS mode for
elm_genlist_item_select_mode was broken. In the item select routine, item mode(it->mode) was not checked.
So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1372
This completely breaks automatic UI mirroring. The code there was
correct. Please, before removing code, contact the original author and
make sure you don't break things down. Especially if your reason for
removing is "this doesn't make sense to me" instead of "this breaks X
Y."
This reverts commit 24983fed239a3b37c05cc3c65ed9c56953a7176b.
thre are still all the old engines supported inside, but docs dont say
so so effectively deprecated. also handle a NULL engine. this is part
of our engine/display system cleanup.
Summary:
elm_widget calls _item_del_pre_hook of each widget and widget can
decide item deletion by return type. But gengrid and popup widget implemented
those _item_del_pre_hook function as a void type.
So this commit fixs the return types to Eina_Bool and changes gengrid widget to return EINA_FALSE when
the item wants to be deleted later.
And when the item wants to be deleted directly, it returns EINA_TRUE.
@fix
Test Plan: test in demo.
Reviewers: seoz, raster, bluezery
Subscribers: Hermet, jaehwan
Differential Revision: https://phab.enlightenment.org/D872
now that we have ELM_DISPLAY and ELM_ACCEL we have little need for a
lot of the elm engine stuff and frankly a lot was broken if you used
multiple engines etc. so this fixes a lot of it nd removes a lot of
cruft. i think i got it all right, but i may have oppsied. this also
remo9ves engine support for engines long gone from evas.
Summary:
ELM_OBJECT_SELECT_MODE_ALWAYS mode for elm_genlist_item_select_mode
was broken. In the item select routine, item mode(it->mode) was not
checked. So, I added the check routine there.
@fix
Test Plan: I revised the elementary_test code and tested with that.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: SanghyeonLee, bluezery
Differential Revision: https://phab.enlightenment.org/D1347
This reverts commit 2e2d003efeded27955cc9301279cd3a0d362f548.
Revert this patch to leave the credit to Andrii Kroitor.
I will fix this correctly in the next commit.
Sorry Andrii for the wrong review comments that can break compatibility.
But actually it was not documented at all so there was no problem.
Just to please hermet, let's not do more.
This reverts commit a2afbe91e851f3d943736d2a1aae9e2721d1a0d5.
definitely this will break compatibility.
and as i mentioned, we should prevent as possible that
until there are other methods.
Mike Blumenkrantz
Daniel Juyung Seo
Wonguk Jeong
Anil Kumar Nahak
Lukasz Stanislawski
Jaehyun Cho
Stefan Schmidt
Anand
ChunEon Park
woochan lee
zmike
Daniel Zaoui
Vitalii Vorobiov
Amitesh Singh
Brian 'morlenxus' Miculcy
Hosang Kim
Igor Murzov
Andrii Kroitor
Stefan Schmidt
Youngbok Shin
shilpa.singh
Carsten Haitzler
Tae-Hwan Kim
Cedric BAIL
artem.popov
Kateryna Fesyna
Thiep Ha
Ryuan Choi
Adrien Nader
Tom Hacohen
Jean-Philippe Andre
Jihoon Kim
maxerba
Boris Faure
Jaehwan Kim
Srivardhan Hebbar
Savio Sena
Kai Huuhko
Daniel Kolesa
Kai Huuhko
Jae Yong Hwang
Vincent Torri
kabeer khan
Vincent Torri
Jaeun Choi
yinsc
SangHyeon Lee
Jérémy Zurcher