Subject: [E-devel] [Edje]: Bug Fix: Edje draggable jumps when external
events is used.
Please find attached bug fix patch for edje draggable jump issue when
external event area is used.
Bug: When an external event area is used for edje draggable and when
after mouse move if immediate mouse down
is done then the draggable jumps back to its original position.
Analysis: In _edje_mouse_down_signal_cb When an external event area
is set i.e., when rp->events_to is set.
tmp.x value is set to 0, need_reset is set to 1 and also
_edje_recalc_do is called including emitting "drag" signal. this code
is
unnecessary/buggy and instead it causes the jump.
1. In mouse down only drag->down.x and drag->down.y needs to be set
which is being set below and tmp value need not be reset to
0 as tmp value is calculated in mouse move based on drag->down.x and
drag->down.y values.
2. need_reset is already set in mouse up hence need not be set in
mouse down again.
3. edje_recalc_do is the function which actually causes the movement
of draggable based on tmp value hence need not be called in mouse down.
because of the above code race condition happens and as tmp value is
being set to 0 and need reset is also enabled the draggable jumps back
to where it
started.
4. "drag": is sent even before "drag,start" [ should not /need not be
sent in mouse down ]
All the above code is added only when external event area is set and
the above code is not even related to whether external event is set or
not.
Solution: When an external event area is set directly equating rp =
rp->events_to and sending mouse,down would be enough, as down.x and
down.y is set below
including sending drag,start. Recalc_do should be called only in mouse
move as its responsible for movement including setting tmp value.
need_reset is already set in mouse up. drag should not be sent from
mouse down.
Change Description:
Bug Fix: Edje Draggable jumps when mouse down is done immediately
after mouse move when an external
event area is used.
demo edc pasted below to reproduce the issue.
Please find attached bug fix patch for edje draggable jump issue when external event area is used.
Bug: When an external event area is used for edje draggable and when after mouse move if immediate mouse down
is done then the draggable jumps back to its original position.
Analysis: In _edje_mouse_down_signal_cb When an external event area is set i.e., when rp->events_to is set.
tmp.x value is set to 0, need_reset is set to 1 and also _edje_recalc_do is called including emitting "drag" signal. this code is
unnecessary/buggy and instead it causes the jump.
1. In mouse down only drag->down.x and drag->down.y needs to be set which is being set below and tmp value need not be reset to
0 as tmp value is calculated in mouse move based on drag->down.x and drag->down.y values.
2. need_reset is already set in mouse up hence need not be set in mouse down again.
3. edje_recalc_do is the function which actually causes the movement of draggable based on tmp value hence need not be called in mouse down.
because of the above code race condition happens and as tmp value is being set to 0 and need reset is also enabled the draggable jumps back to where it
started.
4. "drag": is sent even before "drag,start" [ should not /need not be sent in mouse down ]
All the above code is added only when external event area is set and the above code is not even related to whether external event is set or not.
Solution: When an external event area is set directly equating rp = rp->events_to and sending mouse,down would be enough, as down.x and down.y is set below
including sending drag,start. Recalc_do should be called only in mouse move as its responsible for movement including setting tmp value. need_reset is already set in mouse up. drag should not be sent from mouse down.
Change Description:
Bug Fix: Edje Draggable jumps when mouse down is done immediately after mouse move when an external
event area is used.
demo edc pasted below to reproduce the issue.
Please find attached bug fix patch for edje draggable jump issue when
external event area is used.
Bug: When an external event area is used for edje draggable and when
after mouse move if immediate mouse down
is done then the draggable jumps back to its original position.
Analysis: In _edje_mouse_down_signal_cb When an external event area
is set i.e., when rp->events_to is set.
tmp.x value is set to 0, need_reset is set to 1 and also
_edje_recalc_do is called including emitting "drag" signal. this code
is
unnecessary/buggy and instead it causes the jump.
1. In mouse down only drag->down.x and drag->down.y needs to be set
which is being set below and tmp value need not be reset to
0 as tmp value is calculated in mouse move based on drag->down.x and
drag->down.y values.
2. need_reset is already set in mouse up hence need not be set in
mouse down again.
3. edje_recalc_do is the function which actually causes the movement
of draggable based on tmp value hence need not be called in mouse down.
because of the above code race condition happens and as tmp value is
being set to 0 and need reset is also enabled the draggable jumps back
to where it
started.
4. "drag": is sent even before "drag,start" [ should not /need not be
sent in mouse down ]
All the above code is added only when external event area is set and
the above code is not even related to whether external event is set or
not.
Solution: When an external event area is set directly equating rp =
rp->events_to and sending mouse,down would be enough, as down.x and
down.y is set below
including sending drag,start. Recalc_do should be called only in mouse
move as its responsible for movement including setting tmp value.
need_reset is already set in mouse up. drag should not be sent from
mouse down.
Change Description:
Bug Fix: Edje Draggable jumps when mouse down is done immediately
after mouse move when an external
event area is used.
demo edc pasted below to reproduce the issue.
Please find attached bug fix patch for edje draggable jump issue when external event area is used.
Bug: When an external event area is used for edje draggable and when after mouse move if immediate mouse down
is done then the draggable jumps back to its original position.
Analysis: In _edje_mouse_down_signal_cb When an external event area is set i.e., when rp->events_to is set.
tmp.x value is set to 0, need_reset is set to 1 and also _edje_recalc_do is called including emitting "drag" signal. this code is
unnecessary/buggy and instead it causes the jump.
1. In mouse down only drag->down.x and drag->down.y needs to be set which is being set below and tmp value need not be reset to
0 as tmp value is calculated in mouse move based on drag->down.x and drag->down.y values.
2. need_reset is already set in mouse up hence need not be set in mouse down again.
3. edje_recalc_do is the function which actually causes the movement of draggable based on tmp value hence need not be called in mouse down.
because of the above code race condition happens and as tmp value is being set to 0 and need reset is also enabled the draggable jumps back to where it
started.
4. "drag": is sent even before "drag,start" [ should not /need not be sent in mouse down ]
All the above code is added only when external event area is set and the above code is not even related to whether external event is set or not.
Solution: When an external event area is set directly equating rp = rp->events_to and sending mouse,down would be enough, as down.x and down.y is set below
including sending drag,start. Recalc_do should be called only in mouse move as its responsible for movement including setting tmp value. need_reset is already set in mouse up. drag should not be sent from mouse down.
Change Description:
Bug Fix: Edje Draggable jumps when mouse down is done immediately after mouse move when an external
event area is used.
SVN revision: 71277
NOTE: know issue, in elementary_config the size of the icon
change after a theme reload. I don't know what information is
lost between to reload. If someone can point at them, thanks.
SVN revision: 71235
NOTE: as librsvg is a massive source of bugs in e17, it is now
removed from evas. You can still use librsvg by using the
evas_generic_loader. Please not that you need to properly delete
it from your disk if you don't use a package manager. The file to
remove :
/*/lib/evas/modules/loaders/svg/linux-gnu-i686-1.2.*/module.so
SVN revision: 71223
Now evas will in all case do the layout during the prepare stage. It will do that
once and as long as the text didn't change. This does improve by a factor of at
least 2.3 in all expedite test case except the text change that only get a 30%
increase (I expect a drop in performance on non pipe rendering for text change
expedite test only, but this case is not common in real life).
This also fix the issue that show random size glyph when using pipe rendering.
SVN revision: 71220
There is no automatic promotion of unsigned to unsigned long when using va_arg,
which means it is illegal to pass an 'unsigned' value and then use it as an
unsigned long in eina_arg_vset. Doing so yields incorrect results on some
architectures like itanium
Patch by Albin 'Lutin' Tonnerre <albin.tonnerre@gmail.com>
SVN revision: 71196
The eina_value code TYPE_CHAR conversion code assumes that 'char' is a signed
type, which is not true on some platforms like ARM and PPC. We need to
explicitely use signed chars to make sure the value is correct.
Patch by Albin 'Lutin' Tonnerre <albin.tonnerre@gmail.com>
SVN revision: 71195
supports FreeBSD >= 7 these days), so the check for __FreeBSD_version >=
420001 is not necessary anymore (plus it probably never worked, as that
macro is defined in sys/param.h, which is not included prior to the
check).
Patch by Raphael Kubo da Costa
SVN revision: 71172
glyph metrics.
Instead of having to render the glyph to get the width and horizontal
bearing of it, it's possible to get this information from the glyph
metrics (which are available on the glyph slot).
This change now allows Evas to only render the glyph at the rendering
phase, instead of having to render it during layout phase.
SVN revision: 71132
(-fastcomp and -fastdecomp) -fastcomp makes for faster decompressing
AND faster compressing of edj files, -fastdecomp is a bit slower on
compression but also as fast as -fastcomp in decompression. note that
edje files built with these optiosn will not work on older edje
installations, thus they are options.
SVN revision: 71112
in wayland compositors. Added alpha support for wayland_egl. Support
evas output rotation in wayland_egl. Don't move/resize windows in
wayland_egl unless sizes actually change. Included patch from Robert
Bradford <robert.bradford@intel.com> for vertical/horizontal mouse
wheel scrolling.
SVN revision: 71108
This commit also includes patch(s) from Robert Bradford
<robert.bradford@intel.com> for Supporting vertical/horizontal
scrolling, and updates to wayland fixed point for input events.
Fix ecore_wl_input to use new libxkbcommon api.
Add new surface_enter/leave listener for ecore_wl_window.
SVN revision: 71107
This is in preperation of a future change to be able to set errors in
function calls as well, and not just constructors.
Also, I improved the error reporting.
SVN revision: 71000
Currently, this feature is only supported in EGL/GLESv2 environment
with GL_IMG_multisampled_render_to_texture extension supported.
_____________________
from: (sanghee park) sh15.park@samsung.com
Dear all,
I compose this mail to ask reviewal this patch about multisampling on the evasgl.
I want to make multisampling capacity to enhance rendering quality of the evasgl.
But if MSAA is applied always, this have possibility lowering rendering performance,
I separated user's input level to high, mid, low, none.
If you want to test this patch, try to examine rendering qulity on EGL circumstance with multisampling level.
Plaese review it, and any suggestion will be appreciated.
Best Regards,
SangHee
SVN revision: 70992
Subject: [E-devel] [PATCH][EDJE] Patch to remove the alpha from image
header while saving if the alpha is set to 1 but the image is fully
opaque
Attached to the mail is a patch to set the alpha information for an
image header to 0 with alpha present but all the texels being opaque.
Continuing to our discussion, as suggested by many people in the
community it has been implemented at edje_cc level.
Change description:
While compiling the edc file, image data for image files is
scanned to find out whether the alpha value in header is set to 1 and
is not being used in the image.
If this is the case, while writing to eet the alpha is set to 0 to
avoid blending for such images in the graphics pipeline when used by
evas.
SVN revision: 70954
- Cleanup cache2 things on shutdown
- Use Eina_File instead of straight shm_open + mmap when loading things from cserve2
- Do free the mapped images when we don't need them
SVN revision: 70936
As we move back and forth from double to fixed point, we do
have some rounding error. I am trying to limit them at much as
possible by reducing the number of computation in double.
SVN revision: 70905
NOTE: now you can change theme dynamically in elementary apps more reliably.
This doesn't handle the case where the swallow was done in a parent object and
the reswallow should happen in a another group. I don't how to fix that use
case.
don't see yet how to handle that
SVN revision: 70901
For the moment only edje_player use it. This means that when used with
edje_watch, you don't need any more to type any kind of command line
when you are testing value in your theme. As a side effect, this means
that their is a real use case to make edje_cc faster !
SVN revision: 70890
edje_watch call edje_cc and monitor all the source file (edc, font
image, sound). If any of them change, it call edje_cc, update its
watching list and so on. edje_watch as the same command line as
edje_cc.
Still a little bit rought, but it's the beginning of an interesting
experiment.
SVN revision: 70872
Mainly, glDeleteBuffers was being called instead of glDeleteRenderbuffers.
Also, there was an error when checking if surface is valid.
SVN revision: 70870
Hello.
Just 3 small fixes to get our warning count down. The tempget one
should actually save us against wrong reads.
Also a small DSO fix reported and confirmed in IRC.
Please review and apply.
regards
Stefan Schmidt
Submitted-By-Off: Stefan Schmidt<stefan@datenfreihafen.org>
SVN revision: 70759
now seriously...
Introducing Cache Serve 2.
This cache server will initially load images for clients connected to
it. It starts slave processes to load these images, and share the loaded
images through shm with the clients. All the connection done between
clients and the server goes through sockets.
The cserve2 build option is turned on by default, while the old cserve
was disabled, but in order to make clients use it, the environment
variable EVAS_CSERVE2 must be set, and a server must be running.
Clients will try to find the socket on a specified location using the
environment variable EVAS_CSERVE2_SOCKET. If it's not defined, then the
XDG_RUNTIME_DIR path should be used, and finally HOME, TMPDIR and /tmp.
SVN revision: 70699
(Trying it again since this commit broke evas build yesterday.)
Previously, evas_gl_surface_create() didn't actually do
the render buffer attach to the the FBO. It was performed when
the make_current was called for the first time. The issue
was that even though the surface was successfully created with
the given configuration, there was a possibility of make_current
failing with the error message "FBO not complete" because of
the surface configuration.
So, I've added a piece of code that checks the FBO
capabilities beforehand to set up a available surface configurations
so that it doesn't have to fail during make_current for unsupported
surface format.
Also, I've changed the surface config in a way that once the
user calls evas_gl_surface_create(), evas gl sets the config
parameter with configuration that evas_gl is actually using.
SVN revision: 70680
Complete support for keyboard events. Thank You :)
NB: This is a modified patch from what Rob originally sent. This fixes
formatting, uint32_t types, function name, and other such things ;)
SVN revision: 70672
Previously, evas_gl_surface_create() didn't actually do
the render buffer attach to the the FBO. It was performed when
the make_current was called for the first time. The issue
was that even though the surface was successfully created with
the given configuration, there was a possibility of make_current
failing with the error message "FBO not complete" because of
the surface configuration.
So, I've added a piece of code that checks the FBO
capabilities beforehand to set up a available surface configurations
so that it doesn't have to fail during make_current for unsupported
surface format.
Also, I've changed the surface config in a way that once the
user calls evas_gl_surface_create(), evas gl sets the config
parameter with configuration that evas_gl is actually using.
SVN revision: 70617
This make it possible to use the object tree to reduce the number of object, we need to explore to know
what is under a specific position. First used by propagation event code. That code is now 4 times faster, enjoy !
As a side cost evas_object_move goes from 925 to 980 valgrind cycle on my computer, so not something you
will notice.
NOTE: if you notice any breakage regarding event propagation, map, cats, minor or major, please report to
me ! I hope I didn't loose my mojo, with such a scary change, I have a big chance to get it back !
SVN revision: 70564
Subject: [E-devel] [patch] missing doxygen files in release tarballs
This patch add to EXTRA_DIST essential files for doxygen
small build fix:
SVN revision: 70514
NOTE: This should be part of evas_render itself and not
delegated to the engine. So cleaning things to make it easier
during evas_render rewrite.
SVN revision: 70503
Note: this two were broken. Current plan to bring
that feature back in, is to attach this information
to Evas_Text_Prop during the prepare stage. This
would improve both single and multiple core rendering
without increasing the number of lock and the complexity
of the code.
SVN revision: 70501
NOTE: other things that may join it in the near futur EVAS_FRAME_QUEUE,
EVAS_METRIC_CACHE and maybe EVAS_WORD_CACHE also. This is all part of
cleaning up our rendering path so we can actually improve it more easily.
SVN revision: 70499
clients not moving or resizing properly with most recent git wayland.
Make use of wayland's new 'serial' stuff in place of timestamps (where
appropriate). Add code to handle new wayland 'ping' events.
SVN revision: 70443
eobj_event_callback_del -> eobj_event_callback_del_lazy.
eobj_event_callback_del_full -> eobj_event_callback_del.
Thanks to cedric for the suggestion.
SVN revision: 70435
It seems that libcheck keeps some reachable data, unfortunate as it makes
it very annoying for us to check for reachable memory in our code, but
letting valgrind report about it is just too damn annoying.
SVN revision: 70412
This macro makes the code a tad simpler, but more importantly, makes it
easier for us to be thread safe, or more corrctly, easier for us the
make user code thread safe.
SVN revision: 70407
Subject: [E-devel] [patch] eina_simple_xml example
Here is an example for eina_simple_xml
This patch includes a small sample XML file, source code (for parsing and
printing it out) and the doxygen doc.
SVN revision: 70385
NOTE: some of this function should be moved as inline, but that's to late for a change
I think. So we will fix that if needed.
Second point, I am not happy with is eina_inarray_insert and eina_inarray_insert_at. The
naming is really poor.
SVN revision: 70352
Subject: Re: [E-devel] [Patch][Ecore][Win32] Checking control character
I missed the updating WinCE. and..
Mr. Vincent Torri enlighten me about ChangeLog and NEWS also. Thanks!
SVN revision: 70219
(idx, ## __VA_ARGS__) is a gnu extension, fixed to be (__VA_ARGS__).
Should be fine this way. Less descriptive maybe, because now people will
may think it's ok to pass 0 arguments, but there's no avoiding this.
SVN revision: 70194
Subject: [E-devel] [Patch][Ecore][Win32] Checking control character
The control characters are generated by holding down the Control key while
you strike another letter or symbol key.
Because of this reason, The Evas_Event_Key_Down in the
EVAS_CALLBACK_KEY_DOWN callback does not have proper keyname.
So I have shifted the control character to printing character. Please
review the patch and give any feedbacks. Thanks.
SVN revision: 70186
People, when you go and change ecore_event_add() to
_ecore_event_add(), please NOTICE THAT THE FREE FUNCTION IS NOT
AUTOMATICALLY SPECIFIED!
So specify these functions to _ecore_event_add() to stop leaking every
signal we receive from system.
SVN revision: 70177
This saves us from having to call the data_get function. This makes the
code nicer and potentially faster.
Thanks to raster for the tip.
SVN revision: 70145
Subject: [E-devel] [patch] ecore doxygen doc (3)
Date: Thu, 12 Apr 2012 15:39:16 +0900
Some leftovers, fix:
/tmp/ecore/src/lib/ecore_x/xlib/ecore_x_randr_12.c:1202: warning: The following parameters of ecore_x_randr_crtc_pos_relative_set(Ecore_X_Window root, Ecore_X_Randr_Crtc crtc_r1, Ecore_X_Randr_Crtc crtc_r2, Ecore_X_Randr_Output_Policy policy, Ecore_X_Randr_Relative_Alignment alignment) are not documented:
parameter 'root'
/tmp/ecore/src/lib/ecore_x/xcb/ecore_xcb_randr.c:921: warning: The following parameters of ecore_x_randr_mode_size_get(Ecore_X_Window root, Ecore_X_Randr_Mode mode, int *w, int *h) are not documented:
parameter 'root'
/tmp/ecore/doc/examples.dox:242: warning: unable to resolve reference to `ecore_event_example.c' for \ref command
SVN revision: 70119
Subject: [E-devel] [patch] ecore doxygen doc (2)
Date: Thu, 12 Apr 2012 12:46:04 +0900
Hi,
This is a big patch. It fixes:
- undef #EINA_{TRUE,FALSE} links
- @c for NULL and EINA_{TRUE,FALSE}
- some formatting/spello
- several missing return types
SVN revision: 70117
pointer grabs, shm_pool interface. Rename fields of the
wl_event_mouse_in/out structures to match other ecore event structs.
Add API functions for getting a list of outputs, for getting a windows
shell_surface, and for setting a windows parent.
SVN revision: 69997
documentation.
I didn't add the API declaration into the header yet because the API
name/parameter might be changed before release.
SVN revision: 69990
Subject: [E-devel] [patch] edje multisense example
Here is a try to have a working edje multisense example to fill up the
doc blank. edje-multisense.c is basically edje_example.c adapted.
I modified the edc, removing dead code, to have only a sample and a tone
example. Can be extended later.
Does the job except that it only plays sound one time per launch. Hope
someone will know why and correct it...
Attached:
- the patch for existing .edc and build system
- the new edje-multisense.c file
- duck.wav a reworked public domain wav sample of a duck quack-quack
SVN revision: 69962
Attached patch fixes a bunch of warnings in evas doc:
- Make remaining EINA_{TRUE,FALSE} @c, removing some undef link in same
time
- Make remaining NULL @c
- Fix the color space list
- small random fix
SVN revision: 69956
Due typo the weight was being handled as an integer, not floating
point. It worked with examples since they were usually being round to
int after being sum (0.3 + 0.7 -> 1.0, 3 + 7 -> 10).
SVN revision: 69910
warning: Tag `DETAILS_AT_TOP' at line 163 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
/tmp/ethumb/src/lib/client/ethumb_client.c:1597: warning: argument 'f' of command @param is not found in the argument list of ethumb_client_orientation_set(Ethumb_Client *client, Ethumb_Thumb_Orientation o)
/tmp/ethumb/src/lib/client/ethumb_client.c:1597: warning: The following parameters of ethumb_client_orientation_set(Ethumb_Client *client, Ethumb_Thumb_Orientation o) are not documented:
parameter 'o'
/tmp/ethumb/src/lib/client/ethumb_client.c:1752: warning: return type of member ethumb_client_frame_set is not documented
Patch by Jérôme Pinot
SVN revision: 69826
warning: Tag `DETAILS_AT_TOP' at line 15 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: Tag `MAX_DOT_GRAPH_HEIGHT' at line 94 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: Tag `MAX_DOT_GRAPH_WIDTH' at line 95 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
/tmp/eeze/src/lib/Eeze.h:313: warning: argument 'etype' of command @param is not found in the argument list of eeze_udev_find_by_type(Eeze_Udev_Type type, const char *name)
/tmp/eeze/src/lib/Eeze.h:314: warning: explicit link request to 'NULL' could not be resolved
/tmp/eeze/src/lib/Eeze.h:315: warning: explicit link request to 'NULL' could not be resolved
/tmp/eeze/src/lib/Eeze.h:313: warning: The following parameters of eeze_udev_find_by_type(Eeze_Udev_Type type, const char *name) are not documented:
parameter 'type'
Patch by Jérôme Pinot, modified by myself
SVN revision: 69825
warning: Tag `DETAILS_AT_TOP' at line 46 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: Tag `MAX_DOT_GRAPH_WIDTH' at line 137 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: Tag `MAX_DOT_GRAPH_HEIGHT' at line 138 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: tag INPUT: input source `emotion.dox' does not exist
warning: source emotion.dox is not a readable file or directory... skipping.
/tmp/emotion/src/lib/Emotion.h:1232: warning: missing title after \defgroup Emotion_Webcam
/tmp/emotion/src/lib/Emotion.h:819: warning: The following parameters of emotion_object_size_get(const Evas_Object *obj, int *iw, int *ih) are not documented:
parameter 'ih'
Patch by Jérôme Pinot
SVN revision: 69824
Subject: [E-devel] [patch] ecore doxygen doc
Here is a patch to correct some problems in ecore doxygen doc.
It fixes:
/tmp/ecore/doc/examples.dox:1173: warning: Unsupported xml/html tag
<some_num> found
/tmp/ecore/doc/examples.dox:1174: warning: Unsupported xml/html tag
<some_path> found
/tmp/ecore/doc/examples.dox:1176: warning: Unsupported xml/html tag
<some_num> found
/tmp/ecore/src/lib/ecore_con/ecore_con_ssl.c:714: warning: The
following parameters of
ecore_con_ssl_server_privkey_add(Ecore_Con_Server *svr, const char
*key_file) are not documented:
parameter 'svr'
/tmp/ecore/src/lib/ecore_con/Ecore_Con.h:1360: warning: The
following parameters of ecore_con_url_http_version_set(Ecore_Con_Url
*url_con, Ecore_Con_Url_Http_Version version) are not documented:
parameter 'url_con'
/tmp/ecore/src/lib/ecore_evas/Ecore_Evas.h:530: warning: argument
'demand_attention' of command @param is not found in the argument list
of ecore_evas_demand_attention_set(Ecore_Evas *ee, Eina_Bool demand)
/tmp/ecore/src/lib/ecore_evas/Ecore_Evas.h:530: warning: The following
parameters of ecore_evas_demand_attention_set(Ecore_Evas *ee,
Eina_Bool demand) are not documented:
parameter 'demand'
/tmp/ecore/src/lib/ecore_x/xcb/ecore_xcb_damage.c:129: warning:
Unsupported xml/html tag <empty> found
There are more things to fix due to API change but it's not so obvious
for me. I will first continue to check/correct trivial things in the
others efl doxygen doc.
SVN revision: 69820
There is a reference to evas-load-error-str.c in
the evas_load_error_str doc, but this file doesn't exist
anymore so I made the doc link to evas-images.c which use
several times this function.
SVN revision: 69754
Subject: [E-devel] [patch] evas doxygen doc (1)
There are a lot of small things to fix in the evas doc. Here is a first
batch. Fixes are trivial and obvious. Just a question about the first
hunk, I removed the <tdb> that replaced valid email for companies
because it makes doxygen complain about the unknown tag and, well, it
doesn't give any information either. Was there an explanation about
adding this ?
Joined is the patch along with the doc build log diff.
SVN revision: 69749
Subject: [E-devel] [patch] eina doxygen doc
Here is a patch that fix several links in the eina doxygen doc. Most of
the problems come from unescaped special characters.
SVN revision: 69746
The doxyfile of evas contains some variables that have been deprecated a
long time ago (6 years for some of them). Here is a patch that fix this
build warning:
make -C doc doc
make[1]: Entering directory `/tmp/evas/doc'
rm -rf html/ latex/ man/ xml/ evas-1.2.0-alpha-doc.tar*
doxygen
warning: Tag `DETAILS_AT_TOP' at line 44 of file Doxyfile has become obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: Tag `MAX_DOT_GRAPH_WIDTH' at line 135 of file Doxyfile has become
obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
warning: Tag `MAX_DOT_GRAPH_HEIGHT' at line 136 of file Doxyfile has become
obsolete.
To avoid this warning please update your configuration file using "doxygen -u"
As suggested, it would be good to run again doxygen -u Doxyfile.in
SVN revision: 69740
I found a bug in ecore main loop while debuging cpu 100% issue on RSS
application.
1. [RSS] RSS application register two io watch callbacks(for G_IO_IN,
G_IO_OUT seperately) for a GIOChannel with g_io_add_watch().
2. [ecore] In _ecore_glib_context_query() function, g_main_context_query()
returns a fd list, and it has 2 fd items for the GIOChannel (channel
id = 20).
itr[0] (16, 1, 0)
itr[1] (15, 1, 0)
itr[2] (20, 1, 0) (G_IO_IN, 0)
itr[3] (20, 4, 0) (G_IO_OUT, 0)
itr[4] (18, 1, 0)
3. [ecore] In _ecore_glib_context_poll_from() function, create read, write,
exception fd list according to the events flags of each fd item.
[6 15 16 18 20], [20], []
4. [ecore] in _ecore_glib_select__locked() function, get active fd number from
select() call
select(21, [6 15 16 18 20], [20], [], NULL) = 1 (out [20])
5. [ecore] In _ecore_glib_context_poll_to() function, there is a bug on
setting revents flag.
(because of incorrect condition check - currently, the logic of the
function cannot handle this case)
itr[0] (16, 1, 0)
itr[1] (15, 1, 0)
itr[2] (20, 1, 4) (set incorrectly)
itr[3] (20, 4, 0) => this should be set as (20, 4, 4)!!!!
itr[4] (18, 1, 0)
6. [ecore] In _ecore_glib_select__locked(), g_main_context_check() function
returns false because of the above bug, so g_main_context_dispatch()
function will not be called.
>> After this, the 2~6 flow is executed repeatedly on ecore main loop
(because 20 out is still active fd) and this makes cpu 100% problem.
SVN revision: 69739
Fix ecore_wl_window surface attach of the buffer for shm and egl types.
NB: This ensures that both efl/elm clients work under the Wayland
Compositor AND the E17 Compositor.
NB: The issue here is that clients (when run under the Wayland
compositor) need to make sure 'iterate' has
been called before creating surfaces so that the wl_compositor is
setup. However, the actual E17 Compositor will hang if 'iterate' is called
to early.
SVN revision: 69707
Handle 'axis' events from multi-touch devices (also handles mouse
wheel).
Remove wl_buffer_damage calls (obsolete in newest wayland).
NB: This will require the 'latest' wayland code from their git repo as
of 2012-03-27.
SVN revision: 69672
- Comment out display_iterate during intialize (hangs compositor
initialize).
- Simplify ecore_wl_flush routine and avoid possible hangs in
wl_display_roundtrip.
- Add function (for trip ;) ) to be able to return the screen dpi.
- Implement functions for input grab/ungrab.
- Set root.x/y in mouse events.
- Remove freeing of mouse_move event (already handled generically).
- Handle setting output mm width/height (for calc of dpi).
- Implement setting surface input & opaque regions.
- Implement popup windows.
- Implement ecore_wl_window_transparent_set function.
- Implement function to allow setting Ecore_Wl_Window type.
- Implement setting the wayland mouse pointer to an image (via
ecore_wl_window_pointer_set).
- Comment out wl_display_iterate during initialize (can cause hangs in
compositor).
- Simplify ecore_wl_flush (to avoid compositor hangs).
SVN revision: 69644
This works in linux, and should fix shm_detection on BSD (including Mac)
BSD, Mac and solaris users : please check that it compiles and shm_open is detected
SVN revision: 69618
This works in linux and windows, and should fix shm_detection on BSD (including Mac)
BSD, Mac and solaris users : please check that it compiles and shm_open is detected
SVN revision: 69616
This works in linux and windows, and should fix shm_detection on BSD (including Mac)
BSD, Mac and solaris users : please check that it compiles and shm_open is detected
SVN revision: 69612
This works in linux and windows, and should fix shm_detection on BSD (including Mac)
BSD, Mac and solaris users : please check that it compiles and shm_open is detected
SVN revision: 69608
Subject: [E-devel] [PATCH] ecore/ecore_fb: Tweaks in _ecore_fb_size_get
As the width and height are defined as static, no need to initialize it
again to zero. Also removed checks for 'valid pointers' as it is redundant.
SVN revision: 69556
Subject: [E-devel] [Patch][ecore_con] Simple bug fix
Date: Mon, 12 Mar 2012 13:45:02 +0900
Hello,
This is patch to prevent a segfault if curlmsg == NULL.
Thanks.
SVN revision: 69217
Subject: [E-devel] [Patch][Eina] eina_file_win32 - using
eina_file_statat();
On windows, Elementary gives build error. cause..
The elm_config.c uses eina_file_statat(); but It is not in the
eina_file_win32.c
So the attached patch comes. Please keep the patch in the up stream.
Thanks.
SVN revision: 69058
(interfaces_bound) to be raised when ecore_wayland has everything it
needs to function properly. (Used in the e17 wayland only code).
SVN revision: 69032
NOTE: I am now all for removing this lock. They trigger crash,
are not implementing the feature they are advertising, are not
maintained and impossible to fix.
SVN revision: 68987
Subject: [E-devel] [Patch] Ecore, Elementary: Supporting indicator
opacity mode
This is Myoungwoon Roy Kim.
This patches are for supporting the indicator's opacity mode and made by
Jeonhoon Park(jh1979.park@samsung.com) who is responsible for Indicator
application.
Requirements:
- In mobile device, Indicator area should be displayed as Opacity,
Transparency, or sometimes Translucency according to the UX
requirements.
This requirement can be applied in case of fullscreen based menu and
fullscreen applications like video player etc.
Functional requirements:
1. User can set indicator's opacity mode as opacity, transparency, and
translucency
2. User can get the current indicator's opacity mode.
Currently there are no APIs for supporting the upper functional
requirements.
Thus, he added support for indicator's opacity mode.
It is designed for EFL developers easily to set the indicator's opacity
like the existing indicator's mode.
He added a Elm_Win_Indicator_Opacity_Mode structure variable into
Elm_Win
structure.
Meanwhile, new two APIs are implemented independently from the existing
source code.
Anybody please review this and apply it to upstream code.
SVN revision: 68958
Subject: [E-devel] Emotion buffer size patch
Hi, here is a patch for emotion, it add a new function to retrive the
status of the buffer while playing online stream.
It is implemented only for the gstreamer backend, the xine one
do not play at all here. What about the generic one?
(xine does play - i implameneted this with the xine module, and
generic is given a func that always returns 1.0 for now).
SVN revision: 68684