by making a job to delay population we play a race condition game with
initting of other bits of e. this means the comp may or may not have
been filled by the container layer winds before other internal events
and actions start making comp wins and setting layers. this means that
things like e_comp_win_find() for a con->layers[n].win may fail... as
this has yet to be added... and thus.. we crash in startup. it's a
race condition.
so this removed the delay job and makes population of the comp
explicit. it puts the population into the hnds of the e_main init
after a manager has been created and after a container is created, and
thus laer wins created, so it can walk the x window stack correctly,
but before anything else is done. this means that we will be properly
inited at this point without a race condition.
This is needed so that setxkbmap runs before we initialize the wayland
compositor So that wayland clients can use the proper keymap.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
* dnd canvas removed, dnd objects now drawn directly on compositor canvas
* dnd now correctly picks the top-most dnd-receiver location as its drop target instead of just using the first one in the list
* various other small changes to go along with this
* added a number of new e_comp functions and macros
* options for disabling effects on objects: this option does not currently have any effect
* all modules which used gadcon popups have been adjusted
* all modules which used input windows to detect close events for gadcon popups have been adjusted to use new popup autoclose functionality
* shelves are now always drawn on the compositor canvas, meaning objects will never get clipped by the shelf (ticket #1810)
* shelves no longer have an event object
SVN revision: 84060
* Move compositor to core, but letting the configuration there
* Rename all files and functions from e_mod_comp_* to e_comp_*
* Move the config dialogs to a new module named conf_comp. It still
uses a domain config, otherwise it would not pick the current
user's configuration. Maybe it would be wise to later on move these
options to e_config
* Fixup the wizard mess linking the header in the build tree in order
to be able to create the config. Since now it's in core, we don't
need to play linking games in the build system
I'm not sure if the wayland part works. It was not even building
previously so I'll let for who cares about this to actually test and
report bugs.
SVN revision: 82454
1. make idle fade timer work at all (dodnt work before)
2. fixes backlight status on e restart
3. fixes setting bl level on start
4. improves the compositor fade in/out effect by ALSO fading backlight
in and out... oh so much smoother now
5. fixes label in ui to be seconds, not minutes.
6. in order to make this all work - it adds a special screensaver
event inside of e that the screensaver subsystem generates based on
the real x one.
SVN revision: 80538
As I've said before, I'm attached a patch for minor bugs in the e17 again.
Please take a look at attached patch.
01. missing E_FREE(wev) if zone is null
File: src/bin/e_actions.c: 1467
Function: ACT_FN_GO_EDGE macro function
null check of zone and wev, it would be better to separate them.
02. dead code
File: src/bin/e_configure.c: 338
Function: _e_configure_efreet_desktop_update
03. array buf might be overwritten by "buf[i] = '\0'"
File: src/bin/e_eap_editor.c: 412
Function: _e_desktop_edit_user_local_desktop_filename_generate
04. missing null check
File: src/bin/e_fm.c
Function: e_fm2_icon_get: 2196
It would be better to check ic->info.file in e_fm2_icon_get
before passing to _e_fm2_file_is_edje because it doesn't check
null pointer.
05. array 'path' might be overwritten by "path[i + 1] = XXX"
File: src/bin/e_fm.c: 4299
Function: _e_fm2_uri_parse
06. missing null check
File: src/bin/e_fm_device.c: 468
Function: e_fm2_device_mount_find
If the null pointer is passed to e_fm2_device_mount_find,
then it attempt to compare string using strncmp without null
check.
e.g., e_fm2_path_set
-> real_path = _e_fm2_dev_path_map: this function could return null.
-> sd->realpath = real_path;
-> e_fm2_device_mount_find(sd->realpath)
07. missing free(fstrip)
File: src/bin/e_import_config_dialog.c: 34
Function: _import_edj_gen
08. missing _module_free(cfm)
File: src/bin/e_int_config_modules.c: 530
Function: _load_modules
09. missing free(class) in for loop
File: src/bin/e_int_menus.c: 1187
Function: _e_int_menus_clients_add_by_class
10. missing free(roots)
File: src/bin/e_main.c: 1646
Function: _e_main_screens_init
Actually only e_win_init function could return 0.
But I've added free to other codes for the consistency.
11. missing null check of 'es->cfg'
File: src/bin/e_shelf.c: 2583
Function: _e_shelf_bindings_add
'es->cfg' might be null. please look at e_shelf_position_calc.
12. no ect->category check before comparing string values
File: src/bin/e_theme.c: 387
Function: e_theme_config_remove
I'm not sure, but inner if block checks ect->category before
deleting a string.
13. missing E_FREE(wcb) in while loop
File: src/bin/e_widget_ilist.c: 146
Function: _queue_timer
14. dereferencing freed pointer 'entry'
File: src/modules/quickaccess/e_mod_quickaccess.c: 583
Function: _e_qa_event_border_remove_cb
15. missing E_FREE(trov)
File: src/modules/tiling/e_mod_tiling.c: 3106
Function: _do_transition_overlay
Thanks & Regards,
Gwanglim
SVN revision: 80231
Subject: Re: Re: Re: [E-devel] [RFC] Virtual desktop window profile
I've attached 4th patch. May the 4th be with you.
ecore patch has been merged with efl and all files are based on r80123.
Thanks & Regards,
Gwanglim
------- Original Message -------
Sender : Daniel Juyung Seo<seojuyung2@gmail.com>
Date : 2012-12-04 01:55 (GMT+09:00)
Title : Re: Re: [E-devel] [RFC] Virtual desktop window profile
It looks ok to me.
Sorry but can you re-generate the patch according to the recent ecore
merge to efl single tree?
Daniel Juyung Seo (SeoZ)
On Thu, Nov 29, 2012 at 12:29 AM, Gwanglim Lee <gl77.lee@samsung.com>
wrote:
Dear Raster and Daniel Juyung Seo,
I've attached 3rd patches and test_config according to your reviews.
These are based on r79782.
[elementary & ecore]
1. "profile,set" -> "profile,changed" - done
2. spaces after EINA_LIST_FOREACH - done
3. variable type - keep
4. author - done
5. removing deprecated marking in patch - done
6. add elm_win_available_profiles_get to test_config for the debugging
purpose - done
7. check whether a given profile is present in an available profiles.
otherwise window profile will be one of the item
in available profiles. - newly added thing to the elm_win
8. merge with EO - done. :(
Any comments would be appreciated.
SVN revision: 80216
NOTE: the new behaviour require a parent process,
here enlightenment_start, to watch over enlightenment.
It does use ptrace to monitor his child and track
what is going on. When a crash happen it ask gdb to
add the backtrace directly into .xsession-errors.
If you use systemd user session, you may want to offload
that work to systemd. You can do so, but don't forget to
pass -nopause to enlightenment when you start it.
WARNING: For all user, you will need to exit your
current session and start a fresh one for this new WBOD
to work at all. Just restarting Enlightenment will not
help you.
SVN revision: 78742
Now it's possible to do elm_win_add() from your e_modules and use all
elementary features instead of painful e_widgets.
We should consider this experimental, but after e17 is out we should
start to convert dialogs and such to elementary, eventually
deprecating e_widgets and the theme duplication.
NOTE: requires r74156 with elementary patch.
I'll send an email to the list with a simple patch to skel module to
demo this.
SVN revision: 74157
used). removed setting up and deletion of keybindings - now its in
normal keybindings config territory. set them up yourself. much more
solid now. happy.
SVN revision: 70552
it's own utility (as per raster's request/idea). Remove explicit
x_clags in Makefile.am(s) as they are no longer needed.
NB: I added some additional libs to the precache stuffs (even tho it's
not used right now). Also a newer e_main (more optimized).
NB: IF you are brave and want to test this, build evas w/ xcb, build
ecore w/ xcb, then rebuild E. Also, disable building opengl in both
evas & ecore (it's not ready for public consumption when paired w/ xcb).
SVN revision: 61680
and anything thats a child that it launches) with... a GUI.. for all
the people who go "so.. how can i set an environment variable"... ie
peopl who dont know how to customis bashrc's or write xinitrc's and
use them etc.. which these days is a LOT of people... :(
note - it's advanced for people with advanced needs, thus its not the
most friendly dialog.. but it works. :)
SVN revision: 59369
we try use x on shutdown when x io fatal conditions have happened.
x_fatal flag around for that now too. tested. seems to now be happy
and not cause aborts on shutdown when x has gone.
SVN revision: 57075
Do not abuse the concept of e_*_init(), make them call-once and those
that needed multiple call are renamed to e_*_update(). To make sure
convert them to EINTERN so the symbols are not exported.
Actually I guess too much is exported as EAPI while they should be
EINTERN, but that would require manual investigation, while this patch
was basically created with sed + grep.
SVN revision: 54795
* Remove vim modelines:
find . -name '*.[chx]' -exec sed -i '/\/\*$/ {N;N;/ \* vim:ts/d}' \{\} \;
find . -name '*.[chx]' -exec sed -i '/\/[\*\/] *vim:/d' \{\} \;
* Remove leading blank lines:
find . -name '*.[cxh]' -exec sed -i '/./,$!d'
If you use vim, use this in your .vimrc:
set ts=8 sw=3 sts=8 expandtab cino=>5n-3f0^-2{2(0W1st0
SVN revision: 50816
NOTE: I did some test and wasn't able to trigger the documented segv.
If you get a segv on exit, please report and help me to understand how
to trigger it. Anyway, I reactived it so that we can get global memory
consuption statistic with e17.
SVN revision: 47322
Previously all windows always existed, and edge bindings showed/hided
windows as needed. And e_zone_flip_win_disable/ e_zone_flip_win_restore
f**k'ed this up.
Will fix bug #483 soon.
SVN revision: 45366
- modules using e_configure_registry_add must be modified to
use registry path as window class for this to work
- fileman now uses e_remember to remember position instead of
handling it separately
- added option to window remember for remembering dialogs and
fileman windows automatically
SVN revision: 42607
We should just set E_CONF_PROFILE from command line option or e_config
startup if we did not had this set before. This is because
ecore_app_restart() will use the same parameters and profile will be
there yet.
SVN revision: 41500
This cleanup replaces snprintf() usage with specific calls, they have
the benefit of being cleaner (so easier to grep), typing less and also
marginal speed up compared to the other (specially concat_static),
although those are rarely used in critical paths.
I'm testing it for some time and seems to not break anything, but let
me know of any problem. If you can review the patch and try to spot
incorrect names, please do.
SVN revision: 40014
the e_main.c change might prove useful as it will minimize path
resolution a lot, something that is not that cheap, even more durin e
startup where disc is still spinning due other tasks
starting. HOWEVER, it might bring problems to those using pre
GLibC-2.4 (we're at 2.9 these days) and maybe people using Solaris or
BSD, let's see if they have any trouble.
SVN revision: 39880
* etk,
* PROTO/exalt,
* E-MODULES-EXTRA/diskio,
* E-MODULES-EXTRA/drawer,
* E-MODULES-EXTRA/penguins,
* E-MODULES-EXTRA/slideshow,
* E-MODULES-EXTRA/mail,
* E-MODULES-EXTRA/forecasts,
* E-MODULES-EXTRA/iiirk,
* E-MODULES-EXTRA/places,
* e,
* ewl,
* ecore,
* elitaire,
* entrance,
* e_dbus,
* efreet: Here we go, move from Ecore_List to Eina_List.
NOTE: This patch is huge, I did test it a lot, and I hope nothing is
broken. But if you think something change after this commit, please
contact me ASAP.
SVN revision: 39200
Command line and configuration option to have Enlightenment to start
with desklock, so we can avoid a login manager and still be safe, but
everything will be loaded and you get a better user experience.
SVN revision: 37605
just the init of ibar/fileman favorites is the old untar code moved to
wizard. icons for all profiels are nto done yet - doing. broung some
backgrounds back - small .edj files though.
SVN revision: 37119
init splash now merged with theme - default theme has both. saves space on
disk and just in the end is cleaner. can still select spash separately - but
now themes should provide splashes. you can have just splash files in the
theme dir - but won't be much good for full themes.
default theme now is b&w - all moved over and building. it's now default.
default splash is just default theme etc. etc.
this may cause some problems - so i'd just check your settigns and maybe
re-selct your init splash as it may not exist anymore or be found and thus a
blank splash until u fix it in config.
hmm... there is a bug thoug - i think fileman related. will check. missing
something in theme.
SVN revision: 37006
can select yourself as a user). also any scaling either calculated from dpi
or set by the user is limited to the min/max values a user can impose (thus
even if you have very low dpi, e doesn't go below a scaling factor you set -
eg 1.0 or 0.5, and same for upscaling).
this should
1. keep all the people who want scalable UI's happy (enable scaling).
2. make e able to (if u want) to adapt to pretty much any dpi screen and
selectively scale just what u want it to.
3. allw you - the user, to be the final controller of just how much to scale
- if you like scaling but think it scales too much - then limit it or set
your own.
right now this will onyl work if your theme supports it... the b&w one does
(mostly). so try that and test. other bits of e need to adapt to this too
(shelf, icon sizes, etc. etc.) as they are not done via edje but code sets
them.
SVN revision: 36211
- make ecore_imf optional
- add pkg-config requirements to enlightenment.pc
- remove battery check dependant on ecore-txt
- move Ecore_Txt.h from e.h to temperature module
SVN revision: 35470
1. configure/build changes to allow cross-compiling painlessly
2. pager module namespace changes - this was still dirty afdter the namespace
cleanup, so clean it up
3. add a powersave subsystem - doesnt have an "automatic" way to turn on and
off right now, this i think is best provided by modules (that do things like
monitor acpi status's (eg close lid of laptop), AC power status etc. etc.
this allows e to nicely defer "power" expensive actions to avoid disk
spinups etc.
4. move to use the new ecore poller system - discussed long ago as part of
power management/saving issues. now it exists
5. add a canvas idle flush call that helsp cope with the new shm greedy
software x11 engine stuff
6. use the new powersave subsystem where appropriate
7. fix non-zeroed/initted memory access in e_fm_main
8. fix mem leak for e menus
9. remove ipc handlers for changed/removed config values
10. use animaotr not timer for menu scrolls - then menu scrolls obey the fps
config
11. fix up timer/poll happienss of cursor idle stuff
12. remove avoid damage from popups for now - causing problems
13. change battery and temp readouts to b e shorter so they fit
14. pager can emit signals on focus change for mini-windows now
15. temperature module now uses a slave process and uses stdin/out to talk to
it and get output - this makes e smoother as in my expereicne i found getting
the temp on my laptop actually took like 200ms so e "hang" for 200ms while
reading the acpi files - so now the subprocess does it and just writesa back
to e when it gets it.
ecore:
1. add ecore_pollers. see the documentation on them in doxygen comments :)
2. fix timers to only go off when they have to - bug there that made e's
select time out a LOT more than it needed to. defensive coding hid the
problem. now fixed. e should be much more power friendly now.
3. formatting/niceness in ecore_exe stuff
4. some comments on comments with SIGIO ideas vs. select
5. add call to be able to add an idle enterer at the start of the list of
them, not just the end (as has been the default)
6. fix ecore_evas to support auto evas idler calls after 0.5 secs of idle in
all canvases - and to do it right
7. if argb destination - set the shape EVENT shape (to mask out events in
transparent regions much like shape does withotu translucency)
8. in ecore_x add support for the event shape
evas:
1. fix cache to work properly and not just always fill up (as it seemed to
like to think cahce useage dropped below 0 when it didnt and thus just
over-fill)
2. software x11 engine now ONLY uses shm segments - no ximages over the
socket. this ximage hack was there to avoid the 2 round trips involved in
setting up an shm image - now i mitigated that wih an shm image cache pool.
it keeps shm images around and repurposes them for new update regions if
appropriate. this means many fewer shm creates (about 1/100th the number) and
since we recycle the memory less 0 memory page filling by the kernel - in the
end, i recorded about a 10-20% speedup over the old software x11 engine.
simple tests i have seen up to 120% speedups. idle flush now does something -
it frees all the cached shm segments. it has a hard-coded limit of 4mb worth
of shm segments (or 32 segments - whichever comes first) to keep around. once
can never complain much about speedups methinks :). also evas will defer sync
until the NEXT frame is written - this means evas can calculate the next
frame of data while x dma's/copies the images to the screen at the same time
(if you hve a dual core or multi-cpu machnike or your xserver is able to use
DMA to copy image data to the screen/video ram then this should see a decent
speedup).
SVN revision: 33448
* Break out intl data. Reduces the size of e_imc
* Add Dbus ipc replacement
* Elightenment Dbus API can be extended by modules (Example: msgbus_lang)
SVN revision: 31803
2. fm2 .orde rmaintenance works (seemingly) again - going via the fm slave
proc now. added x,y co-ords for now too - thats for icon view later.
SVN revision: 29528
- Don't allow (some) events during shutdown, as events wont be processed.
- Don't remove drop handlers on dnd shutdown, they should be removed by
their creators.
- init/shutdown fwin
- Delete fwins on shutdown.
- Remove weird ipc wrapper function.
- Don't do additional shutdown functions on restart.
SVN revision: 29366
process to stop e from ever "locking up". this unfortunately breaks the other
source stuff and thus breaks the app editor config dialogs and anything using
fm2 for .desktop stuff from the e applications/all repo. i am doing this as i
expect this to go away with efreet anyway so not too much of an issue. not
all fm operatiosn work currently - note. so beware. it can view files though :)
SVN revision: 28528
on my p4 3.4ghz + reiser3fs IO Wait time went from 2.6 to 1.9 seconds
(total login time went from 3.01511 to 2.29971, with 100% cached login time
being 0.41809)
on my core 2 duo laptop + ext3fs IO Wait time went from 2.05 to 1.15 seconds
(total login time went from 2.50988 to 1.60785, with 100% cached login time
being 0.45850)
this should speed up e's login a bit... i hope.
note - it is adaptive. it needs you to log in at least once using the current
code as it traps and logs certain file accesses and needs that log to replay
next login.
SVN revision: 26742
Igor Murzov
Mike Blumenkrantz
Carsten Haitzler
Chris Michael
Cedric Bail
Mike Blumenkrantz
Lucas De Marchi
Gwanglim Lee
Gustavo Sverzut Barbieri
Chidambar Zinnoury
Vincent Torri
Christopher Michael
Leif Middelschulte
Hannes Janetzek
Sebastian Dransfeld
Andreas Volz
Miculcy Brian
Eduardo de Barros Lima
Viktor Kojouharov
andrunko
Stafford Mitchell Horne
rephorm
David Walter Seikel