Add function in e_utils to get a zone by Ecore_X_Window (black_win).
No need to check for locked in illume-indicator.
Add client message handler for quickpanel to handle zone request changes on
quickpanel borders.
Remove some printfs.
Minor formatting in illume2 e_kbd.
Easier check for focused_vkbd_state.
SVN revision: 45233
e_widget_ilist_count does not work as it did, as it
e_widget_ilist_multi_select only queues commands and the change is not
instant. Add own counter for ilist position.
Also set pointer for config desk_list to new list on apply.
SVN revision: 45138
Only emit "selected" on mouse up if we are in single click mode and no
modifiers is set.
Need to check for single_click first, so that inplace_open isn't called
on doubleclick.
Fixes ticket 375
SVN revision: 45130
Add code to fetch illume atoms on border map & property changes (if needed).
- This avoids a lot of round-trip calls to X when running illume2.
Remove whitespace & fix some formatting.
Use PATH_MAX instead of 4096.
Update illume2 code to use new border atoms and avoid round-trip X calls.
SVN revision: 44879
* Remove 'Set as background' from conf_wallpaper and add it to e_bg
together with the other code that already was handling
'*.edj'. This makes more sense and will enable the action in
presence of both versions of wallpaper dialog;
* e_utils got pieces required by e_bg that could be used elsewhere,
one is the dialog to query for options to import, the other is what
really generates the conversion (import) of image->edj.
* conf_wallpaper: import thing is way too messy, needs cleaning or
removal. I don't care much about it as I plan to improve wallpaper2
instead.
SVN revision: 44556
I ran out of time, so if someone wants to finish the move of
e_int_config_wallpaper_import.c to standard e_bg.c I appreciate the
help. Skeleton is there.
With this, it is possible to remove code from conf_wallpaper and have
that functionality in both wallpaper and wallpaper2.
SVN revision: 44527
After we send the drop to the target it can take a while before it is
acknowledged. So release grab and hide input window so we can continue
working.
SVN revision: 44223
put the edge windows on the correct layers
allow edge click bindings
use actions for auto-hide shelves
toggling auto-hide will cause edge event windows to show/hide if necessary
SVN revision: 42864
- allow any maximized windows of any type to be manipulated when allow_manip is set
- remove 'maximize expand' option from config gui. this is the same as 'maximize smart'
- dont restirct iconify of fullscreen borders. this is policy that can be (and is)
restricted by gui.
SVN revision: 42735
anyway nice that i didnt had to rewrite gadcon layout to fix this issue,
but at least starting the rewrite made me realize the above mentioned
difference. moving and resizing of gcc in non-shrinked mode works
now nicely again.
SVN revision: 42637
- modules using e_configure_registry_add must be modified to
use registry path as window class for this to work
- fileman now uses e_remember to remember position instead of
handling it separately
- added option to window remember for remembering dialogs and
fileman windows automatically
SVN revision: 42607
- fix dnd of gadcon clients between gadcons
- apply fix from victor for gadcon client movements
- make layout algorithm orientation agnostic
SVN revision: 42539
since these are not set by e_remember_update anymore
- remove E_Remember parameter from e_remmber_update.
if update is possible bd->remember is already set
- do not overwrite bordername value of remember on update.
should only be set by conf_border dialog
- make sure on update that match values are set otherwise
delete remember
SVN revision: 42435
- option added to remember desktop file for e window match.
means no more ugly openoffice provided icons (= even if i dont use it ..
- e_border: added fallback for transient windows to use .desktop from main window
- fixed bug in e_remember to not delete all remembers when last item of the conf_remember list is deleted
SVN revision: 42432
Iconified, Maximized, or Fullscreen'd via the border menu. These type of
windows do not support those actions via the border buttons, so do not support
them via the menu either.
SVN revision: 42279
round. members of E_Volume are strduped. rest of e's code still deals with it
that way. e_hal from dbus also returns duped strings (thats why)
SVN revision: 42204
Note: The situation regarding string from config file could be improved.
We could use the same trick as Edje and directly map the string from
Eet config file. This will improve memory used by E, if string from
config file are used a lot. So the question is : "Do we save a lot of
string in config file ?"
SVN revision: 42201
e_flowlayout_min_size/e_flowlayout_max_size_ changed to size_min/max
e_entry_min_size_* changed to e_entry_size_min_*
e_slider_min_size changed to e_slider_size_min_*
SVN revision: 42164
Hi guys.
Here is my solution for #113 ticket request. This allows to transfer a
gadget to different locations. In short,
- any module can register arbitrary number of locations by invoking
e_gadcon_location_register().
- module is responsible to provide 2 functions, one for removing
particular gadget and one to add particular gadget class.
- module responsible to equip its gadcon(s) with reference to registered
location. If a gadcon contains non-NULL location reference, each gadget
contained by this gadcon can have submenu on its context menu. Template
function for constructing such submenu is provided
e_gadcon_client_add_location_menu. Gadgets can be moved from and to this
location by invoking menu items. Gadcons with NULL location reference
can accept transferred gadgets by module logic but can't send contained
gadgets to another module.
- module responsible to unregister location when gadcon is no more
available.
- menu items for context submenu is sorted by E_GADCON_SITE_XXX assigned
to that. Module can assign and change an icon for context menu item
corresponding to its location(s).
- Currently only shelves and gadman (desktop) used in gadget transfer
operations. I believe it is no trouble to ivolve any other
gadcon-capable module into the process. If you want to have that, please
just let me know.
Here the patch in attachmet. It even works, at least sometimes and at
least for me. Hope you'll find it useful.
SVN revision: 42121
Whitespace Removal.
Fetch the windows evas once instead of multiple calls to e_win_evas_get.
Use E_FREE to free the config dialog structure.
Make sure the window is centered when switching between Basic & Advanced.
SVN revision: 41931
- Hide eina_list internals by using eina macros
- Cleanup some duplicate code
Patches slightly modified for formatting & whitespace removal.
Use eina_list internal macros in some places that were missed.
SVN revision: 41518
This nasty bug was more evident with dialog reuse on configuration
Basic/Advanced toggle, on some resolutions like 1280x1024 it was
always reprodutible.
The problem spotted by Manio is that the dialog contents is resized
but the window is not. The bug follow is:
* window is at some given size (640x512)
* user toggles contents, calls e_dialog_show()
* bg_object (window contents) is resized to MIN (!!!)
* e_win_resize is called with MIN (so far, so good)
* something calls e_util_win_auto_resize_fill(), size is back to 640x512
* _e_border_eval() resizes to the last value 640x512, it's unchanged
so _ecore_evas_x_resize() checks for size being the same and ignore,
not even callking back fn_resize (user callback, _e_dialog_cb_resize).
* window is at 640x512, while bg_object is at MIN, BUG!
One solution is to never change bg_object from outside
_e_dialog_cb_resize, like it's after this patch. The other is to
always call fn_resize even if it did not changed, which could lead to
lots of useless work.
By: manio
Confirmed: barbieri
SVN revision: 41515
Use E_FREE for things created with E_NEW.
Add new function to clear the toolbar.
Add new function to return the number of the selected item.
SVN revision: 41501
We should just set E_CONF_PROFILE from command line option or e_config
startup if we did not had this set before. This is because
ecore_app_restart() will use the same parameters and profile will be
there yet.
SVN revision: 41500
execinfo.h (which contains the backtrace* functions is only included
if OBJECT_PARANOIA_CHECK is defined so add an #ifdef around those calls.
SVN revision: 41439
This patch will reuse the same e_dialog and thus window while changing
contents between basic and advanced. The benefit, among many, is to
avoid titlebar flashing like hell when you click the toggle button.
By: manio
SVN revision: 41314
Ooops! My last changes to introduce without_border broke things, often
unnoticed but it was in the way when we requested resize of existing
window, done in the patch to reuse the e_dialog while toggling between
basic<->advanced by manio.
Thanks manio for spotting and Sachiel for the time help debugging it.
SVN revision: 41313
Before gadman was using a single gadcon for all zones, that lead to
problems like popup menus being incorrectly placed.
The correct solution is to mimic shelves and have one gadcon per zone,
including the top layer.
By: manio
SVN revision: 41312
this should help us in near future:
* -valgrind[=MODE], to run under valgrind and toggle interesting
options as we often request users to give us valgrind logs but
they're often running valgrind on wrong binaries and with wrong
parameters. See enlightenment_start -help for more, but in sort:
-valgrind=all should give us enough information.
* -valgrind-log-file=path, so the log will not mix with lots of
output we do.
* debug: on crashes, always list traceback (execinfo/glibc
functions) and check if gdb exists, if so ask it to print out
traceback of all threads to stdout. gdb will be detached as soon
as messages were printed and everything should work without gdb as
well.
SVN revision: 41309
version config - literally keep the last 9 config revisions (10 including the
current) and if config gets corrupted...it auto-falls back to the last good
one.
SVN revision: 41252
Formatting.
Whitespace Removal.
Variable cleanup.
Add missing 'static' declaration on private function.
Move EAPI functions to be together in the source before local functions.
SVN revision: 41246
to error, abort or overwrite dialogs.
2. Glyph in fileman_opinfo theme that show have or not operation linked
filemanager window.
3. When click on operation on fileman_opinfo, then linked efm window
raised or attention dialog if error exist.
SVN revision: 41229
1. Gadcon sities:
-- 'E_Gadcon_Site' enum to list all available sities,
-- added 'is_site' callback for distinguish gadcon sities,
-- 'e_gadcon_site_is_*' helpers written to use in gadget modules,
-- gadcon config dialogs modified to show only gadgets that appropriate
to selected gadcon site,
-- all gadget modules updated for using new callback.
When callback is not provided in module, then gadget can be used in
any gadcon site.
2. Filemanager:
-- added error icon to unexisting path dialog,
-- added callback 'func.abort' to 'E_Fm2_Op_Registry_Entry' to specify
abort operation sequence (if not provided, then operation is not
cancelable),
-- added parameter to 'e_fm2_op_registry_entry_add' to specify abort
method on construct 'E_Fm2_Op_Registry_Entry' or make non-cancelable
operation if this function is not provided,
-- added 'e_fm2_operation_abort' call to cancel efm2 operation,
-- added method '_e_fm2_operation_abort_internal' that represent efm2
default handler of operation cancelling,
-- 'done' and 'total' fields of 'E_Fm2_Op_Registry_Entry' changed to
off_t type, also all message handlers modified to work with it
(to show progress for large files correctly),
-- improved file operation progress processing,
-- added cancel button to operation progress gadget in filemanager window,
-- added delete file glyph to operation progress gadget,
-- improved status message for efm2 operation progress.
3. Filemanager slave:
-- fixed critical bug in message handling via stdin/stdout,
-- fixed critical bug in removing task from list,
-- improved 'E_FM_OP_ABORT' handling,
-- fix rollback counting on moving files.
4. Fileman_opinfo module:
-- a new theme writed: status string and gadget for view operation status
in summary and detail modes,
-- summary mode: operation glyph, state message, progressbar, abort button,
-- detail mode: all for summary + from filename, to filename,
-- summary/detailed button works as trigger,
-- added source of module theme and used images.
4. Pathbar module:
-- non-critical fix, just for safety.
Also patch contains several minor updates to serve main task.
SVN revision: 41224
The old code that query the zone based on x,y was causing me
segfaults. When battery module was in a hidden shelf, the position was
outside any zone and then segmentation fault.
As far as I understand, gcc->gadcon->zone should always exist and
always be correct, but I don't have xinerama setup now to confirm
that.
If you know this is wrong, let me know!
SVN revision: 41147
Here's another patch I've made for efm2 to fix an issue that I've
often experienced using it (in Illume) with a touch-screen
device (Freerunner). It often happens a very strange thing: I
try to finger-scroll a bottom icon (it must be on the latest row)
moving my thumb up, well... The the scroller doesn't scroll, but
wherever and whenever I release my finger, the selected icon is
executed!
I don't really know to what is this due (the touchscreen seems to
perform correctly by the way), but I've never been able to
replicate it using a mouse in my PC.
Anyway to fix this issue, that could be specific, I've used a
workaround that I think that could be applied for all: it
basically checks if the mouse has been released in the area where
the clicked icon is, before sending a "selected" callback.
It needs the previously attached
e_fm2-single-click-delay-support.patch to be applied correctly.
Going deeply into the real issue I've made some tests, and I got
that this seems mostly due to an evas issue (I figure), since the
e_fm2's scrollframe never sets the evas event flag to:
EVAS_EVENT_FLAG_ON_HOLD
(that would avoid the un-wanted click).
After some debugging there, I've also seen that in this very
particular buggy case the _e_smart_event_mouse_up() and
_e_smart_event_mouse_move() callback functions are never
called (so I figure that evas doesn't add the callbacks at all
for the scrollframe, while they are added in the e_fm2).
Let me know what you think about this... I thing that the Om
users would need a fix like this.
By: Marco Trevisan (Treviño)
SVN revision: 41129
avoiding the un-wanted clicks with touch-screen devices (especially if
they aren't so precise); it basically allows to set a time delay to be
awaited (pressing over an icon) before sending a "selected" callback.
Thanks to this, it could be needed a longer pressure to select an item
in the file-manager; useful for embedded/touch-based systems.
By: Marco Trevisan (Treviño)
SVN revision: 41127
This bug was showing when fast toggling between advanced<->basic in
config dialogs.
Note, however, that there are a remaining alien bug with fast
toggling. It's aborting due adding evas object as member of another
from other canvas, which is not allowed. I tried to debug it and it's
REALLY weird, the advanced or basic create_widgets() are being called
twice, from inside the same function, like if the create_widgets() was
calling itself, but the code do not do that, I traced some that would
happen from e_widget_button_add()!!! Like if we had threads of were
being preempted from nowhere, really strange... seems like a stack
corruption :-(
SVN revision: 41038
as spotted by manio, toggling between "Basic" and "Advanced" mode was
making the window move (just open Theme dialog and toggle).
Manio suggested a fix by keeping window center between both modes, but
I think that given our top-left to bottom-right reading (LTR) we
better keep the title bar (x,y) intact and avoid full rescan. This can
be weird in small screens where the dialog will not be centered
anymore and that will show easily, but on regular screens this should
not be an issue.
Also spotted that it was wrong when trying to avoid window overflow
(using x instead of y).
PS: I wonder why we destroy and create the window all over again! This
is really annoying, title bar will show the focus animation and you
get lost (need to rescan it again).
SVN revision: 41004
if an executable returns non-zero a dialog will be present with
information, if it was a .desktop file, then it would use the "Name"
field to name the log and all.
However, the .desktop reference was deleted and the dialog would use a
bogus pointer. Now we take a reference insidethe dialog and just
release it on dialog deletion.
Found by manio, fix by me.
SVN revision: 40987
Avoid case where e_exec (and possible others) gives
e_util_filename_escape() a NULL parameter, actually another bug, but
does not hurt to safe guard this one.
By: manio
SVN revision: 40979
1. Added E_FM_OP_EJECT command to e_fm_main. It unmounts volume
before eject, if it necessary.
2. Added timeouts of mounting/unmounting/ejecting media, and
it's moved to slave e_fm_main.c. Each timeout will generate
*_MOUNT_ERROR, *_UNMOUNT_ERROR and *_EJECT_ERROR message.
3. Added auto mount on insert media and auto showing efm2 window
on mount volume options to filemanager config.
4. Added mounted/unmounted glyphs to efm2 icons and track state
code. Now each removable device have "M" glyph on icon if mounted
and "U" when unmounted.
5. Added mount/unmount/eject commands to icon dropdown menu.
6. Russian translation of mew messages.
7. Other bugfixes and improvements for co-operation.
Now, efm2 contains all code to mount/umnount/eject removable media and
all code to provide corresponding user interface.
It can working independently from 'places' or co-operate with it.
By: Sergey Semernin
SVN revision: 40928
I found strange behavior in my configuration (xinerama - two screens
with two zones). When i select a Enlightenment->Restart from menu the
popups for gadgets on desktop doesn't appear or appear wrongly. After
some time i've found that this depends on on from what screen i am
choosing this enlightenment->restart :)
After some debugging i figured it out:
When restarting enlightenment some gadgets (i.e. calendar) are calling
e_gadgon_popup_new(). Inside that function, zone for popup window
(this zone was used later in ecore_evas_move_resize) is calculated
like that:
{{{
zone = e_util_zone_current_get(e_manager_current_get());
and in e_manager_current_get is: ecore_x_pointer_xy_get()
}}}
... so - i have my answer why restaring from one screen (cursor was on
that screen) and from second screen i have different results...
In other words: during initializing module like calendar - created
zone for popup is assigned depending on current cursor position.
In my patch i've chage this to obtain zone using the gadget position
instead. But it solves the problem partialy.
Next thing - in function:
e_gadget_popup_show() (which is called later) when calculating popup
position coordinates was calculated using zone:
{{{
pop->gcc->gadcon->zone
}}}
which in my case was always the first (initial) zone - (of course it
was wrong, because i put a gadgets on different screens for testing).
so i changed it to zone of popup window (which was calculated before,
in e_gadgon_popup_new()) and after that everythings works ok :) Zones
for popups are correctly assigned and popups calculation are also ok -
even after restaring enlightenment (tested with cursor on both
screens).
By: manio
SVN revision: 40927
Christopher Michael
Sebastian Dransfeld
Carsten Haitzler
Gustavo Sverzut Barbieri
Iván Briano
kiwi
Samuel F. Baggen
Vincent Torri
Hannes Janetzek
Viktor Kojouharov
Cedric BAIL
victor
Miculcy Brian
semernin
Davide Andreoli