As usual, ever-changing...What a shame if they would drop this OS
midway through all these changes towards some vision.
Dear Apple, finish what you have begun...too many wasted man hours
bodging all the changes you make between releases (major and minor).
This comment's origin could be disputable it's from libtop.c
from macOS top command. There is very little external documentation
for these things. As time goes on it gets worse....
I understand what is happening on OpenBSD, but I don't know why
this is happening. I need to speak to someone in the know about
this because it's not occurring on other platforms, and this
shouldn't be happening.
Adding new stuff is fine, though it NEEDS to be working on the
main target OSes. That's OpenBSD, Linux, FreeBSD and to some
degree macOS and DragonFlyBSD...If you want to add a new
OS, it'd be better if the patch included as much functionality
as possible :)
I don't belive in ifdef blocks within a single function. Ideally
keep the blocks separate at worst. I think if this is necessary
at the time it's permissible but overall it's fucking ugly.
The functions machine.h provides are deliberately using standard
functions from a base install of the operating system. This IS
intentional. I'd like to be able to modify and reuse this anywhere
without having to untangle additional dependencies from machine to
machine.
To make this maintainable (for now), split the machine querying
code into separate files. I'd like to be able to modify the file
without fear of breaking it here or there. Also, for anyone who
wants to make a change or ammendment doing this is cleaner.
Alastair Poole
maxerba