Subject: [E-devel] [PATCH] fix elementary build error without ethumb
Date: Sun, 26 Jun 2011 13:37:02 +0900
Hello, EFL developers.
Without installing ethumb, when I build elementary, there is build error.
This patch is for fixing it.
Would you please apply this patch?
SVN revision: 60696
This patch need review. The goal is to always find the best
quality for the output. Sadly in our theme we don't provide
multiple size for icon (we could, as edje provide this feature).
So to test it, better switch to FreeDesktop first before
trying the theme.
SVN revision: 60636
Subject: Re: [E-devel] [Patch][elm_conform]
When the indicator is displayed initially and use elm_confrom as parent by
using elm_conformant_content_area_get, the indicator area (wd->shelf) does
not display properly.
Because any interested ECORE_X_EVENT_WINDOW_PROPERTY does not notify.
In this case, we have got to evaluate size, when EVAS_CALLBACK_RESIZE
occurs.
SVN revision: 60616
Now it matches the documentation, which says: "end_cb - The function to
free the context data, it will be called at the end of the effect."
SVN revision: 60550
made originally so I've made some changes/ updates to elm_glview
1.) GL Resource Deletion in ELM_GLView
In order to delete GL resources, the current approach simply registered a
delete callback to the GLView object and handled resource deletion there.
Unfortunately, using the delete callback did not guarantee the glview context to be
current. In order to guarantee that the current context was the glview context,
the make_current call needs to be called explicitly. Since we were hiding all the
make current details in elm_glview, i've decided to add an API that registers a
delete callback function. I know that this may seem redundant since there is already
a delete callback that you can register with glview objects. Unfortunately, this is the
only option that we have apart from exposing make_current, which is something that
went again what we are trying to do with elm_glview.
Since adding delete callback alone seemed a little out of place, i've taken the liberty
to add other callback functions to make it seem consistent.
void elm_glview_init_func_set(Evas_Object *obj, Elm_GLView_Func func);
void elm_glview_del_func_set(Evas_Object *obj, Elm_GLView_Func func);
void elm_glview_resize_func_set(Evas_Object *obj, Elm_GLView_Func func);
resize callback can be controversial as well but I want to argue that adding this callback
makes the render function a lot cleaner. To handle resize differently, the user in
render function needs to manually compare and see if the size has changed, and
then handle the cases. Doing all of this internally once makes the developers life
a lot easier in my opinion.
these callback functions do make the render function a lot cleaner. You can check
out the updated test_glview.c or newly added test_glview_simple.
2.) Minor bug fixes/changes
elm_glview_scale_policy_set() was supposed to be elm_glview_resize_policy_set()
but it somehow evaded our reviews. That has been fixed.
Also, in _glview_resize, after updating the surface, it was explicitly calling the
render function. It is actually unnecessary here and calling it here will cause
problems if resize gets called before everything else is setup properly. So that has
been commented out.
3.) test_glview & test_glview_simple
elementary_test case for glview has been updated to reflect the api changes.
when you run the elmentary_test, you need to make sure that you set
ELM_ENGINE=gl as glview currently only runs on gl backend.
test_glview runs the gears example. For testing purposes I've included a simple
glview test case that renders a triangle and changing background color.
SVN revision: 60517
Subject: [E-devel] [patch] els_scroller simple bug
els_scroller in elementary has a simple bug.
In the function "_smart_scrollto_x", it makes the animator
'sd->scrollto.x.animator', if the animator does not exist. But
"_smart_anim_start" before ecore_animator_add can make 2 animators.
If the function which be called by _smart_anim_start call
"elm_scroller_region_bring_in", "_smart_scrollto_x" be called again and make
the animator. After the function which be called by _smart_snim_start ends,
the next line will make the animtor again. Despite the code checks the
animator, it can make 2 animators. So we have to change the order of the code
like patch file.
SVN revision: 60507
can be scrollable or not. scrolled entry now just calls entry calls
and is marked as dperecated to be killed off in the future so no need
to document it etc. edje external also goes.
SVN revision: 60438
to have it in %{release} also. So let's just tag the package as ours
and try to make sure it doesn't interfere with vendor releases.
SVN revision: 60407
Subject: [E-devel] [patch] elm_cnp_helper - string iteration bugfix
I've made a patch about elm_cnp_helper.
In elm_cnp_helper, some codes are unused.
It related with elm_entry for image showing, it makes image provider.
However elm_entry can parse an item with specific prefix.
It's not needed anymore.
SVN revision: 60340
Subject: [E-devel] [Patch] elm_genlist - added auto scroll function
when expanding items.
Now, The user don't know how many items are added when the item is expanded in tree view.
If the use want to know how many items are added, they have to scroll
genlist view.
So I added auto scroll function when the items is expanded on bottom of viewport.
Using this, the user can know expanded items although that is expanded
beyond the view port.
SVN revision: 60302
Subject: [E-devel] [Patch] elm_gengrid reorder mode moving effect added
Dear All.
I made a patch for elm_gengrid moving effect on reorder mode.
You can see reorder moving effect when you reorder item.
Please review this patch.
... I like! in svn! :)
SVN revision: 60301
structure.
'canvas' and 'output' are same. So we need to deprecate one of them
later(may be evas 2.0 or so.) After I discuss this with raster, I've
got to use 'canvas' not 'output'. So I fixed elementary codes.
SVN revision: 60268
This is very useful when you want to feed an entry from a socket for example
and you don't want to wait until all the information is received
SVN revision: 60267
I think there is no more whitespaces in elementary. So from now on
please check if your code is whitespace-free when you commit it. If so,
no one will suffer from removing whitespaces and merge conflict.
SVN revision: 60223
1. Fixed ellipsis to work correctly.
2. Changed it to sync the background size to the text part size.
3. Font resizing also works nicely now.
4. Split internal text to format and actual text.
SVN revision: 60132
Using evas_event_freeze/thaw in _item_realize, _item_block_recalc and _queue_process breaks "Genlist 4" test case which is using textblock.
We need to re-examine evas_event_freeze/thaw. They are so tricky :(
SVN revision: 60092
1. Changed int for 0/1 to Eina_Bool.
2. Removed unnecessary variable. Don't need to assign macro to
variable. Just use macro.
3. Fixed indentation.
SVN revision: 60086
Genlist items are realized separately. So block realize doesn't mean
realizing all items in the block. This function and
_item_block_unrealize() will be refactored later again.
SVN revision: 60085
Because sub,del callback will be called for both base and content,
the item finding root will be called twice unnecessary.
This changes provide somewhat optimized sequence.
SVN revision: 60059
if user call the elm_pager_content_pop when pager has two items on the stack,
the bottom item can be incorrect. so when user call the content_bottom_get right after pop,
the returned item would be not bottom content but top.
SVN revision: 59958
Followed E coding style. Refer http://trac.enlightenment.org/e/wiki/ECoding. I have no idea about struct initialization though.
1. Fixed indentation.
2. Removed unnecessary lines.
3. Etc...
SVN revision: 59921
Subject: Re: [E-devel] [Patch][CtxPopup] Add Arrow on the drag-able
area of Base
Dear Mr. Hermet,
Hello, I have attached more accurate patch based on latest elementary. The
last patch already there.
All your review items are reflected on the attached patch.
Please review this again, sorry for any inconvenient.
SVN revision: 59911
Subject: Re: [E-devel] [RFC] ELM GLView
Elementary GLview wiedget giving simplified access to do opengl
drawing in a widget in elm so you pretty much do no work to set it up
and just provide a render function to draw the contents when it needs
drawing. Thanks to Sungwoo Park and Samsung
SVN revision: 59909
Subject: [E-devel] [Patch] elm_gengrid - added new feature : gengrid
reorder mode
I added a new feature "reorder mode" of gengrid refer to genlist
reorder mode.
After set this reorder API, if user press an item (long press), the item can
be moved another position.
Then if the user releases the item, the item will be reordered in gengrid.
SVN revision: 59892
Subject: [E-devel] [Patch][CtxPopup] Add Arrow on the drag-able area
of Base
If CtxPopup has elm_slider for content, the elm_slider indicator is covered
by CtxPopup arrow.
So, I have made a patch for resolving this issue. As the title the arrow
will be swallowed in the base.
Even though user uses his/her own style, the attached patch will work
properly.
Sincerely,
Shinwoo Kim.
SVN revision: 59890
1. Added reorder APIs to Elementary.h.in header.
2. Fixed wrong declaration of moved callback.
3. Fixed warnings.
And I think 'moved' function needs to be changed to smartcallback.
This is not related to item class structure.
SVN revision: 59885
It looks like flip is not changed frequently now. I will check
whitespace and indentation from time to time. If this is not good,
please check codes before commit. Thanks.
SVN revision: 59884
Subject: [E-devel] [Patch] elm_genlist - added new feature : genlist
reorder mode
I introduce a new feature "reorder mode" of genlist.
Using this feature, user can reoder genlist items dynamically.
[API]
==================================================================
- EAPI Eina_Bool elm_genlist_item_rename_mode_get(Elm_Genlist_Item *it)
Get the rename mode state of an item. This gets the rename mode state
of an item
- EAPI void elm_genlist_reorder_mode_set(Evas_Object *obj, Eina_Bool reorder_mode)
Set genlist reorder mode. This enables the item is moved to another
item.
==================================================================
After set this reorder api, if user press an item (long press), the item can
be moved another position.
Then if the user releases the item, the item will be reodered in genlist.
When the user releases the holding item, Elm_Genlist_Item_Class.func.moved
callback is also called.
If needed, the application can add some logic in that callback function.
SVN revision: 59883
Subject: [E-devel] [Patch] elm_widget_focus_steal should be executed
only with "can_focus" object.
I think elm_widget_focus_steal function should be executed only with
"can_focus" widget object.
("Cannot_focus" object has no right to steal focus from others !!)
SVN revision: 59733
wd->grd is an evas_object_grid, so children should be get
with evas_object_grid_children_get
Btw, I'm not testing this function, just saw it.
SVN revision: 59671
multiple selection. Patch by Hyoyoung Chang <hyoyoung.chang@samsung.com>
On Tue, May 24, 2011 at 7:43 PM, Hyoyoung Chang
<hyoyoung.chang@samsung.com> wrote:
Dear Elementary developers.
I made a oneline patch.
It's about in single selection mode of elm_genlist.
In single selection mode, some multi touching can make multi selected items.
It can't easy reproduce at PC environment(like as mouse+keyboard), but if you have multi touching device you can easily reproduce.
Reproduce step is putting two pointing device on genlist.
1. long pressing one pointer.
2. Short press another one pointer.
3. And repeat alternating press two device
Then you can find multi selected items in single selection mode.
So my approach is if a item is not selection and just only
highlighted, then make it with _item_unselection()
SVN revision: 59659
_item_unselect().
1. _item_select() and _item_highlight() are also separated. Each
function can be called separately. This will be introduced in later
commit.
2. 'unhighlight' sounds weird but there is no other good names.
3. Call _item_unhighlight() before _item_unselect() for selected items.
SVN revision: 59652
adding a new API.
1. Virtual Keypad Support.
2. New API "elm_conformant_content_area_get" added.
- Reviewed by Rasterman and I just fixed warnings.
SVN revision: 59528
The text is split to chunks and then appended from an idler. This makes
the entry very responsive and smooth even with very long texts.
SVN revision: 59408
a special elm_engine var - great way to auto-generate screenies from
apps and change config/theme and everything automatically (via scripts
etc.)
SVN revision: 59185
i removed all custom enum & url callback of elm_map.
(ELM_MAP_SOURCE_CUSTOM_1, ELM_MAP_SOURCE_CUSTOM_2, ..., _custom1_url_cb, _custom2_url_cb, ... etc)
instead of those, i made sources list.
changed APIs are almost internal APIs...
but some APIs were changed for intuitive usage of map source.
user can make map module instead of setting custom APIs.
another change is "elm_module -> eina_module".
the reason of this change, is that elm_module uses environment value (i.e getenv, setenv.. ELM_MODULES)
i don't want to have a environment value dependency.
SVN revision: 59184
Deprecated existing APIs but not removed them. They will be removed
sometime later or when elm 1.0 is released. And added new APIs.
I fixed box, table and toolbar. I will modify other codes in trunk soon.
SVN revision: 59160
Subject: [E-devel] [Patch] els_scroller bug patch.
I and Seoz found some problem about
_elm_smart_scroller_wanted_region_set in els_scroller.
While genlist items are appended, momentum animation in scroller
cannot operate.
It's why _elm_smart_Scroller_wanted_region_set is called continually.
It's the problem which Seoz told you. and I fixed this problem.
Please check the attached patch file.
If you want to check the problem.
Set the "Thumb scroll friction" in elementary_config to 2~3.
Change the file "test_genlist.c" in elementary/src/bin like below.
SVN revision: 59105
The scroller shouldn't move when the position requested is already
shown. There were two problems:
1. It was assumed that the cw/ch == requsted w/h which is not true, for
example with entry, we sometimes request to show the cursor which way
smaller.
2. We want to check the bounds *after* making sure we are not showing
"dead space" i.e places that the child does not populate.
SVN revision: 59076
<hj0506.yun@smasung.com>
From Jeonghyun Yun.
Hello.
I attached the patch file for calc_job bug.
I found ecore_magic_fail problem when ecore_job_del(wd->calc_job).
wd->calc_job should also to be NULL when pan_smart's cvw and cvh is 0 in
calc_job().
Please check about this patch.
Thanks.
SVN revision: 59034
<lionel.orry@gmail.com>
From Lionel Orry:
Hi devs,
while working on the ffi-efl Ruby bindings for the EFL, I noticed a
wrong declaration in Elementary.h:
s/elm_table_homogeneous_get/elm_table_homogenous_get/.
The patch can be found here: http://pastie.org/1846490
To apply:
cd <path/to/elementary>
wget -O - http://pastie.org/pastes/1846490/download | patch -p0
Thanks in advance,
Lionel
SVN revision: 59033
Get cursor position only when needed, don't get it in advance, cache and
then find out it's not correct because we already moved the entry 10
10 times since :)
SVN revision: 59020
NOTE: evas is able to load corrupted file in some case.
Without proper detection of this corrupted file, we will always end
up with some error when doing thumbnail of the same file in parallele.
SVN revision: 59013
Changed unsigned char to Eina_Bool. Changed 0 to EINA_FALSE for Eina_Bool type variables. Removed unnecessary blank line. Added braces in if statements.
SVN revision: 58964
Subject: Conformant Widget Code refactoring patch
Can you please review the attached patch for elm_conformant.
Change Log: 1. On Theme change, swallowing Parts again. Swallowing
parts done in separate function.
2. Conformant parts size set is repeated in two places, moved to a
function.
3. Conformant Object Move/Resize is handled to realign the Visible
content area.
SVN revision: 58948
Jihoon Kim
Cedric BAIL
Jonathan Atton
Tom Hacohen
Daniel Juyung Seo
Carsten Haitzler
cnook
Hyoyoung Chang
Iván Briano
Gustavo Lima Chaves
ChunEon Park
Massimo Maiurana
Rafael Antognolli
Jonas M. Gastal
Jaehwan Kim
WooHyun Jung
Vincent Torri
Michael BOUCHAUD
Mike McCormack
Michael Jennings
Seunggyun Kim
Jeonghyun Yun
Boris Faure
Sangho Park
Sung W. Park
WooHyun Jung
Bruno Dilly
Stephen Houston
govi.sm