Move enums from elm_scroller_common.h to elm_scroller.eo in order to make them
more accessible for bindings. Delete elm_scroller_common.h.
Moved the include for elm_scroller.eo.legacy.h to the top of elm_scroller_legacy.h
to allow the use of the generated types in the function declarations.
Summary:
For now, if apply image mask to smart obejct, masking does not work except to implement in edc file.
@feature
Reviewers: Jaehyun_Cho, Jaehyun, jpeg, raster, cedric, Hermet
Subscribers: raster, jpeg, cedric
Projects: #elementary
Differential Revision: https://phab.enlightenment.org/D2055
Summary:
elm_object_style_set(obj, "XXXX"); should return FALSE if XXXX style does not exist.
Although it does set default style if "XXXX" style does not exist.
@fix
Reviewers: raster, Hermet
Subscribers: seoz, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2511
Summary:
When popup has a content which is larger than window size, popup is to be larger than window.
so, scroller is added into popup content area.
Test Plan:
1. Making "elementary_test - popup" window smaller than popup content size.
2. Excute "popup-center-title + genlist content + 1 button" in "elementary_test popup"
After applying this patch.
3. popup content shows with scroller.
Reviewers: Hermet, seoz, woohyun, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D2216
Summary:
Currently elm_notify doesn't allow to set or get text if
user's style contain some text parts and he need to set text into them.
Reviewers: cedric, seoz
Subscribers: raster, stefan_schmidt, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1333
AT-SPI2 specification states that active window can have only one widget
with FOCUSED state. This differs from elementary design which assumes
that whole elementary widget tree branch is focused.
Patch assumes that if a widget have no focusable children and can have
focus it can be marked as FOCUSABLE on atspi bus.
Move enums from elm_win_common.h to elm_win.eo in order to make them
more accessible for bindings.
Moved the include for elm_win.eo.legacy.h to the top of elm_win_legacy.h
to allow the use of the generated types in the function declarations.
This commit adds the Eolian class elm_win_standard.
It is basically a derivation from elm_win that creates a default background.
The intent is to replace the legacy functions elm_win_util_standard_add and
elm_win_util_dialog_add by functions accessible via Eo API functions such as
eo_add and eo_do.
To fully replace an elm_win_util_standard_add call, use:
eo_add(ELM_WIN_STANDARD_CLASS, NULL,
elm_obj_win_name_set("example"),
elm_obj_win_type_set(ELM_WIN_BASIC),
elm_obj_win_title_set("Example"));
Removed the constructing method elm_obj_win_constructor.
Now "name" and "type" are properties that must be set at creation, like this:
eo_add(ELM_WIN_CLASS, NULL,
elm_obj_win_name_set("example"),
elm_obj_win_type_set(ELM_WIN_BASIC));
Also, the "title" property can be set at creation now.
Summary:
There could be a demand for providing subtle different item styles
according to the existence of icon or text swallowed in genlist item.
For example, if icon exists, genlist item shows icon, or show rectangle
where icon should be placed.
One style can have various form with this signal.
Reviewers: Hermet
Subscribers: Hermet
Differential Revision: https://phab.enlightenment.org/D2348
This commit also updated one of the elementary test to show
the new one of doing it.
This lets users of the API just add a callback and automatically
get animation ticks. It's done per window, because update rate
may be different for different windows (think different screens).
Summary:
Some newly implemented attributes are not present in several classes and
interfaces.
This patch:
- Adds some attributes (like @nullable, @optional, own, free) to several .eo files.
- Changes some eina types names to the equivalent eolian name (like "Eina_Bool" to "bool")
- Adds the element type of lists and iterators.
Reviewers: felipealmeida, tasn
Reviewed By: tasn
Differential Revision: https://phab.enlightenment.org/D2350
Jupp, its a dirty hack but it helps to work around the problem for now and
get the release out. I will revert it in master after the release and we
keep the bug open until this is fixed and hopefully backported.
ref T2367
This should be a proper fix for T1717. Idea is that we build a list of operation
that needs to be deferred in order (including pop and push) so that we are sure
we can pop and push in any order without the need to wait for any event.
Changed all the callback_call to pass the correct Elm_Object_Item
(Eo) pointer, was passing Elm_Slideshow_Item_Data instead.
@fix
Also updated the test
Summary:
If current item is disabled, next item should be
taken.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: raster, Hermet
Subscribers: singh.amitesh, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2458
Summary:
fix the _item_multi_select_down() function for
ELM_OBJECT_SELECT_MODE_DISPLAY_ONLY select_mode.
_item_multi_select_up is right, but _item_multi_select_down is wrong.
So fixed this.
Signed-off-by: Umesh Tanwar <umesh.tanwar@samsung.com>
@fix
Reviewers: Hermet, raster
Reviewed By: raster
Subscribers: sachin.dev, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D2452
Summary:
After discussion with DaveMDS, D2402 is a wrong fix and must be reverted.
This reverts commit a7978f931a4b67820b6b65758ce6f362c1ebec70.
Reviewers: cedric, DaveMDS
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D2437
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When content is resized, scrollbar's position is not updated.
Add bar position update after bar size is changed.
Test Plan: elementary_test -> scroller3
Reviewers: seoz, jaehwan, woohyun, cedric, raster, kimcinoo, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2419
Summary:
incorrect evas_object_box_children_get usage: returned list must be freed
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Differential Revision: https://phab.enlightenment.org/D2412
Summary:
1.) Fixing defective label position.
Whenever user create multibuttonentry and set some text into label,
label will be shown at zero point (0,0) of MultiButtonEntry parent.
But then, after clicking on any button of MBE object, label position forced to
be recalculated and changes it's position.
2.) Fixing wrong size when label is not used.
When label is not being used, buttons shift by few pixels,
and it looks like if label is actually there, which is wrong.
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Reviewed By: Hermet
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D2416
Summary:
The entry inactive signal emitted when finish spinner value set.
but the active signal emitted after that. so it makes weird view state.
The function 'key_action_toggle()' called twice. (for entry, spinner)
event propagate called this func twice and its make this issue.
This patch makes to ignore toggle event when entry is not visible.
T2262
Test Plan:
Run elementary_test, execute spinner widget sample.
Click the first spinner.
Input something on entry.
Press enter key.
Check the issue.
Reviewers: raster, Hermet
Subscribers: kuuko
Differential Revision: https://phab.enlightenment.org/D2411
Summary:
There is a invisible prev button. but it can get a focus and delete the current naviframe item.
Its not intend to added here i think, so i add a function that not add prev button automatically.
Test Plan:
Run elementary_test -> Naviframe Complex
Move focus use arrow key button and input enter key on prev button.
Click the View list, check the ERR msgs.
Reviewers: Jaehyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2420
Summary:
While setting theme currently changes style and theme to all button and
whole multibuttonentry object, it doesn't change few other parts of this object.
Part are, for examples, "guidetext", "label" and "closedbutton".
Fixing this sad mistake leads to be able to create different styles for such
wonderful widget.
@fix
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Reviewed By: Hermet
Subscribers: NikaWhite
Differential Revision: https://phab.enlightenment.org/D2407
Summary:
Reloading image in zoom in/out only if its previous orientation was changed
@fix
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: jpeg, raster, cedric
Differential Revision: https://phab.enlightenment.org/D2402
Summary:
Even if the given Evas_Object is NULL, API returns ELM_INPUT_PANEL_LAYOUT_NORMAL.
But, ELM_INPUT_PANEL_LAYOUT_INVALID seems proper in that case.
Test Plan:
Call the following API with NULL.
elm_entry_input_panel_layout_get(NULL);
Reviewers: woohyun, Hermet, eunue
Reviewed By: eunue
Differential Revision: https://phab.enlightenment.org/D2404
Summary:
Currently zoom in/out rotated or flipped image was causing lost of orientation
and aspect of image is also changed. Fixed that by reloading image on pan_obj on zoom
@fix
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: DaveMDS, jpeg, cedric, raster
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D2381
Summary:
In case of mirror enabled, wanted x should come from _elm_scroll_x_mirrored_get().
This defect is visible in case of some fancy effects on scroller (map).
@Fix
Reviewers: raster, Hermet
Subscribers: herdsman, sachin.dev, kimcinoo, eagleeye, seoz
Differential Revision: https://phab.enlightenment.org/D2363
when insert a new item before/after an item, the relative item should not be NULL.
this patch fixes naviframe, gengrid, genlist, list, and toolbar.
@fix
Summary:
theme change was delayed untill some other change (i.e. mode change, clock update)
@fix
Test Plan:
1. create new style "test" for elm_clock
2. add this style to theme
3. compare results of following modifications of src/examples/clock_example.c:
```
/* am/pm */
ck = elm_clock_add(win);
elm_object_style_set(ck, "test"); //style is applied before ap_pm set
elm_clock_show_am_pm_set(ck, EINA_TRUE);
```
and
```
/* am/pm */
ck = elm_clock_add(win);
elm_clock_show_am_pm_set(ck, EINA_TRUE);
elm_object_style_set(ck, "test"); //style is applied after ap_pm set
```
ExR: style is applied in both cases
Result without this patch: style is applied only in first case
Reviewers: cedric, seoz, raster, reutskiy.v.v, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2349
Summary:
Checkbox should support a third state "indeterminate" along with "Checked" and "Unchecked"
This third state is a state of checkbox which is shown when checkbox is neither Checked nor Unchecked.
- Added this new feature on the basis of a boolean variable's value.
- By default this boolean variable is disabled and checkbox will treat like old way.
- While adding this, I kept in mind, that applications which are already using checkbox, should not be affected, so I used 0=False=Unchecked, 1=True=Checked, and 2=Indeterminate
- Also added an example check_example_o2.c, which is using checkbox with both ways, using boolean, and using enum.
- Now also values can be set using boolean values, but it will give a type casting warning. As a boolean doen't support third state, so I used an enum int like.
- Added APIs to enable disable third state mode. elm_check_three_state_mode_set(check_obj, bool_val), and elm_check_three_state_mode_get(check_obj)
- Modified old APIs which were setting or getting states of checkbox.
- Added a state in theme of checkbox, with third state image.
Reviewers: seoz, raster, Sergeant_Whitespace, Hermet
Subscribers: Hermet, Sergeant_Whitespace, sachin.dev
Differential Revision: https://phab.enlightenment.org/D2249
Summary:
using theme of the object instead of default for subparts.
@fix
Reviewers: cedric, seoz, Hermet, raster, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D2370
Summary: This fixed the elm_win_window_id_get function when running in
wayland to return the ecore_wl_window_id rather than the surface id.
This change is necessary so that anyone calling this function can use
the return value in ecore_wayland function calls.
NB: Thanks to Hermet for pointing this out ! :)
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
The surface and context should not be current when deleted.
Evas GL would work just fine but since it deletes the surface
and context immediately upon request, those should not be
current.
This is a slightly different behaviour from EGL.
Flipselector has some random whitespaces that do not belong.
Additionally there are a few hidden non-blocking spaces that prevent
edje_cc to compile the default.edc on arm. Appearantly on x86/amd64 this
works normally.
This patch works around T2285 while the issue should remain open as the
real issue, edje_cc treating nbsp as a whitespace on arm, is not fixed
through this patch.
ref T2285
Signed-off-by: Olliver Schinagl <o.schinagl@ultimaker.com>
Without any locking or thread-safe mechanism, the previous implementation
would have failed as soon as too many file_set() happened on the same
object. Indeed, file_set() can happen while the async open thread is
running. I shouldn't have blindly listened to Cedric :P
Summary:
Issue: Mirroring of elm_panel not working correctly.
Solution: Handle mirroring appropriately for animations.
@fix
Test Plan:
Case: 1
1. Open elementary_test
2. Mirror on
3. Open scrollable panel, click on toggle button.
Case: 2
1. Keep the scroller panel opened
2. Turn off Mirror
Case: 3
1. Turn on mirror
2. Check direction button in non-scrollable panel.
Reviewers: shilpasingh, raster, Hermet, Princekrdubey
Reviewed By: shilpasingh
Subscribers: poornima.srinivasan, subodh6129
Differential Revision: https://phab.enlightenment.org/D2237
Summary:
Some APIs need to return specific values for their usage.
For Examples, elm_xx_select_mode_get function need to return
ELM_OBJECT_SELECT_MODE_MAX when invalid input comes.
**Fixed API list :**
elm_list_mode_get
elm_list_multi_select_mode_get
elm_genlist_mode_get
elm_genlist_select_mode_get
elm_genlist_multi_select_mode_get
elm_genlist_item_type_get
elm_genlist_ttem_index_get
elm_genlist_item_select_mode_get
elm_gengrid_select_mode_get
elm_gengrid_multi_select_mode_get
elm_gengrid_item_index_get
Test Plan: Call API with NULL parameter and check return value.
Reviewers: Hermet, seoz, jaehwan, raster, eunue
Subscribers: id213sin
Differential Revision: https://phab.enlightenment.org/D2306
Since the latest elm colorclass changes we need eldbus-codegen to generate
some files. Not all setups have this in their normal $PATH so let allow these
setups to set the correct path during configure. This allows our Jenkins setup
as well as others to work again.
why have elm image repeat events always (and unable to stop it)? this
is neither useful nor convenient. it's just painful. it makes images
not behave like prety much every object. they already are set up to
capture events - then do it normally.
@fix
Without depth, glview / evas gl basically fall back to indirect rendering.
Also change bg color from yellowish to brown (and use PREMULTIPLIED
colors, not random values).
This will allow apps to set the proper viewport, even if the
actual surface geometry didn't change.
This fixes a rare situation where the mode is changed from indirect
to direct (eg. in elm_test glview).
This commit enables generic broadcasting of changes in widget hierarcies.
Previously this kind of broadcasting had to be implemented inside widget.
This solution is using elm_widget sub_obj_add/sub_obj_del functions.
elm_interface_atspi_widget object was previously used to implement
atspi features on top of elm_widget object. However such inheritance
obfuscates a design, so atspi features implementation was moved directly
into elm_widget code.
Summary:
When object in elm_win lose their focus, elm_win save it on focus_highlight.prev structure,
and add **EVAS_CALLBACK_DEL** event callback. But after changed focus object also lose their focus from other,
**EVAS_CALLBACK_DEL** on prev object is not deleted if their in_theme is not **EINA_TRUE**.
This could be cause **'Memory Leak' **until previous focused objects are deleting.
checking in_theme of prev focus_highlight is for send signal on prev focused view(edje),
so 'if' sentence for checking previous existance and in_theme need to be separated.
@fix
Test Plan:
You can easily check this on elementary_test. launch radio sample and make focus by keyboard and
change focus repeatly, callback is added as per focus movement, but callback del is not called.
Reviewers: seoz, woohyun, raster, Hermet
Reviewed By: Hermet
Subscribers: jaehwan
Differential Revision: https://phab.enlightenment.org/D2276
Summary: I missed this during btn object type change to layout from edje object .
Reviewers: Hermet, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D2289
NO! this breaks compiling anything against elementary UNLESS you
enable eo beta api support. NO NO NO NO.
This reverts commit cad6de2a8ef93d994f9dedb8e980efe5fbf6d77e.
Summary:
Added to Entry new signal "validate", this signal called from entry every
time when the text inputed to entry.
The regex validation add as elm_helper.
The styles of Entries scrollers are changed to allow highlightion that
is needed by regex processing.
For use regex with entry need register the regex helper as callback
to event: ELM_ENTRY_EVENT_VALIDATE
@feature
Test Plan:
See elementary_test "Entry Regex" test.
Note: when the string matches to regex the highlighting (green) is reset on unfocusing.
Reviewers: herdsman, raster, cedric, tasn
Reviewed By: cedric, tasn
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D2043
Summary: Adding a get API because of having only elm_object_access_info_get().
Reviewers: jaehwan, kimcinoo
Differential Revision: https://phab.enlightenment.org/D2271
This reverts commit 52c8f4fe7ec42efa6889d707e2380697ffe7dbb4.
This broke the build when starting from a clean repo.
I'll try to improve this patch later, maybe.
Building the widget_preview_xxx programs takes a while and should
be required only when rebuilding the doc. Arguably breaking something
in elm may break only the widget-preview build but I believe this is
a rare case.
This speeds up a regular elm build by >20s on my machine.
This commit is related to 260cdd6150d567fcee8d1afaf690e4b90cd16a2b.
When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
Summary:
A pointer to the internal Elm_Naviframe_Item_Data was mistakenly being passed as
event_info.
This patch changes the callback_call to pass the correct Elm_Object_Item (Eo) pointer.
Reviewers: #elementary, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2222
Summary: Add long pressed callback for application. test code changed to following this change as well.
@feature
Reviewers: seoz, woohyun, Jaehyun, Hermet
Differential Revision: https://phab.enlightenment.org/D2103
Conflicts:
src/lib/elc_multibuttonentry.c
Summary:
This allows to build binaries that will not look for the directory passed to
the configure with --prefix at build but will look for data files according to where
the exe has been installed.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This allows to build binaries that will not look for the directory passed to
the configure with --prefix at build but will look for data files according to where
the exe has been installed.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This allows to build binaries that will not look for the directory passed to
the configure with --prefix at build but will look for data files according to where
the exe has been installed.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
This allows to build binaries that will not look for the directory passed to
the configure with --prefix at build but will look for data files according to where
the exe has been installed.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If dbus is not installed the task switcher raise a segmentation error.
So we check if the returned variable by eo_do is not null before continuing.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
On Windows, if we are running the application from Msys or Cygwin, we will
get the HOME environment variable. Otherwise we need to use Windows environment variables
"HOMEDRIVE" and "HOMEPATH" to get the home path.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
On Windows we can get the HOME environment variable if we launch the application
from Msys or Cygwin, otherwise we need to use "HOMEDRIVE" and "HOMEPATH" to get
windows home path.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Get right application prefix by using elm_app_data_dir_get() for the
slideshow images.
@fix
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
If elm_object_text_set() function is called twice,
elm_obj_containter_content_set(CONTENT_PART, sd->text_content_obj)
function makes sd->text_content_obj null since sd->text_content_obj already exists.
Test Plan:
1. run elementary_test(popup) and excute "popup-center-text + 1button (check hide, show)"
2. print sd->text_content_obj value in content_text_set()
3. push hide button and excute the example again
4. check sd->text_content_obj value if null or not
Reviewers: woohyun, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D2225
Summary:
In case of the toolbar item size is fixed, the size of toolbar item became finger size.
so, after signal emission in _inform_item_number(),
edje_object_size_min_restricted_calc() and evas_object_size_hint_min_set() function are added.
Test Plan: change edc for supporting fixed toolbar item and run examples of toolbar in elementary_test
Reviewers: woohyun, seoz, Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D2184
Summary:
namespacing is wrong for tooltip label. Although we still support old theme
but it should be removed in EFL 2.0.
Test Plan: elementary_test -to tooltip
Reviewers: seoz, Hermet, raster
Reviewed By: raster
Subscribers: kimcinoo, sachin.dev, seoz
Differential Revision: https://phab.enlightenment.org/D2120
Summary:
Some app like calendar, they heavily depend on the value of datetime,so to ensure accuracy
second field is considered while comparing datetime values.
@fix
Test Plan: NA
Reviewers: shilpasingh, raster
Reviewed By: shilpasingh, raster
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2204
Summary:
In POSIX, some format include extra character like dash, hash, etc, which gives unexpected behaviour.
Fix to filter out those character.
Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>
@fix
Test Plan:
1. Set datetime as POSIX locale.
2. Check the datetime behaviour in elementary_test.
Reviewers: raster, shilpasingh
Reviewed By: shilpasingh
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2203
Summary:
Datetime value should be compared earlier to avoid unnecessary code execution.
Also added logic for single field comparion which will avoid to compare all fields when field limit is set.
Signed Off By: Seongjun Yim <se201.yim@samsung.com>
Signed Off By: Hyunseok Yang <hs0219.yang@samsung.com>
Signed Off By: Subodh Kumar <s7158.kumar@samsung.com>
Test Plan: NA
Reviewers: shilpasingh, raster
Reviewed By: shilpasingh, raster
Subscribers: poornima.srinivasan, govi, rajeshps
Differential Revision: https://phab.enlightenment.org/D2202
This feature works the infinite loop horizontally or vertically.
If the content is set, it will be shown repeatedly.
@feature
Change-Id: I1f20b794ae44bc8e5d120901222c7cccadca96b7
Conflicts:
src/lib/elm_scroller.c
src/lib/elm_scroller_legacy.h
"file" property in Efl.File interface is virtual pure,
so according to OO principles must be implemented in derived classes.
This patch adds implementation of "file.get" in Elm_Layout.
Further, Elm_Video class has it's own implementation of "file.set",
thus also requires implementation of "file.get"
Summary:
There is a bug that popup can't get proper size when list is set as its content.
Because of unneccesary calling evas_object_show() in popup's overriding elm_obj_container_content_set(),
sizing eval doens't work correctly.
This patch fixes this bug.
Test Plan:
Execute 14th popup sample in "elementary_test popup".
(popup-center-title + list content + 1 button)
After applying this patch, popup shows correctly.
Reviewers: seoz, Hermet
Reviewed By: Hermet
Subscribers: Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D2158
Summary:
Call evas_font_reinit() API before applying font overlays when config is fully reloaded.
Application could modify or add font config "*.conf" files.
And It should affects all of other running EFL application.
So, put evas_font_reinit() API to be called when x win property is changed.
@feature
Reviewers: cedric, raster, tasn, woohyun
Differential Revision: https://phab.enlightenment.org/D2113
Summary:
Setting focus to entry object when text is being selected
@fix
Test Plan:
1. open "elementary_test entry3"
2. click on the big entry
3. mouse down on singleline entry to start selection
4. move mouse out of window
5. mouse up. text in that entry seems to be selected
6. press del or type any text
expected result: selected text in singleline entry is deleted/replaced
result without this patch: singleline entry is not focused and all edit actions are affecting the big one
Reviewers: cedric, Hermet, seoz
Subscribers: poornima.srinivasan, subodh6129, raster, reutskiy.v.v, herdsman
Differential Revision: https://phab.enlightenment.org/D1476
Summary:
spinner don't changes its size after showing entry.
Entry is now clipped to area between arrows.
Test Plan:
1. Run "elementary_test spinner"
2. Click on top spinner. It shouldn't resize
3. Type very long number. It shouldn't overlaps arrows.
Reviewers: Hermet, raster, seoz, cedric
Subscribers: raster, reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1509
This reverts commit 841fcdfb18a414a7381910bcbb0b0ef4807bc5c2.
It's been too much passed.
we have more dependencies to the change (ie, key bindings)
so conclude to have the abi break in this case.
Summary:
The strcmp(line 738) has been failed since the eo applied.
the widget type get API returned "Elm_Genlist" now.
For fix it, using eo_isa() to check object types instead of string comparison.
@fix
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2148
Summary: If _elm_image_object_size_get fails, w and h have garbage value.
Test Plan: no
Reviewers: seoz, Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D2163
The problem occurs when no drop target below the mouse can receive the
data type provided and the mouse button is released. The mouse pointer
stays grabbed and this leads to issues for the next drags.
To solve this, on a bad drop, the destination window has to request
from the source window the end of the dnd.
Summary:
When evas gl/elm glview runs with direct rendering, it can not set these bits to window surface.
Because of no interface and method.This patch can do that.
This patch just uses current interface as a elm_config_accel_preference_set instead of new API.
Also, it is related D2144 patch.
Test Plan: ElmGL View test menu in elementary_test app JP's test app.
Reviewers: spacegrapher, cedric, raster, jpeg
Reviewed By: jpeg
Subscribers: mer.kim
Differential Revision: https://phab.enlightenment.org/D2145
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Summary:
Fix incorrect scroller content region calculation of panel.
It is fixed that the parent of panel content becomes scr_ly if panel is scrollable.
Test Plan:
Test Panel Scrollable in elementary_test.
1. Change panel orient as ELM_PANEL_ORIENT_RIGHT in test_panel.c.
2. Run elementary_test and test Panel Scrollable.
3. You can see the right panel drawer is hidden right after it is shown.
(After applying this patch, this problem will be resolved.)
Reviewers: seoz, woohyun, eunue, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2125
Summary:
The _item_unselect() fucntion called at _elm_genlist_select_mode_set() with parameter.
It makes crash when access it->item. it is eo item type actually so it doesn't have member as item or something.
@fix
Test Plan:
1. Run elementary_test
2. Execute genlist
3. Select an item on list and click Next API fucntion button 2times.
4. Check the crash.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Subscribers: SanghyeonLee
Differential Revision: https://phab.enlightenment.org/D2136
Summary:
When unrealized item is focused, edje object is not exist,
so genlist cannot read the focus highlight information from edje object.
Therefore, when the item is realized, check the item is focused or not and
need to update focus highlight.
@fix
Test Plan: change edc for supporting focus highlight in edc, and set focus on unrealized items.
Reviewers: raster, seoz, jaehwan
Differential Revision: https://phab.enlightenment.org/D2128
Summary:
API changed from "edje_object_signal_callback_add()" to "elm_layout_signal_callback_add"
to following code refactoring.
Reviewers: seoz, woohyun, Jaehyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2102
Summary:
The _text_aliases value exists. but never use here on layout for text part aliases.
in addition, i think that "elm,text" should be the default part for text set.
Reviewers: seoz, woohyun, JackDanielZ, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2116
Summary:
When parent is resized, popup keeps its original size.
This patch makes popup have proper size in proportion to parent's size.
T2082
Test Plan: You can check the effect of this patch in "elementary_test popup".
Reviewers: seoz, Hermet
Subscribers: stefan_schmidt, J5lx, seoz
Differential Revision: https://phab.enlightenment.org/D2121
Summary:
This restack callback added for support previous tree [parent - notify - popup].
The popup has been redesigned to have correct tree [parent -popup - notify].
So the restack callback does not need anymore.
Test Plan:
1. Run elementary_test
2. Execute popup sample.
3. Activate popup which has restack feature.
4. Check the result.
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D2127
Summary:
Since this patch ctxpopup is able to report its size which is equal to 1 element of list.
This can be treated as another bug (list visibility implementation must be so list will be counting its size dynamic on every item add)
Might be also ignored.
Test Plan:
1. Use application provided in T2042 (should have coordinates greater then 0).
2. Using atspi check is accessible element is visible. (with patch ctxpopup will be visible, without ctxpopup and its children will have status visible and showing set to FALSE)
Reviewers: raster, seoz, Hermet
Subscribers: m.jagiello
Projects: #elementary
Maniphest Tasks: T2042
Differential Revision: https://phab.enlightenment.org/D2045
the original code for handling label positioning was not robust enough to handle
cases such as ibar scrolling or gadget moving. this greatly simplifies the code
as well as handling all cases and providing small animations for moving the label
when necessary
This fixes partly T1828
Summary: Use the feature provided by ibar.
Reviewers: raster, zmike
Subscribers: zmike
Differential Revision: https://phab.enlightenment.org/D1797
Summary:
Add extra check to prevent crashing when user clicks configuration
test from elementary_test window
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz, cedric
Differential Revision: https://phab.enlightenment.org/D2086
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
Item width max size set as 130 in edc before, i thinks that value doen't have any meaning,
so i changed the item max width size to follow container width size.
For modification, item size calc, box resize logic changed.
Test Plan:
1. Run elementary_test
2. Execute multibuttonentry sample.
3. Input some text for make item.
Reviewers: Hermet, seoz, woohyun, Jaehyun
Differential Revision: https://phab.enlightenment.org/D1970
Restacking not selected item should be selected after it is done.
@fix
Test Plan:
1. run in console
> elementary_test "Genlist Reorder Mode"
2. Switch to reorder mode
3. Select Item #6
4. Try to restack Item #4
(not selecting it, but holding mouse on it and moving down)
5. See that Item #4 and Item #6 is not selected
Reviewers: cedric, Hermet, raster, seoz
Subscribers: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D1931
this adds logic in elm widget and elm win to figure out how to
automatically show a focus hilight when switching focus, or to hide
it. this really should be the default mode, thus in all default
profiles (default, standard, mobile) it's turned on. this means if you
tab or shif+tab or use arrow keys to switch focus, the focus hilight
will magicallly appear. click with a mouse to change focus and it'll
disappear assuming you want to use the mouse to do things. If focus is
explicitly turned on in config or in the window by api, then this has
no effect and focus will remain on all the time. this adds apis to
change these config values and options in the default elm config tool
to swizzle them as well as config upgrade handling for existing configs.
@feature
Summary:
Issue: Focus was not getting transferred individually on arrow buttons and text area.
Solution: Remove the usage of image parts and text parts and replace them with buttons
so as to handle the focus transfer normally than forcibly via smart event.
hence Focus next hook and focus direction hook is implemented.
Signed-off by: Subodh Kumar<s7158.kumar@samsung.com>
Signed-off by: Shilpa Singh<shilpa.singh@samsung.com>
Test Plan:
Use keyboard keys on spinner and test focus transfer, enable accessibility and test
accessibility.
Reviewers: woohyun, Hermet, shilpasingh, raster, seoz
Reviewed By: shilpasingh, raster
Subscribers: stefan_schmidt, raster, rajeshps, govi
Differential Revision: https://phab.enlightenment.org/D1911
Removed default disable automatic mirroring of hoversel.
Summary:
Removed below API call for hoversel, hover, box and button object
elm_widget_mirrored_automatic_set(obj, EINA_FALSE);
Modified theme of "elm/button/base/hoversel_vertical_entry/default" to remove console errors due to theme, and modified text.align to -1 as 'x' value to set auto align for Arabic text.
Modified example hoversel_example_01.c to illustrate mirroring functionality
@fix
Reviewers: Hermet, seoz, tasn
Subscribers: sachin.dev
Differential Revision: https://phab.enlightenment.org/D1910
Summary:
1. Implemented genlist mode ELM_LIST_EXPAND
2. Implemented content_min_limit function which override scroll interface.
This function will be used by call API elm_scroller_content_min_limit.
This function will set the object minimum size as its scroll content size,
if parameter value is EINA_TRUE.
@feature
Test Plan: Add new test case in test_popup.c
Reviewers: raster, seoz
Subscribers: stefan_schmidt, bluezery
Differential Revision: https://phab.enlightenment.org/D1279
when a layout's theme is changed by elm_layout_theme_set, the edje is updated
according to the widget's states such as 'disabled' or 'highlight_in_theme'.
but the update is dropped for elm_layout_file_set.
this patch tied up the codes into _visuals_refresh function
so that the same update happens for elm_layout_file_set.
@fix
Summary: When running the E startup wizard using DRM, the cursor ends
up getting unset (and never reset) due to the DRM engine not having a
wayland window. To fix this, we will test the the engine being DRM and
if so then set the cursor->use_engine to false so that it defaults to
ecore_evas_object_cursor calls (which work on DRM).
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Summary: If we are unsetting the cursor for an object, then if it's an
object on a wayland window, we should be callbacking
ecore_wl_window_cursor_default_restore
@fix
Signed-off-by: Chris Michael <cp.michael@samsung.com>
There is no reason why drop targets callbacks registered for a specific
type would be invoked when a not supported data is dragged.
This patch fixes it by comparing the data type and the callback type of
the drop target. Only the callbacks supporting the data type are
invoked.
During a DnD position event, we need to find the first dropable target
located under the mouse pointer; one of its callbacks has to support
at least one of the types of the dragged data.
This search process was done by strcmp-ing types for every drop target
and for each of their types until a good target is found.
This patch improves the process by comparing types formats, i.e and-ing bits
vectors.
Summary:
When box has expanded items (evas_object_size_hint_weight_set() with EVAS_HINT_EXPAND)
and homogeneous is set (elm_box_homogeneous_set() with EINA_TRUE),
there is a bug that it miscalculates its items size omitting padding size (space among items),
so the last item looks cropped or having smaller size than others.
This patch makes box calculate its items' size correctly.
T2033
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Maniphest Tasks: T2033
Differential Revision: https://phab.enlightenment.org/D2016
Summary:
If user sets the limit value using elm_datetime_field_limit_set() API, the filed value will be recalculated.
Even though the value changed in case, value changed signal didn't send to user before.
@fix
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1980
Summary:
When an item is realized, select/disable/expand signal emission to the view object of an item was handled correctly,but there are no updating code for focus state.
@fix
Test Plan: tested by editing genlist/genlist item edc to react on elm,state,focused and move scroll signals to unrealized/realized item again.
Reviewers: raster, seoz
Reviewed By: seoz
Subscribers: eunue
Differential Revision: https://phab.enlightenment.org/D2024
Summary: The API "elm_box_horizontal_get" missed @ingroup tag. so i added the tag for grouping when doxygen making API documentation.
Reviewers: Hermet, JackDanielZ, Jaehyun, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1966
Summary:
Thumbscroll is disabled in default configuration,
but "scrollable" feature in panel only works when thumbscroll is turned on.
To make "scrollable" work always in elementary test,
this patch enables thumbscroll temporarily regardless of configuration.
(configuration is restored when sample window is closed.)
Reviewers: Hermet, seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1983
Summary:
evas_image_orient_set is a newly added API to set orientation of evas image.
Using this API to set orientation of image widget.
Also removed Elm_Image_Orient enums and replaced it with Evas_Image_Orient enums.
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: raster, seoz, cedric
Differential Revision: https://phab.enlightenment.org/D1987
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
This reverts commit 83f94464f1743cfa55e6b39704c605978edcee19.
This is incorrect. both windows evas are different,
we cannot set the child window as the resize object.
This reverts commit 72ef635ff3b8939509ecfb29ecf19e465b40e652.
changing a test so that it will not crash in a valid use case is not an appropriate fix.
ref T1973
Summary:
This small application for quick testing main features and changes in Evas 3D.
Main features: effects shadow, fog, measuring fps, load 3D model, panel for change
sets light and camera.
Reviewers: Hermet, raster, cedric
Differential Revision: https://phab.enlightenment.org/D1953
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
elm_transit_go() is executed immediately after it is called.
elm_transit_go_in() starts transit in given seconds.
@feature
Reviewers: Hermet, seoz
Reviewed By: seoz
Subscribers: seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1954
Summary:
_current_item_change() called at _item_select() internally.
it means _current_item_changed() called two times in vain.
so that's why item select callback called two times.
@fix
Test Plan:
1. Run elementary_test
2. Excute multibuttonentry sample.
3. Added some items and click the item area.
4. Select signal called two times.
Reviewers: Hermet, woohyun, JackDanielZ, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1955
now when a whele event comes in, 1. the amount we scroll accelerates
based on time between wheel events (the faster wheel events come out,
the more accel), and 2. we animate to the new position providing a
smooth transition to the new spot rather than a jump. very visually
nice.
@feature
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
there was no way to select an item with key input on ELM_ITEM_SELECT_ON_FOCUS_DISABLE mode.
this patch enables select and multi select with enter/space key input.
@fix
Summary:
elm_coords_finger_size_adjust() is called twice.
It might not be intended.
Reviewers: Hermet, Jaehyun, seoz
Reviewed By: seoz
Subscribers: raster, seoz, Hermet
Differential Revision: https://phab.enlightenment.org/D1924
this fixes a deprecation of elm engine done just before 1.13 release
that ends up breaking "make doc" and also will make ELM_ENGINE env var
stop working (the latter was intentional). but since this is relied on
for things like make doc - keep the env var and haveit set preferred
engine and let people migrate away from using the engine var EXCEPT
for things like the shot engine
@fix
Summary:
There was no consistency with another widget which has item object, basically widgets has Elm_Object_Item object for own's item object.
but multibuttonentry used edje object for item object before.
Test Plan:
1. Run elementary test.
2. Execute multibuttonentry.
3. Doing variety action on multibuttonentry widget.(add, delete, key event, focus etc...)
Reviewers: seoz, woohyun, Jaehyun, Hermet, JackDanielZ
Subscribers: herdsman, cedric
Differential Revision: https://phab.enlightenment.org/D1864
Summary:
elm_layout_content_set API calls _elm_panel_elm_container_content_set func.
The panel widget checks the given "parts" string is whether "elm.swallow.event" or not.
To avoid error message and set the given object to the "elm.swallow.event" internally,
the panel widget need to call *_content_set for "elm.swallow.event" part using eo_do_super.
@fix
Test Plan: elementary_test -> panel
Reviewers: seoz, woohyun, Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1949
Summary:
1) According to description in .eo file,
some APIs return not 0 when the given object is NULL or not proper object.
But, several APIs are not implemented as those description.
Now, they will return a value as description.
2) If there is no description about the return value when the API fail,
put description according to pair API or old version of elementary.
@fix
Reviewers: woohyun, Hermet, seoz
Differential Revision: https://phab.enlightenment.org/D1933
Summary:
Resolved FIXME filled all smart callbacks and also set it in the constructor
Signed-off-by: kabeer khan <kabeer.khan@samsung.com>
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D1876
the elm config tool only lets you set accel preference. if you set
none, then the old engine config takes charge, but there is no way to
change/set this, so deprecate the old engine set and don't use it.
this accel preference has been around for a while, so use it now
instead.
Summary: Added indicator_visible_mode to each slider in order not to make elm_config controlls every sliders.
Reviewers: Hermet, woohyun, seoz
Subscribers: seoz
Differential Revision: https://phab.enlightenment.org/D1887
Summary:
When ecore_evas_window_profile_supported_get API return EINA_FALSE,
elm_win widget should not get profile from ecore_evas_window_profile_get API.
@fix
Reviewers: woohyun, Hermet, seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D1943
while this is technically an abi break, it should actually have no
real impact. it will have warnings - sure, but running existing code
will simply not see the extra parammeters on the stack and not use
them so it'll continue to work. if we removed paramms, we'd be in
pain. (same applies to params passed in registers).
this fixes T2031
Summary:
There is a bug that text disappears when theme is changed after label shown.
This patch fixed it.
@fix
Reviewers: woohyun, Hermet, Jaehyun, seoz
Subscribers: Jaehyun, seoz
Differential Revision: https://phab.enlightenment.org/D1923
Summary:
tooltip could be hide by the other object which have lower layer than target object of tooltip.
the layer of content could be changed, when is set to the tooltip as a content.
@fix
Test Plan: check added test lines
Reviewers: cedric, jpeg, seoz, raster
Reviewed By: raster
Subscribers: singh.amitesh, stefan_schmidt, seoz
Differential Revision: https://phab.enlightenment.org/D1889
Summary:
Label should not start sliding before elm_label_slide_go() is called.
However, label starts sliding automatically,
because resize callback emits slide start signal.
This patch prevents label from sliding before calling elm_label_slide_go().
@fix
Reviewers: woohyun, Hermet, seoz
Subscribers: CHAN, woohyun
Differential Revision: https://phab.enlightenment.org/D1906
Summary:
Eina_List from elm_gengrid_realized_items_get must be freed by caller,
but elm_gengrid_realized_items_update doesn't free Eina_List.
So memory leak is happens.
@fix
Test Plan: Call elm_gengrid_realized_items_update repeatly and check memory share increase.
Reviewers: raster, seoz
Differential Revision: https://phab.enlightenment.org/D1903
Summary:
It could success only when the widget was visible.
The API must return EINA_TRUE if buffer and size has no problem, not visiblity of widget.
@fix
Reviewers: Hermet, woohyun, jpeg
Differential Revision: https://phab.enlightenment.org/D1917
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Summary:
When layout clicked, "elm_widget_on_focus()" called with "entry_focus_in()" callback.
The "view update" and "focus set to entry" already call in those callbacks, so i deleted duplicate code and it also make focus issue when user click the entry to add item.
@fix
Test Plan:
Run elementary_test.
1. excute multibuttonentry.
2. click the entry area.
3. see the elm_widget_on_focus called twice.
(layout callback function called view update -> elm_box_unpack called in view update ->
entry lose focus -> on_focus_callback call again)
Reviewers: Hermet, seoz, Jaehyun_Cho, JackDanielZ
Differential Revision: https://phab.enlightenment.org/D1902
Summary: The API must return ELM_WIN_UNKNOWN (-1) when the given object is improper.
Test Plan: None.
Reviewers: woohyun, JackDanielZ, seoz
Differential Revision: https://phab.enlightenment.org/D1907
Use the min between w and h of the evas object to
request the size in the icon theme. Fdo icon are always
square (1:1) so min seems correct.
Also improved the test to include a test that do
not relay on the size_hint_min of the icon.
Now in all the test I have done always the correct
fdo icon are used.
This reverts commit 75176a789981bd6b1ef0bfcc95793c896b5bde07.
Was not the correct solution, as min_size can be smaller than
the real wanted size. Need to find another solution.
Thanks TAsn to spot this
This @fix fdo icons to load the correct image for the requested size.
Whitout this the small images (16x16) was never used, because once a big
(64x64 for example) image was loaded, that size was used as min.
See the Icon Standard test for a better explanation
The code there was trying to reload the icon to have an
image that should match the requested size, this was totally
wrong, the calculation was always resulting in an image bigger
than the needed.
It was also useless as this logic is yet handled in the resize
callback.
You can now select the size of the icons in the list and
also added a single icon that you can resize.
The size of the icons is important as icon themes usually
provide different images for different sizes.
This test now spot out some errors in elm_icon wrt icon
sizing, will fix soon
This fixes the side effect that introduced from 1e06309be42fd2b5d0900b16da0178215c111681
Since transit has supported adding a map effect on the previous map status,
transit tried to access object-state map pointer.
but theses map pointer won't be valid if the transit keeps the last state
because it doesn't back up any object-state data.
- Do not set unnecessary min size for the icons. Just follow list's item
size naturally.
- Do not free unnecessary list which was already freed by
EINA_LIST_FREE.
- Do not set align for the window resize object which is not required to
be set.
- Follow conventional way of pointer declaration.
Previously, entry set handlers' style as default when they are created
and changed style on theme_apply function. But in usual scenario, users create
entry and set style before handlers are created, so when they are created
the style is set as default regardless of the style users already set.
This patch fixes it.
@fix
This reverts commit f99be3a1d6bdc63153598b592b5437c33da44bf0.
The API is not ready to be released. Please see the thread on the e-devel
mailing list under this subject. This can get another try in the 1.14
release cycle.
Conflicts:
src/lib/elm_genlist.c
Summary:
Fix crach issue caused by multiple transit effects on a single object.
This patch prevents deleting obj_data while the obj_data is still used by other transit objects.
This fix is related to commits "Support zoom keeping current map effect."(60214e6a172e42303fdfc69ef3d1996b25132242)
and "Support rotation keeping current map effect."(1e06309be42fd2b5d0900b16da0178215c111681).
@fix
Reviewers: Hermet
Differential Revision: https://phab.enlightenment.org/D1878
user request was ignored if they calls the genlist_item_selected_set(true)
to another item in an item selected callback. because genlist made
the selected item highlighted after user "selected" callback.
The behavior had been changed on my genlist refactoring,
so the behavior was actually just restored.
This issue resolves T2020
Summary:
Fix to support zoom rate zero by using evas_map_util_zoom() instead of evas_map_util_3d_perspective().
@fix
Reviewers: Hermet
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D1877
Note that the iterate function will never trigger the idler that are registered
in Ecore. That's by definition. I changed the code to actually use the full
main loop and trigger the change detection on idle enterer. That should be enough
for Elementary as all idler should logically affect the visual aspect of something
at some point and exit idle.
Thanks marcel-hollerbach@t-online.de for helping me debug this issue.
This reverts commit c80b24baf815e35c160bf0dbe8ecae6ea247aef8.
this broke the selection callback completely and makes every genlist app unusable.
please, please, please, please, I'm seriously begging you hermet, do ANY amount of testing before making further genlist commits.